mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fabian Frederick <fabf@skynet.be>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Joel Becker <jlbec@evilplan.org>
Subject: Re: [PATCH 2/2] FS/CONFIGFS: Use pr_fmt
Date: Tue, 13 May 2014 18:06:50 -0400	[thread overview]
Message-ID: <75410.1400018810@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Tue, 13 May 2014 13:50:49 -0700." <20140513135049.2d160a63d662b3aab6ba3c03@linux-foundation.org>

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

On Tue, 13 May 2014 13:50:49 -0700, Andrew Morton said:
> On Tue, 13 May 2014 20:24:28 +0200 Fabian Frederick <fabf@skynet.be> wrote:

> > +#ifdef pr_fmt
> > +#undef pr_fmt
> > +#endif
>
> Why this?
>
> > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Won't GCC whinge by default about the #define if it doesn't exactly match the
previous definition?

[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]

  reply	other threads:[~2014-05-13 22:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 18:24 Fabian Frederick
2014-05-13 20:50 ` Andrew Morton
2014-05-13 22:06   ` Valdis.Kletnieks [this message]
2014-05-13 22:15     ` Andrew Morton
2014-05-13 22:30       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75410.1400018810@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=fabf@skynet.be \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®