From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752780AbdK1Nlh (ORCPT ); Tue, 28 Nov 2017 08:41:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38500 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126AbdK1Nlg (ORCPT ); Tue, 28 Nov 2017 08:41:36 -0500 Date: Tue, 28 Nov 2017 08:41:36 -0500 (EST) From: Bob Peterson To: Tetsuo Handa Cc: Steven Whitehouse , cluster-devel@redhat.com, linux-kernel@vger.kernel.org Message-ID: <754398122.35111640.1511876496295.JavaMail.zimbra@redhat.com> In-Reply-To: <1511416659-4595-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> References: <1511416659-4595-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> Subject: Re: [PATCH] gfs2: Fix wrong error handling in init_gfs2_fs() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.3.116.168, 10.4.195.13] Thread-Topic: gfs2: Fix wrong error handling in init_gfs2_fs() Thread-Index: xB7PKDVE7QfWHmzixsUF10hUm1YIvg== X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 28 Nov 2017 13:41:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- | init_gfs2_fs() is calling e.g. calling unregister_shrinker() without | register_shrinker() when an error occurred during initialization. | Rename goto labels and call appropriate undo function. | | Signed-off-by: Tetsuo Handa | --- | fs/gfs2/main.c | 90 | ++++++++++++++++++++++++++++------------------------------ | 1 file changed, 44 insertions(+), 46 deletions(-) Hi, ACK. Thanks; this is a nice cleanup. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=8b0d7f56b97b95a442b6785027a0f80ad1ea54af Regards, Bob Peterson Red Hat File Systems