Hi Mark, Thanks for the comments. Please find my inline replies below: > As covered in submitting-patches.rst you should send one patch per > change, this makes things much easier to review. Okay. I will submit these fixes as a new patchset. > I am unclear how chip select will ever be asserted with this change? > Now the value is only written if we are disabling. In PCI1xxxx, there is a common bit in hardware to enable / disable chip select lines. I will use this bit in pci1xxxx_spi_set_cs API in the upcoming version of patch. Currently, this bit is used within pci1xxxx_spi_transfer_one API. Thanks, Tharun Kumar P