From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F375C433E1 for ; Sat, 13 Jun 2020 17:28:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68C042074D for ; Sat, 13 Jun 2020 17:28:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726535AbgFMR2c (ORCPT ); Sat, 13 Jun 2020 13:28:32 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:27111 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726404AbgFMR2b (ORCPT ); Sat, 13 Jun 2020 13:28:31 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 49kl1Q0G8Fz9tyVJ; Sat, 13 Jun 2020 19:28:26 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id V0taFgg7QO5z; Sat, 13 Jun 2020 19:28:25 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 49kl1P50Mkz9tyVH; Sat, 13 Jun 2020 19:28:25 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id EF0DE8B77C; Sat, 13 Jun 2020 19:28:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id sBMC7z0GI5Bp; Sat, 13 Jun 2020 19:28:27 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D512F8B76A; Sat, 13 Jun 2020 19:28:26 +0200 (CEST) Subject: Re: [PATCH] powerpc/fsl_booke/32: fix build with CONFIG_RANDOMIZE_BASE To: Arseny Solokha , Michael Ellerman , Jason Yan , linuxppc-dev@lists.ozlabs.org Cc: Scott Wood , Christophe Leroy , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20200613162801.1946619-1-asolokha@kb.kras.ru> From: Christophe Leroy Message-ID: <754d31be-730b-8f18-4ead-ba2f303650d0@csgroup.eu> Date: Sat, 13 Jun 2020 19:28:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200613162801.1946619-1-asolokha@kb.kras.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 13/06/2020 à 18:28, Arseny Solokha a écrit : > Building the current 5.8 kernel for a e500 machine with > CONFIG_RANDOMIZE_BASE set yields the following failure: > > arch/powerpc/mm/nohash/kaslr_booke.c: In function 'kaslr_early_init': > arch/powerpc/mm/nohash/kaslr_booke.c:387:2: error: implicit declaration > of function 'flush_icache_range'; did you mean 'flush_tlb_range'? > [-Werror=implicit-function-declaration] > > Indeed, including asm/cacheflush.h into kaslr_booke.c fixes the build. > > The issue dates back to the introduction of that file and probably went > unnoticed because there's no in-tree defconfig with CONFIG_RANDOMIZE_BASE > set. I don't get this problem with mpc85xx_defconfig + RELOCATABLE + RANDOMIZE_BASE. Christophe > > Fixes: 2b0e86cc5de6 ("powerpc/fsl_booke/32: implement KASLR infrastructure") > Cc: stable@vger.kernel.org > Signed-off-by: Arseny Solokha > --- > arch/powerpc/mm/nohash/kaslr_booke.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/mm/nohash/kaslr_booke.c b/arch/powerpc/mm/nohash/kaslr_booke.c > index 4a75f2d9bf0e..bce0e5349978 100644 > --- a/arch/powerpc/mm/nohash/kaslr_booke.c > +++ b/arch/powerpc/mm/nohash/kaslr_booke.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include >