From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959D741A91C for ; Wed, 12 Aug 2026 09:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786528110; cv=none; b=SAihlJzoL9SILin4rLD71pgHxGuPtxvPKSdlQIkhJlhfDP5thSTnOT/PbiwvFl9FdmUIw4oWuJnnSbhb0CQ7SavL8bd++tC65B7eU9BFUgYs699UrvuBggcPRoChrxR8h5qI6cxFfR6YwhchGU5J3Ggbq8N4QCqNVw46YSDljOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786528110; c=relaxed/simple; bh=zfcQ4EG2OtCNn5ocZf9Krc4CphTLDxQS5rKzoGFUnbQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JZTijX0/bx54J24Dk59tfdg467b40RgPu0axYwcjX6QQ/idqbBo2SnfnOvXhEsLwo91yYeS/TrDPWyA84wUW1j5AE59yHzsIAf/52lKeNVfznsqAylgOQ3VNQUjx/1cHwInhD1zk+cxUaEIFBdSYZFPbi/MEpmt18nUM0393USc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wsAFTU+Y; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wsAFTU+Y" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-496bb7cdf51so8303775e9.2 for ; Wed, 12 Aug 2026 02:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1786528107; x=1787132907; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cgAavsMPfj374Y2O8g0TeLMK69exN+jOmzYmrQT4dPo=; b=wsAFTU+YCu1BRUS2Johz9KzMzmMUPRt15rEHcN7+aIWDwqJi5gjCSVBWUiWTF4gvvv e5OeNYSBCtV6mtp7CXlCPMLvoDGqzkv8d+ryOnSfytCLlV61nW90JxFCGxFssbc2X3QZ lnrWvE5eNY+uQIE58Xsl5arfgcD1m4Dra+VnQbo6sMUb09J33Oh8VWvjkbGFC0FFaZ5K ZPOPrKT8b9XdRZFShmc9LUHlncwuUfaTZN0w0W5qUzYwp/BkQv169/pKFbV188Dq68dy T/po6fdWQuhDr/HovQ0vBq6aGzPB+rbDqwmFl5IOzNUHei780S2gC7dRRoEQN+He8QXX 7BHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786528107; x=1787132907; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cgAavsMPfj374Y2O8g0TeLMK69exN+jOmzYmrQT4dPo=; b=gOkrQwxgjd5oKdjOfSMI6CB+wJvw4FIRLLtPvOhA9suNVzSABpJsZZX0M0DnRNMu1i KQatGTSvj4u1BIMvnn90uD/7/MZg8tIhIaPiTpHmR6vr9KKL/H69DniuE2xK8yUzmC+Z YjXSop2rHymLx22MmJAMjTA+o7gLViFUewP+KfeYzVq7up2MysgGIkQAr9h0E+tDIEkT qLN/JK+yV5hRCk5XKgGan3gxy80x02NG1iLDcM6Br2pNiE56o+Wde6BL5iK0E05o9ohe mX0LFnc4uFHkBovZBlw4yw7dauWv1O6J3mSofS3JQMY2WQd7g9Owm1yLmPNR4lgCjtm1 L9Ew== X-Forwarded-Encrypted: i=1; AHgh+RqR+dassiT4sVBAYOQi7lu2J82qLwhi+3IoaU5PpJpG9OGXhNpMHOOUnHu+TJ6A4N6hTNicfwrhbaSGJGA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8S3H5jL7yqMOIr9DVbzsYNQqN63E0LbZLQVRFtxPLHTAPC111 j3MPCJiuvYjqEBjCUBH4zV2pRh8OkAmES217IVLmXblFuPirHZh3z/6uCLZHPug5Ahs= X-Gm-Gg: AR+sD10TsUMuMadSZjwJi/FyNts6hdoZ3TavCWLTdAbYOYW7W0Oo1RKEl4d9q7Yow83 eFROmINWvl0KCyIOWDjS2+xvMZUY9ZwEOKybV9kU8AyF94OkJdgsuZfCmKi0QuhubnIDQeXiWmr CrzJSdiPEZhGqawgX4lWOQ321wBmcXemsTkytkNqTjnlVRfRTKVM3tdjmZztyclcdT+VDgjzsIq VrpZZW/6JMPbdSdCz8iVl10Oex2vndZ6I9od5AarHgoU/lq97UW2T23xEFJ4YR4hlDqfmc8tSJX YzbG4QrTL8bRwNfUueM3cDSww+ocHlbhKf0GvQrJQ1j1koS5nXigi967ryf0ru4kmcEYmB2oYML ZgYX12WQ3lN9LkGx51eshFFZZB2VDdZX2tfg1c1zqasSaHnFicdxFMNpDBbFheMMlasUn7yUrE1 Us0F0MhzqxGA98NMbZolekUiMZaVCAbuVZwkyw+PgQ/x8QyG8xwVPBOvqgSUYaMTJOojtbLx12/ vjs7pZn X-Received: by 2002:a05:600c:8b75:b0:495:4fd4:619b with SMTP id 5b1f17b1804b1-4997c0d7775mr54602815e9.1.1786528106684; Wed, 12 Aug 2026 02:48:26 -0700 (PDT) Received: from [192.168.0.252] ([79.115.63.18]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d4c10asm5835562f8f.20.2026.08.12.02.48.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2026 02:48:26 -0700 (PDT) Message-ID: <754d6dc1-1993-4fe7-ba45-31d02f7e7a0d@linaro.org> Date: Wed, 12 Aug 2026 12:48:22 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mtd: spi-nor: scope the exclusive RWW lock To: Michael Walle , Runyu Xiao Cc: pratyush@kernel.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn, stable@vger.kernel.org References: <20260809084223.3596259-1-runyu.xiao@seu.edu.cn> <6e208a8b-da11-4ba1-adfc-f1e80c891310@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/12/26 9:14 AM, Michael Walle wrote: > On Tue Aug 11, 2026 at 12:05 PM CEST, Tudor Ambarus wrote: >> >> >> On 8/10/26 11:25 AM, Michael Walle wrote: >>> Tudor, do >>> you know why you've omitted the guard() in spi_nor_rww_start_exclusive()? >> >> because using guard changes the behavior of the code. > > But that commit removed the mutex_unlock(), thus keeping the lock. oh, the horror, indeed. > That wasn't the case before the commit. IMHO the Fixes: tag is > correct. +1