From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756537AbbJUW7L (ORCPT ); Wed, 21 Oct 2015 18:59:11 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:65222 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755971AbbJUW7J (ORCPT ); Wed, 21 Oct 2015 18:59:09 -0400 From: Arnd Bergmann To: outreachy-kernel@googlegroups.com Cc: Amitoj Kaur Chawla , stefanr@s5r6.in-berlin.de, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [Outreachy kernel] [PATCH v2] firewire: Replace timeval with timespec64 Date: Thu, 22 Oct 2015 00:58:52 +0200 Message-ID: <7551827.VsyUKdOpMQ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151021223500.GA26701@amitoj-Inspiron-3542> References: <20151021223500.GA26701@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:cAFgWUcI4EcQg0QqnalbWOo5c4e6h2xwz9LHGFtWZ5Cz6dCvxZs PTnT3s0tT1B58W2w47tfsq8TiIKyKPxxHUrN+x/5ow/t/pCVVtNJfg/5tcp9XImMWh8lCcD 9JI2FT7uQcQRHZi0QMxE+Z3z2iEtoZFLisAgEAA7Wsyr2HhzV74fgAUW+Vc4lXRLib/RQf+ h6nlAq2lOnflTmHZirO0A== X-UI-Out-Filterresults: notjunk:1;V01:K0:sq4h3DWc708=:MdW7L7MTdhgzhixd7RtOGB SjSFTAsk2Renki0IphBififaVHDq308FHzSmVTpIaXLghvrIKRnfyaG7zcUcSfYweMtp1pb8q KXvCI0i7co/XbNxRkIh/0y0rzI1VBCN94l0zk7/KHAI4RbCBXPFvDSNDAbU796QkbmWh6yxR4 KY4WnH2HZGxOCZKRvENAvWdyzrKDKQZdH+brT0iweI2tmnmmqXj3rvrmkrJubzQVAk5UMLi8o GM6BcpNRP3V5IIh8OS00eB7vWjsIvWyTMzszOylvd5wJ9JONThsqtOPQPz5g3ZQCeR7hZ/UKT lUhRcpfGx+/OErKGbUXXurk/z/x+QOBSSOaP4COFq5pXcQBiQb9+jJfr2X7rGvEQ8FdPk8YHD q7GWdfrSyFFoZMcMn0jxYyGHYY9ArVOa6sUMJRE5xHcExGw1aTGKIuF4qAb3Hi1Qz7IHuVz30 A27jYpicZtRTAWrFG88IdvmTdrVBin8AArQWoB8A7+ohKwtcGIaBhv3eaFQ5ZHDH91vMyHRKF Bdh29QsCYqiZZpxSv5CmgXTgdtRMMgy/lb3pPDCpZNgnxINJV99Mt26h+Dk84wPJPsVUHyH+a HSFet6sNRY/GzPmfHt6gqbiTM1ihqBQpgb+hqI4lSgpNZMqV+uUSrEfEy9SzvEtmMGchUqjz+ VytUa4Z1nwT13FUHN8ikAWp3xkSR2/Vi/fOVvBtqXtp1Vgoy4t57EQqgdw0gmJbV8QEIsQCIl oPyYd1RCPHFG6OzO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 22 October 2015 04:05:00 Amitoj Kaur Chawla wrote: > 32 bit systems using 'struct timeval' will break in the year 2038, so > we replace the code appropriately. However, this driver is not broken > in 2038 since we are using only the microseconds portion of the > current time. > > This patch replaces timeval with timespec64. > > Signed-off-by: Amitoj Kaur Chawla Reviewed-by: Arnd Bergmann (adding the y2038 mailing list as well) > Changes in v2: > -Replaced timespec with timspec64 > -Modified commit message > -Used ktime_get_real_ts64() instead of getnstimeofday64() > > drivers/firewire/nosy.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c > index 76b2d39..8a46077 100644 > --- a/drivers/firewire/nosy.c > +++ b/drivers/firewire/nosy.c > @@ -33,6 +33,7 @@ > #include /* required for linux/wait.h */ > #include > #include > +#include > #include > #include > #include > @@ -413,17 +414,18 @@ static void > packet_irq_handler(struct pcilynx *lynx) > { > struct client *client; > - u32 tcode_mask, tcode; > + u32 tcode_mask, tcode, timestamp; > size_t length; > - struct timeval tv; > + struct timespec64 ts64; > > /* FIXME: Also report rcv_speed. */ > > length = __le32_to_cpu(lynx->rcv_pcl->pcl_status) & 0x00001fff; > tcode = __le32_to_cpu(lynx->rcv_buffer[1]) >> 4 & 0xf; > > - do_gettimeofday(&tv); > - lynx->rcv_buffer[0] = (__force __le32)tv.tv_usec; > + ktime_get_real_ts64(&ts64); > + timestamp = ts64.tv_nsec / NSEC_PER_USEC; > + lynx->rcv_buffer[0] = (__force __le32)timestamp; > > if (length == PHY_PACKET_SIZE) > tcode_mask = 1 << TCODE_PHY_PACKET; >