mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: xuanzhenggang001@208suo.com
To: ysato@users.sourceforge.jp, dalias@libc.org,
	glaubitz@physik.fu-berlin.de
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] sh: heartbeat: prefer 'unsigned int' to bare use of 'unsigned'
Date: Sun, 09 Jul 2023 20:35:06 +0800	[thread overview]
Message-ID: <7554aadc5afb915ee1065cea56053cb6@208suo.com> (raw)
In-Reply-To: <20230709123329.33674-1-denghuilong@cdjrlc.com>

Fix the following warnings reported by checkpatch:

arch/sh/drivers/heartbeat.c:33: WARNING: Prefer 'unsigned int' to bare 
use of 'unsigned'
arch/sh/drivers/heartbeat.c:62: WARNING: Prefer 'unsigned int' to bare 
use of 'unsigned'

Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com>
---
  arch/sh/drivers/heartbeat.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/sh/drivers/heartbeat.c b/arch/sh/drivers/heartbeat.c
index 24391b444b28..07f04ed0d517 100644
--- a/arch/sh/drivers/heartbeat.c
+++ b/arch/sh/drivers/heartbeat.c
@@ -30,7 +30,7 @@
  static unsigned char default_bit_pos[] = { 0, 1, 2, 3, 4, 5, 6, 7 };

  static inline void heartbeat_toggle_bit(struct heartbeat_data *hd,
-                    unsigned bit, unsigned int inverted)
+                    unsigned int bit, unsigned int inverted)
  {
      unsigned int new;

@@ -59,7 +59,7 @@ static inline void heartbeat_toggle_bit(struct 
heartbeat_data *hd,
  static void heartbeat_timer(struct timer_list *t)
  {
      struct heartbeat_data *hd = from_timer(hd, t, timer);
-    static unsigned bit = 0, up = 1;
+    static unsigned int bit = 0, up = 1;

      heartbeat_toggle_bit(hd, bit, hd->flags & HEARTBEAT_INVERTED);

       reply	other threads:[~2023-07-09 12:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230709123329.33674-1-denghuilong@cdjrlc.com>
2023-07-09 12:35 ` xuanzhenggang001 [this message]
2023-10-18 13:53   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7554aadc5afb915ee1065cea56053cb6@208suo.com \
    --to=xuanzhenggang001@208suo.com \
    --cc=dalias@libc.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®