From: Lars-Peter Clausen <lars@metafoo.de>
To: Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Michael Auchter <michael.auchter@ni.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: iio: dac: Fix AD5686 references
Date: Tue, 2 Feb 2021 22:56:21 +0100 [thread overview]
Message-ID: <755532c1-2c28-3796-367a-baec09f2dada@metafoo.de> (raw)
In-Reply-To: <20210202215503.114113-1-robh@kernel.org>
On 2/2/21 10:55 PM, Rob Herring wrote:
> The example and filename use 'adi,ad5686', but the schema doesn't
> document it. The AD5686 is also a SPI interface variant while all the
> documented variants have an I2C interface. So let's update all the
> references to AD5686 to AD5696.
>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: Michael Auchter <michael.auchter@ni.com>
> Cc: linux-iio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks Rob.
> ---
> v2:
> - Rename instead of adding AD5686
>
> .../iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
> rename Documentation/devicetree/bindings/iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} (77%)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> similarity index 77%
> rename from Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> rename to Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> index 8065228e5df8..56b0cda0f30a 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> @@ -1,16 +1,16 @@
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml#
> +$id: http://devicetree.org/schemas/iio/dac/adi,ad5696.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Analog Devices AD5686 and similar multi-channel DACs
> +title: Analog Devices AD5696 and similar multi-channel DACs
>
> maintainers:
> - Michael Auchter <michael.auchter@ni.com>
>
> description: |
> - Binding for Analog Devices AD5686 and similar multi-channel DACs
> + Binding for Analog Devices AD5696 and similar multi-channel DACs
>
> properties:
> compatible:
> @@ -48,8 +48,8 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> - ad5686: dac@0 {
> - compatible = "adi,ad5686";
> + ad5696: dac@0 {
> + compatible = "adi,ad5696";
> reg = <0>;
> vcc-supply = <&dac_vref>;
> };
next prev parent reply other threads:[~2021-02-02 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 21:55 Rob Herring
2021-02-02 21:56 ` Lars-Peter Clausen [this message]
2021-02-06 15:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=755532c1-2c28-3796-367a-baec09f2dada@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.auchter@ni.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®