From: ChenXiaoSong <chenxiaosong@chenxiaosong.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Steve French <stfrench@microsoft.com>,
Youling Tang <tangyouling@kylinos.cn>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org
Cc: Steve French <sfrench@samba.org>,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>, Bharath SM <bharathsm@microsoft.com>
Subject: Re: [PATCH v1 1/1] smb/client: Use EXPORT_SYMBOL_IF_KUNIT() to export symbols
Date: Tue, 14 Jul 2026 20:35:16 +0800 [thread overview]
Message-ID: <755b2ab6-8aee-49e4-89b0-a05589f0b64b@chenxiaosong.com> (raw)
In-Reply-To: <20260714122120.743185-1-andriy.shevchenko@linux.intel.com>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Andy, could you also submit a patch to update
fs/smb/client/smb2maperror.c as well?
在 2026/7/14 20:21, Andy Shevchenko 写道:
> Replace EXPORT_SYMBOL_FOR_MODULES() with EXPORT_SYMBOL_IF_KUNIT()
> to mark the symbols as visible only if CONFIG_KUNIT is enabled.
>
> Kunit test should import the namespace EXPORTED_FOR_KUNIT_TESTING to
> use these marked symbols. This is the standard way for all KUnit
> tests.
>
> Signed-off-by: Andy Shevchenko<andriy.shevchenko@linux.intel.com>
> ---
> fs/smb/client/smb1maperror.c | 24 ++++++++++++------------
> fs/smb/client/smb1maperror_test.c | 1 +
> 2 files changed, 13 insertions(+), 12 deletions(-)
--
ChenXiaoSong <chenxiaosong@chenxiaosong.com>
Chinese Homepage: https://chenxiaosong.com
English Homepage: https://chenxiaosong.com/en
next prev parent reply other threads:[~2026-07-14 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 12:21 Andy Shevchenko
2026-07-14 12:35 ` ChenXiaoSong [this message]
2026-07-14 13:27 ` Andy Shevchenko
2026-07-14 22:02 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=755b2ab6-8aee-49e4-89b0-a05589f0b64b@chenxiaosong.com \
--to=chenxiaosong@chenxiaosong.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bharathsm@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=stfrench@microsoft.com \
--cc=tangyouling@kylinos.cn \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®