From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754986AbcBPLCY (ORCPT ); Tue, 16 Feb 2016 06:02:24 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:54174 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbcBPLCV (ORCPT ); Tue, 16 Feb 2016 06:02:21 -0500 From: Arnd Bergmann To: Vladimir Murzin Cc: linux@arm.linux.org.uk, gregkh@linuxfoundation.org, daniel.lezcano@linaro.org, tglx@linutronix.de, u.kleine-koenig@pengutronix.de, mark.rutland@arm.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jslaby@suse.cz, robh+dt@kernel.org, andy.shevchenko@gmail.com, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-api@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Date: Tue, 16 Feb 2016 12:01:16 +0100 Message-ID: <7562697.iiO7rmWd7c@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1455617295-23736-10-git-send-email-vladimir.murzin@arm.com> References: <1455617295-23736-1-git-send-email-vladimir.murzin@arm.com> <1455617295-23736-10-git-send-email-vladimir.murzin@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:/l3iFhWCjdEmD8Av/VW0ZJ2lCYExUPZAbXkWH/XxIfUThVg0hoN Y04rhQBj+LNh3cBKvA3UYmvw1rLBFLwwjiU6sy4zPR4NTfnt7MynVyBHHSLEwI8LURGNMHJ DubJaYVWsHGRLbpzZjd/8WxeqLscFs7PPHKv2QZ793WrFFqfUvz8S24VhlOpGgoVa0weYga G//PPS/kuWX0FLSf7/mKA== X-UI-Out-Filterresults: notjunk:1;V01:K0:7SzoAx6PVvk=:Cqpt9x9Es/QpWpBVyUEm8M 1mNshDZ5GvFv9MzSO55pFs07g62b6uG2JsWOx1lkhK/lhxpxIVK8FUwh4+5utS5nlA/GqUFeD VLfn5juiKhhrYOUrtvxxf5hlwjpc9U3reMNZ4DYrbwTGG2Max1B2bDJnKF+K97wE0njkDFZCt DmBIE0+sSr1cycRoTUKl8fLBVURHQx2Vdkozxl1dkj4E8yyn+1iAel7LM/VvTZ9op+fudulGU uXGC/Mgy1vecmcFCNzVyQjvjqpEkIGy2q0c7q14l9zr829vrXGRo1tg76yImKWTNDgXM5EzCy SHlXOt9OVFXZV/p5Ob6OXDUXVV7K/50KZoSLUf9a0h5vgSSwM4OgXuJebJ+N90Q0REg1gu5kZ osadlV8uN/wH40zqjh5ljRmXQ2CWUtB9G+dehKubSWiCTfITPDwjthTryfesDPsE8pGC872nW rc7kA608N6Iu9rfizswamCP/SpBgGtrl/bCOCvW0TbGpZAyC4nQdq2gh4U/9gXBb/yrpspG2/ oES3k0++Xdqbgy7m3+ck7iYmIkE/quNEjQFL8nelUKhnlAUfu8PQhK4sDnFTclQcY0iubtywo Vq9ctwQ8oVmwyQSaN7yCQZrfx6WV4eyJ7oB0+nS+vZ1L2D/KG2P6Y97m8HdY2XDt3SJnRdJ+l P2PzoaecXRD0U7WsXHq8sJDIYDguyOzCZzWshiSgJ0F2qOGL9aqkebaaQQerL9FZ2oKHI6LWp k6vx5RfjY66kJh9x Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 16 February 2016 10:08:14 Vladimir Murzin wrote: > + > + ethernet@40200000 { > + compatible = "smsc,lan9220", "smsc,lan9115"; > + reg = <0x40200000 0x10000>; > + interrupts = <13>; > + interrupt-parent = <&nvic>; > + smsc,irq-active-high; > + }; > +}; > + > This node seems slightly misplaced. Is there some external bus interface that this is connected to? The address suggests that it should be somewhere below the /soc node, and you probably want to list the external bus interface with a "ranges" property that identifies the addresses visibile there, and put the external chip under there. Arnd