From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
Vinod Koul <vkoul@kernel.org>,
Nikita Shubin <nikita.shubin@maquefel.me>,
Arnd Bergmann <arnd@arndb.de>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
error27@gmail.com
Subject: Re: [PATCH] dmaengine: ep93xx: Fix NULL vs IS_ERR() check in ep93xx_dma_probe()
Date: Mon, 16 Sep 2024 20:32:23 +0200 [thread overview]
Message-ID: <75639e2d585a2d45e015e80044c0f88a3f5ec3b1.camel@gmail.com> (raw)
In-Reply-To: <20240916182337.1986380-1-harshit.m.mogalapalli@oracle.com>
Hi Harshit,
thanks for looking into this!
On Mon, 2024-09-16 at 11:23 -0700, Harshit Mogalapalli wrote:
> ep93xx_dma_of_probe() returns error pointers on error. Change the NULL
> check to IS_ERR() check instead.
>
> Fixes: 5313a72f7e11 ("dmaengine: cirrus: Convert to DT for Cirrus EP93xx")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Dan has already fixed this though:
https://lore.kernel.org/lkml/459a965f-f49c-45b1-8362-5ac27b56f5ff@stanley.mountain/
> ---
> This is based on static analysis with Smatch
> ---
> drivers/dma/ep93xx_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index d084bd123c1c..ca86b2b5a913 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -1504,7 +1504,7 @@ static int ep93xx_dma_probe(struct platform_device *pdev)
> int ret;
>
> edma = ep93xx_dma_of_probe(pdev);
> - if (!edma)
> + if (IS_ERR(edma))
> return PTR_ERR(edma);
>
> dma_dev = &edma->dma_dev;
--
Alexander Sverdlin.
next prev parent reply other threads:[~2024-09-16 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 18:23 Harshit Mogalapalli
2024-09-16 18:32 ` Alexander Sverdlin [this message]
2024-09-16 18:34 ` Harshit Mogalapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75639e2d585a2d45e015e80044c0f88a3f5ec3b1.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®