From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C738FC43334 for ; Mon, 4 Jul 2022 19:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234290AbiGDTFm convert rfc822-to-8bit (ORCPT ); Mon, 4 Jul 2022 15:05:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbiGDTFj (ORCPT ); Mon, 4 Jul 2022 15:05:39 -0400 Received: from relay3.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C62B294 for ; Mon, 4 Jul 2022 12:05:37 -0700 (PDT) Received: from omf08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4DFE460511; Mon, 4 Jul 2022 19:05:36 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA id 16C822002A; Mon, 4 Jul 2022 19:05:33 +0000 (UTC) Message-ID: <757323ceeb72b2d80acfae9ae4f384c27d731bbe.camel@perches.com> Subject: Re: [PATCH 1/6] staging: vt6655: Rename pbyEtherAddr to mac_addr From: Joe Perches To: Philipp Hortmann , Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Mon, 04 Jul 2022 12:05:33 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.1-0ubuntu1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 16C822002A X-Stat-Signature: 3boejniya1uhjmngqa3he4fw6y8gbd94 X-Rspamd-Server: rspamout06 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18zAhJLb0W9bs/hqwmb/aR/H/Tx+6NjtOg= X-HE-Tag: 1656961533-813176 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-07-04 at 20:20 +0200, Philipp Hortmann wrote: > Fix name of a variable in two macros that use CamelCase which is not > accepted by checkpatch.pl These might be nicer as functions with for loops > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h maybe something like: static inline void MACvWriteBSSIDAddress(void __iomem *iobase, u8 *addr) { int i; for (i = 0; i < ETH_ALEN; i++) iowrite8(*addr++, iobase + MAC_REG_BSSID0 + i); } static inline void MACvReadEtherAddress(void __iomem *iobase, u8 *addr) { int i; iowrite8(1, iobase + MAC_REG_PAGE1SEL); for (i = 0; i < ETH_ALEN; i++) *addr++ = ioread8(iobase + MAC_REG_PAR0 + i); iowrite8(0, iobase + MAC_REG_PAGE1SEL); }