Re: 2.6.21-mm2 - Kconfig horkage

[Valdis.Kletnieks@vt.edu]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On Wed, 09 May 2007 10:07:56 PDT, Christoph Lameter said:
> On Wed, 9 May 2007, Valdis.Kletnieks@vt.edu wrote:
> > 1) Spotted in init/Kconfig:
> > 
> > config SLUB_DEBUG
> >         default y
> >         bool "Enable SLUB debugging support" if EMBEDDED
> >         help
> > 
> > Shouldn't that have an 'default SLUB' or 'if SLUB' or something attached to it?
> 
> Maybe. Is there a problem with SLUB_DEBUG being set if SLUB is not 
> selected?

% egrep 'SL[AU]B' /usr/src/linux-2.6.21-mm2/.config
# CONFIG_SLUB_DEBUG is not set
CONFIG_SLAB=y
# CONFIG_SLUB is not set
# CONFIG_DEBUG_SLAB is not set

Just seemed odd to do a 'make oldconfig' and get prompted for the value, and it
gave a value of 'Y' to a debug  option of a feature that wasn't selected.  :)

It took me a while to convince myself that somebody hadn't changed the default
to CONFIG_SLUB while I wasn't looking....

(Maybe the order of entries needs fixing - SLAB, SLAB_DEBUG, SLUB, SLUB_DEBUG,
so that oldconfig and friends don't pop the question for debugging till *after*
they ask if the feature should be included?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]