From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.Li@nxp.com>,
vkoul@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
peng.fan@nxp.com, joy.zou@nxp.com, shenwei.wang@nxp.com,
imx@lists.linux.dev
Subject: Re: [PATCH v4 12/12] dt-bindings: fsl-dma: fsl-edma: add edma3 compatible string
Date: Tue, 13 Jun 2023 13:19:24 +0200 [thread overview]
Message-ID: <7574a6fe-ddf1-1500-ba04-5a1df6845b6a@linaro.org> (raw)
In-Reply-To: <20230612203418.2017769-13-Frank.Li@nxp.com>
On 12/06/2023 22:34, Frank Li wrote:
> Extend Freescale eDMA driver bindings to support eDMA3 IP blocks in
> i.MX8QM and i.MX8QXP SoCs. In i.MX93, both eDMA3 and eDMA4 are now.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../devicetree/bindings/dma/fsl,edma.yaml | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index 5fd8fc604261..14cea8a3f442 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -21,6 +21,10 @@ properties:
> - enum:
> - fsl,vf610-edma
> - fsl,imx7ulp-edma
> + - fsl,imx8qm-edma
> + - fsl,imx8qm-adma
> + - fsl,imx93-edma3
> + - fsl,imx93-edma4
> - items:
> - const: fsl,ls1028a-edma
> - const: fsl,vf610-edma
> @@ -101,6 +105,26 @@ allOf:
> reg:
> maxItems: 2
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + anyOf:
This is just enum.
> + - const: fsl,imx8qm-edma
> + - const: fsl,imx8qm-adma
Keep entries ordered alphabetically. In compatible list as well.
> + - const: fsl,imx93-edma3
> + - const: fsl,imx93-edma4
> + then:
> + properties:
> + reg:
> + maxItems: 1
> + interrupts:
> + minItems: 1
> + maxItems: 64
> + interrupt-names:
> + minItems: 1
> + maxItems: 64
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
interrupts can be max 17, so just test it and you will see errors.
Why names are not listed? If you accept names like "candy" or
"elephant", then why having the names in the first place?
And what about clocks?
Best regards,
Krzysztof
prev parent reply other threads:[~2023-06-13 11:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 20:34 [PATCH v4 00/12] dmaengine: edma: add freescale edma v3 support Frank Li
2023-06-12 20:34 ` [PATCH v4 01/12] dmaengine: fsl-edma: clean up EXPORT_SYMBOL_GPL in fsl-edma-common.c Frank Li
2023-06-12 20:34 ` [PATCH v4 02/12] dmaengine: fsl-edma: clean up fsl_edma_irq_exit() Frank Li
2023-06-12 20:34 ` [PATCH v4 03/12] dmaengine: fsl-edma: transition from bool fields to bitmask flags in drvdata Frank Li
2023-06-12 20:34 ` [PATCH v4 04/12] dmaengine: fsl-edma: Remove enum edma_version Frank Li
2023-06-12 20:34 ` [PATCH v4 05/12] dmaengine: fsl-edma: move common IRQ handler to common.c Frank Li
2023-06-12 20:34 ` [PATCH v4 06/12] dmaengine: fsl-edma: simply ATTR_DSIZE and ATTR_SSIZE by using ffs() Frank Li
2023-06-12 20:34 ` [PATCH v4 07/12] dmaengine: fsl-edma: refactor using devm_clk_get_enabled Frank Li
2023-06-12 20:34 ` [PATCH v4 08/12] dmaengine: fsl-edma: move clearing of register interrupt into setup_irq function Frank Li
2023-06-12 20:34 ` [PATCH v4 09/12] dmaengine: fsl-edma: refactor chan_name setup and safety Frank Li
2023-06-12 20:34 ` [PATCH v4 10/12] dmaengine: fsl-edma: move tcd into struct fsl_dma_chan Frank Li
2023-06-12 20:34 ` [PATCH v4 11/12] dmaengine: fsl-edma: integrate v3 support Frank Li
2023-06-12 20:34 ` [PATCH v4 12/12] dt-bindings: fsl-dma: fsl-edma: add edma3 compatible string Frank Li
2023-06-13 11:19 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7574a6fe-ddf1-1500-ba04-5a1df6845b6a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Frank.Li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®