mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolai Buchwitz <nb@tipi-net.de>
To: Vadluri Mukunda <vmukunda@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sunil Goutham <sgoutham@marvell.com>,
	Ratheesh Kannoth <rkannoth@marvell.com>,
	Geetha sowjanya <gakula@marvell.com>,
	Subbaraya Sundeep <sbhatta@marvell.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Suman Ghosh <sumang@marvell.com>
Subject: Re: [PATCH net v2] octeontx2-af: skip NPC_AF_MATCH_STATX access on cn20k
Date: Fri, 06 Nov 2026 15:02:00 +0100	[thread overview]
Message-ID: <7582ad3c94a6412f8c570ddef4cfb3a1@tipi-net.de> (raw)
In-Reply-To: <20261103091831.914393-1-vmukunda@marvell.com>

Hi Vadluri

On 3.11.2026 10:18, Vadluri Mukunda wrote:
> From: Subbaraya Sundeep <sbhatta@marvell.com>
> 
> NPC_AF_MATCH_STATX is not present on cn20k silicon, and cn20k does
> not set up an RX miss action counter. Two paths still access it:
> the npc_delete_flow mailbox, which reads the counter of the deleted
> rule, and the rx_miss_act_stats debugfs file, which would read
> counter 0. Avoid the access on cn20k. Counter support for cn20k is
> left for later.
> 
> Found by code inspection. The issue was not triggered on hardware.
> Compile tested only; not tested on real hardware.

What does the read do on cn20k, fault or just return garbage? If it
is only the latter, with the recent discussion about routing
non-critical fixes through net-next, this looks like net-next
material to me?

> 
> Fixes: 4e527f1e5c15 ("octeontx2-af: npc: cn20k: Add new mailboxes for 
> CN20K silicon")
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> Signed-off-by: Vadluri Mukunda <vmukunda@marvell.com>
> ---

> [...]

Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>

Thanks,
Nicolai

      parent reply	other threads:[~2026-11-06 14:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  9:18 Vadluri Mukunda
2026-11-06 12:09 ` Simon Horman
2026-11-06 14:02 ` Nicolai Buchwitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7582ad3c94a6412f8c570ddef4cfb3a1@tipi-net.de \
    --to=nb@tipi-net.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=gakula@marvell.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rkannoth@marvell.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    --cc=sumang@marvell.com \
    --cc=vmukunda@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®