From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C55D3B14BF for ; Wed, 1 Jul 2026 11:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782904332; cv=none; b=Iwz2krEnKaTPHtd4QtSvnnh73SJlIMnp7HOSoFRT08liH7SZCKreZ/U3+b+2SRnlWQ0KPtoXz1Y9jcfYFYERS88722FyEdTDGi86tcSIxaWaGBJM8UdsMm0xAtuVg6bc0UY7bJG52LfK4/t/WBViei9XYLxURMOyt1RK3LWo9m8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782904332; c=relaxed/simple; bh=sHKyxBAXP+64IaiR9M93nhNYksJ/qP+JBSbX6tLP3sI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W3/zCOwQxBUeJ5iDteObnD7W3AztQQ7KK2Lcjy4PWviut/sElgdukw5GW5yyRB4/BIVReiA8vp3Kw+t8D/htwZgPf+NHjSukxFntTQxE6gdXzvJ/RW7iwGROsgOFeLsaC9v1E9Qexv7pXOQeg4P2f1H8TTYBYkvcHDp3NAKfUzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bF1dlqWy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UMC4zDx3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bF1dlqWy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UMC4zDx3" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 661A8Wl3761663 for ; Wed, 1 Jul 2026 11:12:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VX0pngcjZ1Ha/IfFO5ZSf47UTey90yV9N2eI2uJkFb8=; b=bF1dlqWyy7jetzrs lApLdtyT1LjJnNRxOXwdRjZpol1XeO4NzKWuRaPsX1XQ1MqAnC2V1+pg/jZ6mw1B WJ4ZMNyLzYfbEkzgXKXn/SIHbIC0I7MjN/Cd1+3lPut2e4ojPEhgI+CH1u4Zww0t aUntANuozYhY9xqfj5DSc7dFOdB99e+52WnoFhMEKeL2gsw4O4Wuit1tsADC9Qjd ufPTWMO0n6cse++z9yqef3vGY8vIBbxfCmR7xgmWtVVBXKeHcJASQNmn4iVtPImo Q34IjSAINE2b8ExJ3ous5JgC7y5U1ANCydSVGgaIU9Zfv7TMf7BpSNkAXDfW/czw kz9jBA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4kgw3qte-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 11:12:10 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8e8e83314abso1867586d6.3 for ; Wed, 01 Jul 2026 04:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782904329; x=1783509129; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VX0pngcjZ1Ha/IfFO5ZSf47UTey90yV9N2eI2uJkFb8=; b=UMC4zDx3TjMPMaxqsPMkLbiK9Hp1qQ46M6C3h5Nf9Pe1tG1vtPITM2mHdSccHLgZ7K TgEEu1MMTVHy/d1fYi4TDF8C/PBGT4TztEQm7OBf2qjk5MQqP4y5tzj+fKTwH2eUO3K1 GtjrV1EcvVn4FFVKYzC2mgJET+5/sWtds8O2wiyhiPNnbGQRA+MDhhoofiKvhQOY3CoO hd5h9KxFWAWUohXRMbHqROTP7MW37iLJ6GbLEDpeqXva6C2+Z+PQAk+s5EREr0WnIUi3 MN8A6vAPgFCX7ieRwEQvB8T8LyxxczEk1ZmZ0lgZMXSGgqVtl2ImyOSs+/bsrRYMitSb EZVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782904329; x=1783509129; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VX0pngcjZ1Ha/IfFO5ZSf47UTey90yV9N2eI2uJkFb8=; b=jwH4bSpaydGrRwaZcG+77tK4cU+elddiJqdOnwU/J0Qcc3l3I5JqrOqg0nkJb2fx2p /HiDBQDF14Z9Id3qgQXrbrT+8Czj6orZINSqXRd0Fs82pcZXeSDCx+eOg8uyht/Igmlz RXQ6cu6WCIwhP2nUV1h5+52mGopAMrqrzpAJy2bWn/T5ZKPqm7eqGYUStSadJ4mcrPgc z7a1IAH4ZKEs7BJnp5L6lan5LZLAEFfOpj3B/uqZexdit2G5SouKpo7SUPV2VFgfpIb7 H4oYLDdC5SQsOMToG/WrUXzNA4HAJhmvdL3GFhsPsMBg3ab5aVmksZnvYRVIdndz7WGM 8Bjg== X-Forwarded-Encrypted: i=1; AFNElJ/8kGR7tQjyTF227VW0M+Iw1h0w1U9HVjF9FUBtbNiDMyEi9TjgwPQCDp9+OVehGJGy824Du92g/V5FG5Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwbtSa42Oi7aTSo3mxmwMwfSDZhk/PHuTRmJyzSuXNXqnUFE7tF YFzx10qk2sRWqZONq6+ynOWzjTrOCnIBlaeIkKiYRwr2kr8vlxrf5fHaTu3eHUAiuDKouziEzOa yB/OQ3CPCtZ3aNYS6TqFm4pGxuEKD0Sy1i+uAuUpW/OAqUOy4wAZjo+3DkxyO1WOeHM8= X-Gm-Gg: AfdE7ckJqRyw6PLiiSYY3W5PPkY2+VKpKFO0rd8N1Ulel3RXBp+MMqihXQrRdCOIaej rh3YnnLqT79GF5zrv60HDr8RCn1jnXIOyncIUFSyybzmJk3guVezlew3npkQx6EIcsk1XSHBb05 9KsWTo4HRlwl/efrf7OH+OJqagTGrgjcVihVLsUquSPRqE0KjX/6Y7ZBVAH9IOZ93PpbYTopyAr haA/BUJBXRE3Clq2xHAfVXCExu3rwvtZl5livmgEBw2cTkup58uClNIXcDFSbwi/KwF4gL/DvuN 9egu/hkposNF87qiNtetoMjaLcV7stM6w4ssjhqEXA0F2//8zcLvQL7HeDIt1QQc/byafEZsTqV NFjYIWcOZ2x1GLJlhL6la+GWLcme3XqxtBmg= X-Received: by 2002:a05:620a:4143:b0:92e:519a:7c06 with SMTP id af79cd13be357-92e785379femr93364685a.8.1782904329409; Wed, 01 Jul 2026 04:12:09 -0700 (PDT) X-Received: by 2002:a05:620a:4143:b0:92e:519a:7c06 with SMTP id af79cd13be357-92e785379femr93359885a.8.1782904328767; Wed, 01 Jul 2026 04:12:08 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12891785f2sm257626966b.61.2026.07.01.04.12.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 04:12:08 -0700 (PDT) Message-ID: <75858d5f-edb9-40a8-a4c7-a40cec09b6a7@oss.qualcomm.com> Date: Wed, 1 Jul 2026 13:12:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] soc: qcom: geni-se: Use HW PROG_RAM_DEPTH to validate firmware size To: Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Mukesh Kumar Savaliya Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260701-qup-se-increase-ram-cnt-v2-1-0618a19f26c3@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260701-qup-se-increase-ram-cnt-v2-1-0618a19f26c3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Co2PtH4D c=1 sm=1 tr=0 ts=6a44f60a cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Q7hu8fOgrWGrelQ5SqEA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-ORIG-GUID: Dl-XIH8Z1wILdy-3GRSd8bkka6Jb_ko_ X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDExNyBTYWx0ZWRfX9W5RRLWTADc8 PzIrlzw9O7Bu5UI7PsT3EIyvj3CCaD0X1G4VIBASWLzG//KCeP24LTnJVTPb4eij6AdkPsuX4tR Po6eQ1NykL48fk2gvx9ovytpKgnAdr4= X-Proofpoint-GUID: Dl-XIH8Z1wILdy-3GRSd8bkka6Jb_ko_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDExNyBTYWx0ZWRfXyUfXEH6lleQT jUWIgDsidsrlBVe3vlQw7T/vWHYneKHjr7NNANbpUo3o+pdFAS5aqABhdxAjkcTvKfHVR5Jc10n VhQwOy3tHRSV6tP6pxy6M+gF3A84aflcp7FgIKlenzACiPZ4OTgdtj2Sx/t51y0pvT9hm66faWb hsgGam7w/KkRG52htqdN9uvk5qGIQwKnWX/EEFrpAm5jVeKTPZBtHC1Svsv/PalWSQXjefmMhdP y+/CqFz7wTINRMbEOa2R5IsFk69J4f1l9A+Nrd7T9Egkt0Ij0VdRuk7CZfza0jjB3qyfY6jJ0vZ Zyy9JwZTWSssRAbaBi44CITAWPQ6M/4QZT809OPv/onpwDsX7mr8IUI3+RBCnkhuo214NLEiLmk yRD9+DWOwwW3RGyrgXBhSqBMG4VZAGBZ3Qjn3PjZsqXsCJqTyOVHHheBl9ZIBdb2BrkmfC5/v9d ASp3uXjUnxe0aVbfI7A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010117 On 7/1/26 6:21 AM, Viken Dadhaniya wrote: > The hardcoded MAX_GENI_CFG_RAMn_CNT limit is not accurate for all SoCs: > some targets have less CFG RAM than the constant implies, while others > like QCS615 need more entries than the old limit of 455 allowed, causing > valid firmware to be rejected at load time. > > Rather than hardcoding a constant, read PROG_RAM_DEPTH from SE_HW_PARAM_2 > at runtime to get the actual CFG RAM depth of the hardware instance and > use that as the upper bound for firmware size validation. > > Fixes: d4bf06592ad6 ("soc: qcom: geni-se: Add support to load QUP SE Firmware via Linux subsystem") > Cc: stable@vger.kernel.org > Signed-off-by: Viken Dadhaniya > --- [...] > dev_err(dev, > - "Firmware size (%u) exceeds max allowed RAMn count (%u)\n", > - fw_size, MAX_GENI_CFG_RAMn_CNT); > + "Firmware size (%u) exceeds HW PROG_RAM_DEPTH (%u)\n", I would just say 'exceeds RAM size (%u)' otherwise Reviewed-by: Konrad Dybcio Konrad