From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8741DC433F5 for ; Thu, 10 Feb 2022 16:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244450AbiBJQkR (ORCPT ); Thu, 10 Feb 2022 11:40:17 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:51314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbiBJQkP (ORCPT ); Thu, 10 Feb 2022 11:40:15 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 87FFBC24 for ; Thu, 10 Feb 2022 08:40:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644511215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nigEQRbvPayjvXW0XlHeZl0iZUMoL4B76AS5wQcOkCU=; b=AC53FpwGN9DWO2HdGXwmnQzLpdDYJdUhdiD75IWktoZH2C2ymgffygmX2CGDRSplrhP9Mf YpVmb9q/bbYflDMjOV2jhKTLP+DSc5JLXgrbZABjR9ZNUU0u6b4QCMY+k3uhBxvhlGP5eT bvdaA7cPV1E0W0z5gvkhlBi+RDxYLnQ= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-145--AySVuFCM_yDcuCphuU-Rw-1; Thu, 10 Feb 2022 11:40:14 -0500 X-MC-Unique: -AySVuFCM_yDcuCphuU-Rw-1 Received: by mail-ed1-f70.google.com with SMTP id cr7-20020a056402222700b0040f59dae606so3658489edb.11 for ; Thu, 10 Feb 2022 08:40:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nigEQRbvPayjvXW0XlHeZl0iZUMoL4B76AS5wQcOkCU=; b=huBDyOctMwf3SwIs8poDy4uR2Eq3adZjXhaDWeWv9KeSjspH8UaQj9knZNOiN2DH84 h/TFpvHLJ+P+SqKClmfqxzGgwXsId8WAxD2mMfIntGfinvaFHhYi3beDWE1mBs52V7ne wAVb6kyVpjcBcFhkCwWYdA11EBe8Y/egwO3HdzzrvtHcAbbeXzDeOd2pVTm+dp1yEojz U2METJ1711KQlxGdLFzBKEG4vjMTdZ2G6MY43SsIizQg0wN0Ar9Qb1TEBXMG3V5/3A/K f6gjnFMpbuXj1UOdgaQ7jUOZ+qsfyIskpo+b7ZZO4+KZsPGLVNs5GqtM18zzhzlYQBn3 RPqQ== X-Gm-Message-State: AOAM531Sx3gKUvRH3FEsBaTUH/4G+QeGsOy9vXwWyt7foumsrZN/PgTn tXxl+I13b2mWkM8BTeML/tPGwrs+F0rxO39lfGrUzOWaet5ZbcdghSmrW+1rQ/PQhqbODla6vS2 0zZDmfNO9F56F087vQo/5iGWr X-Received: by 2002:a17:907:2d8b:: with SMTP id gt11mr7139415ejc.569.1644511212967; Thu, 10 Feb 2022 08:40:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJxQZvjS9s8eet7LG+6PKKUUfksHgZbeDe2kZG8ReoUuVkfOdo/bc9hM5bkSQ3rawe8Em+Icdg== X-Received: by 2002:a17:907:2d8b:: with SMTP id gt11mr7139394ejc.569.1644511212725; Thu, 10 Feb 2022 08:40:12 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id b7sm5051849ejv.71.2022.02.10.08.40.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 08:40:12 -0800 (PST) Message-ID: <75878676-53d4-62a3-9b22-deeedbaa24b8@redhat.com> Date: Thu, 10 Feb 2022 17:40:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH MANUALSEL 5.15 2/8] KVM: nVMX: eVMCS: Filter out VM_EXIT_SAVE_VMX_PREEMPTION_TIMER Content-Language: en-US To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vitaly Kuznetsov , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, kvm@vger.kernel.org References: <20220209185653.48833-1-sashal@kernel.org> <20220209185653.48833-2-sashal@kernel.org> From: Paolo Bonzini In-Reply-To: <20220209185653.48833-2-sashal@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/9/22 19:56, Sasha Levin wrote: > From: Vitaly Kuznetsov > > [ Upstream commit 7a601e2cf61558dfd534a9ecaad09f5853ad8204 ] Acked-by: Paolo Bonzini Paolo > Enlightened VMCS v1 doesn't have VMX_PREEMPTION_TIMER_VALUE field, > PIN_BASED_VMX_PREEMPTION_TIMER is also filtered out already so it makes > sense to filter out VM_EXIT_SAVE_VMX_PREEMPTION_TIMER too. > > Note, none of the currently existing Windows/Hyper-V versions are known > to enable 'save VMX-preemption timer value' when eVMCS is in use, the > change is aimed at making the filtering future proof. > > Signed-off-by: Vitaly Kuznetsov > Message-Id: <20220112170134.1904308-3-vkuznets@redhat.com> > Signed-off-by: Paolo Bonzini > Signed-off-by: Sasha Levin > --- > arch/x86/kvm/vmx/evmcs.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx/evmcs.h b/arch/x86/kvm/vmx/evmcs.h > index 152ab0aa82cf6..b43976e4b9636 100644 > --- a/arch/x86/kvm/vmx/evmcs.h > +++ b/arch/x86/kvm/vmx/evmcs.h > @@ -59,7 +59,9 @@ DECLARE_STATIC_KEY_FALSE(enable_evmcs); > SECONDARY_EXEC_SHADOW_VMCS | \ > SECONDARY_EXEC_TSC_SCALING | \ > SECONDARY_EXEC_PAUSE_LOOP_EXITING) > -#define EVMCS1_UNSUPPORTED_VMEXIT_CTRL (VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL) > +#define EVMCS1_UNSUPPORTED_VMEXIT_CTRL \ > + (VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL | \ > + VM_EXIT_SAVE_VMX_PREEMPTION_TIMER) > #define EVMCS1_UNSUPPORTED_VMENTRY_CTRL (VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL) > #define EVMCS1_UNSUPPORTED_VMFUNC (VMX_VMFUNC_EPTP_SWITCHING) >