From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xi Ruoyao <xry111@xry111.site>,
Dave Hansen <dave.hansen@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Michael Kelley <mhklinux@outlook.com>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH v6] x86/mm: Don't disable INVLPG if "incomplete Global INVLPG flushes" is fixed by microcode or the kernel is running in a hypervisor
Date: Thu, 11 Apr 2024 16:00:06 +0100 [thread overview]
Message-ID: <7590c66d-96dd-4182-b99b-9a618a2a8f1c@citrix.com> (raw)
In-Reply-To: <1f5d53596e2ac8948332570e3bda17c3877fd499.camel@xry111.site>
On 11/04/2024 3:48 pm, Xi Ruoyao wrote:
> On Thu, 2024-04-11 at 07:44 -0700, Dave Hansen wrote:
>> I agree that it sounds weird. It _is_ weird that systems running under
>> hypervisors aren't affected. But that's all it is: a weird bug. The
>> documentation is correct.
> Yes, these hardware issues are just weird to me...
>
I have no inside knowledge here, but this isn't surprising to me.
VPID tags are unique to VMX operation. At a guess, VMXON reconfigures
the tagging in the TLB to include VPID (and EPTP tags for that matter),
and works around the buggy selection for which PCIDs to drop.
~Andrew
next prev parent reply other threads:[~2024-04-11 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 10:48 Xi Ruoyao
2024-04-11 14:29 ` Sean Christopherson
2024-04-11 14:44 ` Dave Hansen
2024-04-11 14:48 ` Xi Ruoyao
2024-04-11 15:00 ` Andrew Cooper [this message]
2024-04-11 15:18 ` Dave Hansen
2024-04-11 15:43 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7590c66d-96dd-4182-b99b-9a618a2a8f1c@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhklinux@outlook.com \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®