From: Marcos Del Sol Vives <marcos@orca.pet>
To: Lee Jones <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Michael Walle <mwalle@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v4 3/3] mfd: vortex: implement new driver for Vortex southbridges
Date: Thu, 4 Sep 2025 14:21:11 +0200 [thread overview]
Message-ID: <75920526-64f4-4eda-8552-58de165f6597@orca.pet> (raw)
In-Reply-To: <20250904101705.GH2764654@google.com>
El 04/09/2025 a las 12:17, Lee Jones escribió:
>> That GPIO is something required to perform the poweroff sequence, a must
>> for any machine, while WDT is just a "nice to have".
>>
>> Implementing now the WDT just because of a linguistic preference means
>> delaying something more important in favour of a "nice to have".
>
> You use the word "delaying" here. What's the rush?
>
> If you only need a GPIO driver, then you don't need the MFD part.
>
I would honestly like that my machines can turn off properly and pretty
sure others using these platforms would agree on that, as having to yank
out the power cable is far from ideal.
Adding WDT would lengthen even further the review process. That ignoring
I am doing this as a hobby on my spare time and I'd rather spend my
scarce free time implementing the power off driver than the WDT
(something I'd do out of completion, I have absolutely no use for a WDT
in this machine).
The reason I am using an MFD is that I was asked to back in v2
(https://lore.kernel.org/all/aHElavFTptu0q4Kj@smile.fi.intel.com/).
I'll be CC'ing him.
I was told to create a southbridge driver that would match on PCI
and registered other devices exposed by it as platform drivers.
GPIO was the only functionality implemented at the time, and is
the only functionality implemented right now. So I simply delivered was
I was asked for.
next prev parent reply other threads:[~2025-09-04 12:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 13:58 [PATCH v4 0/3] Introduce support for Vortex GPIO pins Marcos Del Sol Vives
2025-08-22 13:58 ` [PATCH v4 1/3] gpio: gpio-regmap: add flag to set direction before value Marcos Del Sol Vives
2025-08-22 13:58 ` [PATCH v4 2/3] gpio: vortex: add new GPIO device driver Marcos Del Sol Vives
2025-08-24 7:42 ` William Breathitt Gray
2025-08-22 13:58 ` [PATCH v4 3/3] mfd: vortex: implement new driver for Vortex southbridges Marcos Del Sol Vives
2025-09-02 15:18 ` Lee Jones
2025-09-02 18:06 ` Marcos Del Sol Vives
2025-09-03 7:21 ` Lee Jones
2025-09-03 7:43 ` Marcos Del Sol Vives
2025-09-03 9:14 ` Lee Jones
2025-09-03 13:01 ` Marcos Del Sol Vives
2025-09-03 14:01 ` Lee Jones
2025-09-03 14:48 ` Marcos Del Sol Vives
2025-09-04 10:17 ` Lee Jones
2025-09-04 12:21 ` Marcos Del Sol Vives [this message]
2025-09-08 14:24 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75920526-64f4-4eda-8552-58de165f6597@orca.pet \
--to=marcos@orca.pet \
--cc=andriy.shevchenko@intel.com \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mwalle@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®