From: Mark Brown <broonie@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Sean Young" <sean@mess.org>, "Jean Delvare" <jdelvare@suse.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Helge Deller" <deller@gmx.de>,
linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Support Opensource" <support.opensource@diasemi.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mark Gross" <markgross@kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Jani Nikula" <jani.nikula@intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-hwmon@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v8 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()
Date: Tue, 12 Dec 2023 15:27:35 +0000 [thread overview]
Message-ID: <7594ea09-a6f3-4dac-acb3-d5f899f9cf84@sirena.org.uk> (raw)
In-Reply-To: <f7be8d89-25ae-4d83-9577-12fcac41d0ab@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]
On Tue, Dec 12, 2023 at 07:22:18AM -0800, Guenter Roeck wrote:
> On 12/12/23 03:41, Uwe Kleine-König wrote:
> > Several affected maintainers already acked, so I guess it's fine to take
> > this via the pwm tree. An Ack from the remaining maintainers would be
> > very welcome, an alternative would be to split the patch.
> > Missing Acks so far:
> > - Jean Delvare / Guenter Roeck for drivers/hwmon/pwm-fan.c
> > - Javier Martinez Canillas for drivers/gpu/drm/solomon/ssd130x.c
> > - Liam Girdwood / Mark Brown for drivers/regulator/pwm-regulator.c
> > - Helge Deller for drivers/video/fbdev/ssd1307fb.c
> Personally I find the change unnecessary and pointless, which is why I
> didn't ack it. Even if function names were deemed important enough, keeping
> pwm_apply_state() for the time being and just adding pwm_apply_might_sleep()
> as duplicate would have done it, all the changes could have gone in long
> ago, and per-subsystem cleanup could have been orthogonal.
> I refrained from commenting because it might be considered bike shedding,
> but I don't want to ack something I deem unnecessary and pointless without
> comment. But then don't want to keep arguing either, so
I haven't been reading this series because I couldn't tell why I was
copied on it, it's only chance that made me open Guenter's mail here...
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-12-12 15:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1702369869.git.sean@mess.org>
2023-12-12 8:34 ` Sean Young
2023-12-12 11:41 ` Uwe Kleine-König
2023-12-12 15:22 ` Guenter Roeck
2023-12-12 15:27 ` Mark Brown [this message]
2023-12-12 8:34 ` [PATCH v8 2/6] pwm: Replace ENOTSUPP with EOPNOTSUPP Sean Young
2023-12-12 11:31 ` Uwe Kleine-König
2023-12-12 8:34 ` [PATCH v8 3/6] pwm: renesas: Remove unused include Sean Young
2023-12-12 11:28 ` Uwe Kleine-König
2023-12-12 8:34 ` [PATCH v8 4/6] pwm: Make it possible to apply PWM changes in atomic context Sean Young
2023-12-12 11:48 ` Uwe Kleine-König
2023-12-18 9:03 ` Sean Young
2023-12-12 8:34 ` [PATCH v8 5/6] pwm: bcm2835: Allow PWM driver to be used " Sean Young
2023-12-12 11:50 ` Uwe Kleine-König
2023-12-12 16:08 ` Uwe Kleine-König
2023-12-12 16:11 ` Florian Fainelli
2023-12-12 18:14 ` Uwe Kleine-König
2023-12-18 9:02 ` Sean Young
2023-12-18 9:02 ` Sean Young
2023-12-12 8:34 ` [PATCH v8 6/6] media: pwm-ir-tx: Trigger edges from hrtimer interrupt context Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7594ea09-a6f3-4dac-acb3-d5f899f9cf84@sirena.org.uk \
--to=broonie@kernel.org \
--cc=airlied@gmail.com \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jani.nikula@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jdelvare@suse.com \
--cc=jingoohan1@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maarten.lankhorst@linux.intel.com \
--cc=markgross@kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=sean@mess.org \
--cc=support.opensource@diasemi.com \
--cc=thierry.reding@gmail.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®