From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B209C433DB for ; Mon, 4 Jan 2021 08:36:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29BCA20784 for ; Mon, 4 Jan 2021 08:36:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726330AbhADIgD (ORCPT ); Mon, 4 Jan 2021 03:36:03 -0500 Received: from ptr.189.cn ([183.61.185.102]:12617 "EHLO 189.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725616AbhADIgD (ORCPT ); Mon, 4 Jan 2021 03:36:03 -0500 HMM_SOURCE_IP: 172.27.8.53:49401.1510557771 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-123.150.8.42 (unknown [172.27.8.53]) by 189.cn (HERMES) with SMTP id 67190100896; Mon, 4 Jan 2021 16:32:47 +0800 (CST) Received: from ([123.150.8.42]) by SZ-WEBMAIL05 with ESMTP id 25eea934587e4f18bbd903edeb6bea94 for linux-next@vger.kernel.org; Mon Jan 4 16:32:48 2021 X-Transaction-ID: 25eea934587e4f18bbd903edeb6bea94 X-filter-score: X-Real-From: chensong_2000@189.cn X-Receive-IP: 123.150.8.42 X-MEDUSA-Status: 0 Sender: chensong_2000@189.cn Subject: Re: linux-next: build failures after merge of the staging tree To: Geert Uytterhoeven , Stephen Rothwell Cc: Greg KH , Linux Kernel Mailing List , Linux Next Mailing List References: <20210104122653.6f35b9bb@canb.auug.org.au> From: "chensong_2000@189.cn" Message-ID: <75a11414-fa59-a630-c025-7b232dc14be8@189.cn> Date: Mon, 4 Jan 2021 16:32:58 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org i will take care of this 在 2021/1/4 下午4:27, Geert Uytterhoeven 写道: > On Mon, Jan 4, 2021 at 6:12 AM Stephen Rothwell wrote: >> After merging the staging tree, today's linux-next build (arm >> multi_v7_defconfig) failed like this: >> >> In file included from include/linux/printk.h:6, >> from include/linux/kernel.h:16, >> from drivers/staging/board/kzm9d.c:4: >> drivers/staging/board/kzm9d.c:28:17: error: initialization of 'initcall_t' {aka 'int (*)(void)'} from incompatible pointer type 'void (*)(void)' [-Werror=incompatible-pointer-types] >> 28 | device_initcall(kzm9d_init); >> | ^~~~~~~~~~ >> include/linux/init.h:197:50: note: in definition of macro '___define_initcall' >> 197 | __attribute__((__section__(#__sec ".init"))) = fn; >> | ^~ >> include/linux/init.h:229:30: note: in expansion of macro '__define_initcall' >> 229 | #define device_initcall(fn) __define_initcall(fn, 6) >> | ^~~~~~~~~~~~~~~~~ >> drivers/staging/board/kzm9d.c:28:1: note: in expansion of macro 'device_initcall' >> 28 | device_initcall(kzm9d_init); >> | ^~~~~~~~~~~~~~~ >> cc1: some warnings being treated as errors >> In file included from include/linux/printk.h:6, >> from include/linux/kernel.h:16, >> from include/asm-generic/bug.h:20, >> from arch/arm/include/asm/bug.h:60, >> from include/linux/bug.h:5, >> from include/linux/thread_info.h:12, >> from include/asm-generic/current.h:5, >> from ./arch/arm/include/generated/asm/current.h:1, >> from include/linux/sched.h:12, >> from include/linux/ratelimit.h:6, >> from include/linux/dev_printk.h:16, >> from include/linux/device.h:15, >> from include/linux/dma-mapping.h:7, >> from drivers/staging/board/armadillo800eva.c:12: >> drivers/staging/board/armadillo800eva.c:90:17: error: initialization of 'initcall_t' {aka 'int (*)(void)'} from incompatible pointer type 'void (*)(void)' [-Werror=incompatible-pointer-types] >> 90 | device_initcall(armadillo800eva_init); >> | ^~~~~~~~~~~~~~~~~~~~ >> include/linux/init.h:197:50: note: in definition of macro '___define_initcall' >> 197 | __attribute__((__section__(#__sec ".init"))) = fn; >> | ^~ >> include/linux/init.h:229:30: note: in expansion of macro '__define_initcall' >> 229 | #define device_initcall(fn) __define_initcall(fn, 6) >> | ^~~~~~~~~~~~~~~~~ >> drivers/staging/board/armadillo800eva.c:90:1: note: in expansion of macro 'device_initcall' >> 90 | device_initcall(armadillo800eva_init); >> | ^~~~~~~~~~~~~~~ >> >> Caused by commit >> >> 850c35bb28ec ("staging: board: Remove macro board_staging") >> >> I have used the staging tree from next-20201223 for today. > > Note that a similar patch was (IMHO rightfully) rejected 3 years ago: > https://lore.kernel.org/lkml/20170220175506.GA30142@kroah.com/ > > So please drop it. Thanks! > > Gr{oetje,eeting}s, > > Geert > > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >