From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933511AbcIOLsS (ORCPT ); Thu, 15 Sep 2016 07:48:18 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:9544 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755004AbcIOLsP (ORCPT ); Thu, 15 Sep 2016 07:48:15 -0400 X-AuditID: cbfec7f4-f791c6d000006eac-a5-57da8a7ad015 Subject: Re: [PATCH 1/6] leds: gpio: fix an unhandled error case in create_gpio_led To: Heiner Kallweit Cc: "linux-leds@vger.kernel.org" , Linux Kernel Mailing List From: Jacek Anaszewski Message-id: <75b174d3-14cc-15c9-ab01-b2e2faa296de@samsung.com> Date: Thu, 15 Sep 2016 13:48:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <15945af0-24df-ff7c-73b7-7872dc5ed8bd@gmail.com> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsWy7djP87rVXbfCDe6/ZLZY9H4Gq8XlXXPY LLa+WcfowOyxc9Zddo/Pm+QCmKK4bFJSczLLUov07RK4Mmbu7WIq6OOueL53L0sDYz9nFyMn h4SAiUTfxrNsELaYxIV764FsLg4hgaWMEsea37FDOJ8ZJdZ1TGKG6fh6+StUYhlQ4vR/KOcZ o0TDm5tMIFXCAqESfd8bWUBsEQEtiQmv14DtYBaolNg1p58dxGYTMJT4+eI1UD0HB6+AncTt A2UgYRYBVYkVz9+zgYRFBSIkdt9NBQnzCghK/Jh8D2wip4CtxPl/zcwQE60knv1rZYWw5SU2 r3kLdednNok/j6tAxkgIyEpsOgAVdpE4NG0LO4QtLPHqOIwtI3F5cjcLyCcSApMZJS4eu8kK 4axmlNjY2ckCUWUt0fD/FwvEMj6JSdumM0Ms4JXoaBOCKPGQeH78GtQyR4mu+UfBFggJHGaU WP+3cAKj/Cwk78xC8sIsJC8sYGRexSiSWlqcm55abKJXnJhbXJqXrpecn7uJEZgGTv87/mUH 4+JjVocYBTgYlXh4G/xuhguxJpYVV+YeYpTgYFYS4d3beitciDclsbIqtSg/vqg0J7X4EKM0 B4uSOO+eBVfChQTSE0tSs1NTC1KLYLJMHJxSDYzV+0r/MATevLbAUnLC35vuBZ+Dna/MXHlx i+qiyyp1Uocve+kIXJU/dKm9aflHT0eXIrYZXxd+St+xhdfz2NPnh97KlgekzcgQecsidWb9 /H3cP55di/xyoGu36uJVW5Vb/gs82lC+5nl5qsAiOe4C7l3Joa3rHqlP4TN+4X240l3RlvEG q22AEktxRqKhFnNRcSIAShE2MP8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42I5/e/4ZV2vrlvhBk3fVSwWvZ/BanF51xw2 i61v1jE6MHvsnHWX3ePzJrkApig3m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE3FRbpQhd 35AgJYWyxJxSIM/IAA04OAe4Byvp2yW4Zczc28VU0Mdd8XzvXpYGxn7OLkZODgkBE4mvl7+y Q9hiEhfurWcDsYUEljBK/F9Y1sXIBWQ/Y5S4vGwnC0hCWCBUou97I5gtIqAlMeH1GjaIosOM Epv3XmUESTALVEo8a3sNNolNwFDi54vXTF2MHBy8AnYStw+UgYRZBFQlVjx/D1YiKhAhcWvV R7BWXgFBiR+T74HN5xSwlTj/r5kZYqSZxJeXh1khbHmJzWveMk9gFJiFpGUWkrJZSMoWMDKv YhRJLS3OTc8tNtIrTswtLs1L10vOz93ECIyKbcd+btnB2PUu+BCjAAejEg9vg9/NcCHWxLLi ytxDjBIczEoivHtbb4UL8aYkVlalFuXHF5XmpBYfYjQFemIis5Rocj4wYvNK4g1NDM0tDY2M LSzMjYyUxHmnfrgSLiSQnliSmp2aWpBaBNPHxMEp1cAo1/ZkzoKbfFvTvpksfyGaXaSZV/jk OPOd1VUvZvBbtG4wOe85/eaH7+a2qud+v2hYu+Tm3L/dT/mnie6835adJP42Q75shUT5Nw7e vXwb76yb4xVil22jzxrgX2K08aS5cty0nfWNNfOv/brEUrCsbM0L+8qKnm9Beoss/7b/yp22 LK9r0UleJZbijERDLeai4kQAIsah8qACAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160915114810eucas1p1b6bcd55b0b795e8f9fabf66e38ef0c20 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160913185832eucas1p2d66fec4689db17f211d2557fe426e3d2 X-RootMTR: 20160913185832eucas1p2d66fec4689db17f211d2557fe426e3d2 References: <5432fb03-ea18-a949-ce53-10fedc15f5d9@gmail.com> <15945af0-24df-ff7c-73b7-7872dc5ed8bd@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiner, On 09/13/2016 08:53 PM, Heiner Kallweit wrote: > gpiod_get_value_cansleep returns 0, 1, or an error code. > So far errors are not handled and treated the same as 1. > Change this to bail out if an error code is returned and > remove the double negation. > > Signed-off-by: Heiner Kallweit > --- > drivers/leds/leds-gpio.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c > index 3599b2e..10c851e 100644 > --- a/drivers/leds/leds-gpio.c > +++ b/drivers/leds/leds-gpio.c > @@ -118,10 +118,13 @@ static int create_gpio_led(const struct gpio_led *template, > led_dat->platform_gpio_blink_set = blink_set; > led_dat->cdev.blink_set = gpio_blink_set; > } > - if (template->default_state == LEDS_GPIO_DEFSTATE_KEEP) > - state = !!gpiod_get_value_cansleep(led_dat->gpiod); > - else > + if (template->default_state == LEDS_GPIO_DEFSTATE_KEEP) { > + state = gpiod_get_value_cansleep(led_dat->gpiod); > + if (state < 0) > + return state; > + } else { > state = (template->default_state == LEDS_GPIO_DEFSTATE_ON); > + } > led_dat->cdev.brightness = state ? LED_FULL : LED_OFF; > if (!template->retain_state_suspended) > led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME; > Thanks for the updated patch set. Applied. -- Best regards, Jacek Anaszewski