From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BFDDC43334 for ; Mon, 6 Jun 2022 20:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234491AbiFFUw6 (ORCPT ); Mon, 6 Jun 2022 16:52:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232621AbiFFUwY (ORCPT ); Mon, 6 Jun 2022 16:52:24 -0400 Received: from smtp.smtpout.orange.fr (smtp03.smtpout.orange.fr [80.12.242.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F007821818 for ; Mon, 6 Jun 2022 13:42:16 -0700 (PDT) Received: from [192.168.1.18] ([90.11.190.129]) by smtp.orange.fr with ESMTPA id yJY7nohIwJXxRyJY8nmBKa; Mon, 06 Jun 2022 22:42:15 +0200 X-ME-Helo: [192.168.1.18] X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Mon, 06 Jun 2022 22:42:15 +0200 X-ME-IP: 90.11.190.129 Message-ID: <75b293bd-ec8d-8c90-ffe5-afa49d6a218d@wanadoo.fr> Date: Mon, 6 Jun 2022 22:42:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] stmmac: intel: Fix an error handling path in intel_eth_pci_probe() Content-Language: en-US To: Wong Vee Khee Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <1ac9b6787b0db83b0095711882c55c77c8ea8da0.1654462241.git.christophe.jaillet@wanadoo.fr> <20220606062650.GA31937@linux.intel.com> From: Christophe JAILLET In-Reply-To: <20220606062650.GA31937@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 06/06/2022 à 08:26, Wong Vee Khee a écrit : > On Sun, Jun 05, 2022 at 10:50:48PM +0200, Christophe JAILLET wrote: >> When the managed API is used, there is no need to explicitly call >> pci_free_irq_vectors(). >> >> This looks to be a left-over from the commit in the Fixes tag. Only the >> .remove() function had been updated. >> >> So remove this unused function call and update goto label accordingly. >> >> Fixes: 8accc467758e ("stmmac: intel: use managed PCI function on probe and resume") >> Signed-off-by: Christophe JAILLET >> --- >> drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> > > LGTM > > Reviewed-by: Wong Vee Khee > > Hi, I've looked at it again. I still think that the patch is good, but pcim_release() has changed in 5.18 since commit 3f35d2cf9fbc ("PCI/MSI: Decouple MSI[-X] disable from pcim_release()") I guess that all the mechanic is in place so that everything is registered when needed, but I've not been able to figure it out in the case of dwmac-intel.c. So, double check :). CJ