From: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Rob Herring (Arm)" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"chaitanya chundru" <quic_krichai@quicinc.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, "Jingoo Han" <jingoohan1@gmail.com>,
"Konrad Dybcio" <konradybcio@kernel.org>,
quic_vbadigan@quicnic.com, jorge.ramirez@oss.qualcomm.com,
cros-qcom-dts-watchers@chromium.org, linux-pci@vger.kernel.org,
"Bjorn Andersson" <andersson@kernel.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
amitk@kernel.org, "Krzysztof Kozlowski" <krzk+dt@kernel.org>,
dmitry.baryshkov@linaro.org
Subject: Re: [PATCH v4 01/10] dt-bindings: PCI: Add binding for Toshiba TC956x PCIe switch
Date: Mon, 17 Mar 2025 14:39:41 +0530 [thread overview]
Message-ID: <75bd4685-a6ea-4852-f41f-fd4437383774@oss.qualcomm.com> (raw)
In-Reply-To: <20250313055657.ddrzqo2edx46az7b@thinkpad>
On 3/13/2025 11:26 AM, Manivannan Sadhasivam wrote:
> On Fri, Feb 28, 2025 at 04:26:23AM +0530, Krishna Chaitanya Chundru wrote:
>>
>>
>> On 2/25/2025 6:53 PM, Rob Herring (Arm) wrote:
>>>
>>> On Tue, 25 Feb 2025 15:03:58 +0530, Krishna Chaitanya Chundru wrote:
>>>> From: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>>>>
>>>> Add a device tree binding for the Toshiba TC956x PCIe switch, which
>>>> provides an Ethernet MAC integrated to the 3rd downstream port and two
>>>> downstream PCIe ports.
>>>>
>>>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>>>> Reviewed-by: Bjorn Andersson <andersson@kernel.org>
>>>> ---
>>>> .../devicetree/bindings/pci/toshiba,tc956x.yaml | 178 +++++++++++++++++++++
>>>> 1 file changed, 178 insertions(+)
>>>>
>>>
>>> My bot found errors running 'make dt_binding_check' on your patch:
>>>
>>> yamllint warnings/errors:
>>>
>>> dtschema/dtc warnings/errors:
>>> Warning: Duplicate compatible "pciclass,0604" found in schemas matching "$id":
>>> http://devicetree.org/schemas/pci/toshiba,tc956x.yaml#
>>> http://devicetree.org/schemas/pci/pci-pci-bridge.yaml#
>> Hi Rob,
>>
>> As we want to refernce pci-pci-bridge.yaml which is expecting compatible
>> as "pciclass,0604", we modified the compatible as "pci1179,0623",
>> "pciclass,0604". Now adding pciclass0604 is giving this warning. can you
>> suggest correct way to represent this.
>>
>
> I think the PCI-PCI bridge compatible should be part of the actual bridge nodes
> inside the switch. I still stand by my view that the bridge compatible doesn't
> make sense for the top level switch node as this switch is a sort of MFD.
>
> So you should do:
>
> pcie@0,0 {
> compatible = "pci1179,0623";
> reg = <0x10000 0x0 0x0 0x0 0x0>;
> ...
>
> pcie@1,0 {
> compatible = "pciclass,0604";
> reg = <0x20800 0x0 0x0 0x0 0x0>;
> ...
> };
> };
>
Thanks mani for the inputs on this.
For child nodes I will make pci-pci-bridge as a reference and for the
main node( pcie@0,0) I will pci-bus-common.yaml as reference.
- Krishna Chaitanya.
>
> - Mani
>
next prev parent reply other threads:[~2025-03-17 9:09 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 9:33 [PATCH v4 00/10] PCI: Enable Power and configure the " Krishna Chaitanya Chundru
2025-02-25 9:33 ` [PATCH v4 01/10] dt-bindings: PCI: Add binding for Toshiba " Krishna Chaitanya Chundru
2025-02-25 13:23 ` Rob Herring (Arm)
2025-02-27 22:56 ` Krishna Chaitanya Chundru
2025-03-13 5:56 ` Manivannan Sadhasivam
2025-03-17 9:09 ` Krishna Chaitanya Chundru [this message]
2025-02-26 7:30 ` Krzysztof Kozlowski
2025-02-27 3:53 ` Krishna Chaitanya Chundru
2025-02-27 11:40 ` Krzysztof Kozlowski
2025-03-25 13:56 ` Konrad Dybcio
2025-04-01 5:52 ` Krishna Chaitanya Chundru
2025-04-09 13:22 ` Konrad Dybcio
2025-04-09 14:49 ` Konrad Dybcio
2025-02-25 9:33 ` [PATCH v4 02/10] arm64: dts: qcom: qcs6490-rb3gen2: Add TC956x PCIe switch node Krishna Chaitanya Chundru
2025-02-25 11:49 ` Dmitry Baryshkov
2025-03-17 9:35 ` Krishna Chaitanya Chundru
2025-03-17 11:27 ` Dmitry Baryshkov
2025-03-14 11:03 ` Dmitry Baryshkov
2025-03-17 11:27 ` Dmitry Baryshkov
2025-03-18 16:11 ` Krishna Chaitanya Chundru
2025-03-18 17:00 ` Dmitry Baryshkov
2025-03-19 3:44 ` Krishna Chaitanya Chundru
2025-03-19 10:13 ` Dmitry Baryshkov
2025-03-19 10:16 ` Krishna Chaitanya Chundru
2025-03-19 10:21 ` Dmitry Baryshkov
2025-03-19 10:46 ` Krishna Chaitanya Chundru
2025-03-19 11:06 ` Dmitry Baryshkov
2025-03-19 14:12 ` Konrad Dybcio
2025-03-19 15:02 ` Dmitry Baryshkov
2025-02-25 9:34 ` [PATCH v4 03/10] PCI: Add new start_link() & stop_link function ops Krishna Chaitanya Chundru
2025-02-25 9:34 ` [PATCH v4 04/10] PCI: dwc: Add host_start_link() & host_start_link() hooks for dwc glue drivers Krishna Chaitanya Chundru
2025-02-25 9:34 ` [PATCH v4 05/10] PCI: dwc: Implement .start_link(), .stop_link() hooks Krishna Chaitanya Chundru
2025-02-25 9:34 ` [PATCH v4 06/10] PCI: qcom: Add support for host_stop_link() & host_start_link() Krishna Chaitanya Chundru
2025-02-25 9:34 ` [PATCH v4 07/10] PCI: PCI: Add pcie_is_link_active() to determine if the PCIe link is active Krishna Chaitanya Chundru
2025-02-25 9:54 ` Lukas Wunner
2025-02-25 10:06 ` Krishna Chaitanya Chundru
2025-02-25 9:34 ` [PATCH v4 08/10] PCI: pwrctrl: Add power control driver for tc956x Krishna Chaitanya Chundru
2025-02-25 11:53 ` Dmitry Baryshkov
2025-02-25 12:09 ` Konrad Dybcio
2025-03-17 9:07 ` Krishna Chaitanya Chundru
2025-02-25 9:34 ` [PATCH v4 09/10] dt-bindings: PCI: qcom,pcie-sc7280: Add 'global' interrupt Krishna Chaitanya Chundru
2025-02-26 7:32 ` Krzysztof Kozlowski
2025-02-26 16:29 ` Bjorn Andersson
2025-02-26 21:33 ` Krzysztof Kozlowski
2025-02-27 3:39 ` Krishna Chaitanya Chundru
2025-02-27 3:48 ` Manivannan Sadhasivam
2025-03-05 7:36 ` Jorge Ramirez
2025-03-05 7:48 ` Manivannan Sadhasivam
2025-03-05 12:14 ` Krzysztof Kozlowski
2025-02-25 9:34 ` [PATCH v4 10/10] arm64: dts: qcom: sc7280: Add 'global' interrupt to the PCIe RC nodes Krishna Chaitanya Chundru
2025-02-25 11:52 ` Dmitry Baryshkov
2025-02-25 12:03 ` Konrad Dybcio
2025-02-27 3:57 ` [PATCH v4 00/10] PCI: Enable Power and configure the TC956x PCIe switch Manivannan Sadhasivam
2025-02-27 3:59 ` Manivannan Sadhasivam
2025-02-27 4:11 ` Krishna Chaitanya Chundru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75bd4685-a6ea-4852-f41f-fd4437383774@oss.qualcomm.com \
--to=krishna.chundru@oss.qualcomm.com \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jingoohan1@gmail.com \
--cc=jorge.ramirez@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_vbadigan@quicnic.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®