From: Christian Lamparter <chunkeey@gmail.com>
To: Kees Cook <keescook@chromium.org>,
Johannes Berg <johannes@sipsolutions.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Christian Lamparter <chunkeey@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] mac80211: Use memset_after() to clear tx status
Date: Sat, 20 Nov 2021 16:17:33 +0100 [thread overview]
Message-ID: <75be2d3b-99c4-f84b-4da5-da0f4c220359@gmail.com> (raw)
In-Reply-To: <20211118203839.1289276-1-keescook@chromium.org>
On 18/11/2021 21:38, Kees Cook wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memset(), avoid intentionally writing across
> neighboring fields.
>
> Use memset_after() so memset() doesn't get confused about writing
> beyond the destination member that is intended to be the starting point
> of zeroing through the end of the struct.
>
> Additionally fix the common helper, ieee80211_tx_info_clear_status(),
> which was not clearing ack_signal, but the open-coded versions
> did. Johannes Berg points out this bug was introduced by commit
> e3e1a0bcb3f1 ("mac80211: reduce IEEE80211_TX_MAX_RATES") but was harmless.
>
> Also drops the associated unneeded BUILD_BUG_ON()s, and adds a note to
> carl9170 about usage.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Tested-by: Christian Lamparter <chunkeey@gmail.com> [both CARL9170+P54USB on real HW]
next prev parent reply other threads:[~2021-11-20 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 20:38 Kees Cook
2021-11-20 15:17 ` Christian Lamparter [this message]
2021-11-20 18:36 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75be2d3b-99c4-f84b-4da5-da0f4c220359@gmail.com \
--to=chunkeey@gmail.com \
--cc=chunkeey@googlemail.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®