From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8D9B35028C for ; Mon, 16 Mar 2026 22:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.161 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773701738; cv=none; b=VEebuOfVTctQWMmMMML0In3uXEq95M0Vx/hwxWnMzC5kaeUOVZi3ptCid5StYlJyfiYnvalpXdpk53LwDwtoWO81SIoRvR4pf+0O0JCgk3fRiUFG6SQDvfMijJ2+7gNBsVfLXNQFzT+tARC8ZCpkGIBoeqXyH7lFf/CN2SZOhok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773701738; c=relaxed/simple; bh=2xROlIw1mJShMF5SMJBGS0BdEUTqBpDku6T1tZixo1I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MWSOntmyQJQaIAQSdvOspZOTsIEKhlhvxqPToXWgThiAAlqK5SX46/atm0MYaUKejy72kx5f8M7LfgmHP6dReDghBaTeBnnRCXjJv/H0ZW/g3Rp+1P2jN1au4FEcApmmUQ46ozgEVMgV+lQrorPqLZc5rxxTF07Fcem2z/KkwEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=kUyfVj3M; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=yAHm48Q+; arc=none smtp.client-ip=80.241.56.161 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="kUyfVj3M"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="yAHm48Q+" Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4fZVmb6P3Xz9v00; Mon, 16 Mar 2026 23:55:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1773701727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0zQl7cPK8o82oDVPmKR3a3SOGUatFxVTSQfvqTycius=; b=kUyfVj3MwJuurhQGTygc63hJneZ/+dZ3F+/vliKECECbfXiFxZwHiqmaIZaT7/25/dgtSx sCzQlLh0HCx8OLBazpQEELJq8tXLfbLilClX+Rs0ntpsloxFMTXU/Jgpiem7niOikvJrGK NvzblDGsBLzlCCImr9e5zWC30LDHdHo1EsJtObpBM0wimktj8nVbMpNOnRxtC7BMaX3x/C Sce5WsM4w/Y7bSSSvoaHKLvgMQEyJ5vjImBghTsiB5yQaX13KwdfZ0O9jV08iCvbiLMqGp Pp1xcUGSvfKm149GXMS88gSHq2UxFIYiCQcG+K6YnDvwh3dkXwZMkbTZG+cdqg== Message-ID: <75be8726-ad91-445d-b407-f438e76ff5cc@mailbox.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1773701726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0zQl7cPK8o82oDVPmKR3a3SOGUatFxVTSQfvqTycius=; b=yAHm48Q+MxcfzuNaW06La5X6krCdtnXve+KfvSpkfqQInxCLQJg5PgOyCHiNJQJfgpDlGd yYI9NRMg6Y6ntf1BUcgWrsA78C46+o5TOmckDrjfBVUYOCXI2euKdqR6WjHAfmb+Dw63kL GzhdruqwxH8n0kTQWOycyjiqTy7WzFeMe5OM20dYoNDjB8zWdae5sseYMckTZM0s3J+GaY uqopbap1ztTgdK5/XrMNOsTIsxc4bcgJBOme0+hYoXk1z5VjYWsZX8Ey8SilY4Vcu7q1uc dehFR3ImiWBNbNhiFUGpMG+Rb0HrPzsQ3knzCB7bMEGRbOmeZnvU/zsM8wUR3g== Date: Mon, 16 Mar 2026 23:55:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] drm/bridge: waveshare-dsi: Fix signedness bug To: Luca Ceresoli , Ethan Tidmore , Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Marek Vasut , Joseph Guo , kernel test robot References: <20260307033245.71666-1-ethantidmore06@gmail.com> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MBO-RS-ID: 6115f17c11067e0c3db X-MBO-RS-META: p14fb1wrm3uuum8qfyghrb7dnu7dj1ku On 3/9/26 12:10 PM, Luca Ceresoli wrote: > On Sat Mar 7, 2026 at 4:32 AM CET, Ethan Tidmore wrote: >> The function drm_of_get_data_lanes_count_ep() returns negative error >> codes and dsi->lanes is an unsigned integer, so the check (dsi->lanes < >> 0) is always impossible. >> >> Make the return value of drm_of_get_data_lanes_count_ep() be assigned to >> ret, check for error, and then assign dsi->lanes to ret. >> >> Detected by Smatch: >> drivers/gpu/drm/bridge/waveshare-dsi.c:70 ws_bridge_attach_dsi() warn: >> unsigned 'dsi->lanes' is never less than zero. >> >> Reported-by: kernel test robot >> Closes: https://lore.kernel.org/oe-kbuild-all/202603060341.hNj0pl9L-lkp@intel.com/ >> Fixes: fca11428425e9 ("drm/bridge: waveshare-dsi: Add support for 1..4 DSI data lanes") >> Signed-off-by: Ethan Tidmore > > Reviewed-by: Luca Ceresoli Reviewed-by: Marek Vasut (it seems FDO patchwork did not pick this up)