From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7832FC433F5 for ; Mon, 1 Nov 2021 07:13:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56FB76108C for ; Mon, 1 Nov 2021 07:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231197AbhKAHPf (ORCPT ); Mon, 1 Nov 2021 03:15:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:35928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbhKAHPd (ORCPT ); Mon, 1 Nov 2021 03:15:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9723E60FE8; Mon, 1 Nov 2021 07:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635750780; bh=vHovt+cQzLZT7BElPIMbzumsvBYvSVJ0/rUbXoi52bo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lQYnG+YAUYKW1+jNysoNFIybCd4R4j7cLy84azLDo40aZd/T0kuv9Db7SXSGkOrJQ XMFpPiGnAcd4ZEkJZnHuoGRTBG2J2+zi313Z+7x7NKfG9JuoFkOzatfz2yJATrXY0Q 9SXlRFz0GgSw+QiMPlQykLsq1HEivcHs64dUK96Q0dfhs9EIH9L+jYe11XS+44MWSR lLwNqoUvtimuEVS2fDUkhN3Lj3gTyfd0+WSqodh79eqZBA9tobzMyC30LDXuj9Db0S hI2vI8yvIUJjuGvwoAXtnsm1Taze4IFtQ5V9rKHdSf/IrQcVIG0KXJjIIm3lwqyocn ZEmnyk8HChPZw== Message-ID: <75c52307-7bfd-2408-d067-26d1fca7bb73@kernel.org> Date: Mon, 1 Nov 2021 15:12:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] F2FS: invalidate META_MAPPING before IPU/DIO write Content-Language: en-US To: Hyeong-Jun Kim , Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20211101054214.24456-1-hj514.kim@samsung.com> <9a0360922130485f4252970de4bb535667cc26e9.camel@samsung.com> From: Chao Yu In-Reply-To: <9a0360922130485f4252970de4bb535667cc26e9.camel@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/11/1 15:09, Hyeong-Jun Kim wrote: > On Mon, 2021-11-01 at 14:28 +0800, Chao Yu wrote: >> On 2021/11/1 13:42, Hyeong-Jun Kim wrote: >>> Encrypted pages during GC are read and cached in META_MAPPING. >>> However, due to cached pages in META_MAPPING, there is an issue >>> where >>> newly written pages are lost by IPU or DIO writes. >>> >>> Thread A Thread B >>> - f2fs_gc(): blk 0x10 -> 0x20 (a) >>> - IPU or DIO write on blk >>> 0x20 (b) >>> - f2fs_gc(): blk 0x20 -> 0x30 (c) >>> >>> (a) page for blk 0x20 is cached in META_MAPPING and page for blk >>> 0x10 >>> is invalidated from META_MAPPING. >>> (b) write new data to blk 0x200 using IPU or DIO, but outdated data >>> still remains in META_MAPPING. >>> (c) f2fs_gc() try to move blk from 0x20 to 0x30 using cached page >>> in >>> META_MAPPING. In conclusion, the newly written data in (b) is >>> lost. >> >> In c), f2fs_gc() will readahead encrypted block from disk via >> ra_data_block() anyway, >> not matter cached encrypted page of meta inode is uptodate or not, so >> it's safe, right? > Right, > However, if DIO write is performed between phase 3 and phase 4 of > f2fs_gc(), > the cached page of meta_mapping will be out-dated, though it read data > from > disk via ra_data_block() in phase 3. > > What do you think? Due to i_gc_rwsem lock coverage, the race condition should not happen right now? Thanks, > > Thanks, >> >> Am I missing anything? >> >> Thanks, >> >>> To address this issue, invalidating pages in META_MAPPING before >>> IPU or >>> DIO write. >>> >>> Signed-off-by: Hyeong-Jun Kim < >>> hj514.kim@samsung.com >>>> >>> --- >>> fs/f2fs/data.c | 2 ++ >>> fs/f2fs/segment.c | 3 +++ >>> 2 files changed, 5 insertions(+) >>> >>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >>> index 74e1a350c1d8..9f754aaef558 100644 >>> --- a/fs/f2fs/data.c >>> +++ b/fs/f2fs/data.c >>> @@ -1708,6 +1708,8 @@ int f2fs_map_blocks(struct inode *inode, >>> struct f2fs_map_blocks *map, >>> */ >>> f2fs_wait_on_block_writeback_range(inode, >>> map->m_pblk, map- >>>> m_len); >>> + invalidate_mapping_pages(META_MAPPING(sbi), >>> + map->m_pblk, map- >>>> m_pblk); >>> >>> if (map->m_multidev_dio) { >>> block_t blk_addr = map->m_pblk; >>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >>> index 526423fe84ce..f57c55190f9e 100644 >>> --- a/fs/f2fs/segment.c >>> +++ b/fs/f2fs/segment.c >>> @@ -3652,6 +3652,9 @@ int f2fs_inplace_write_data(struct >>> f2fs_io_info *fio) >>> goto drop_bio; >>> } >>> >>> + invalidate_mapping_pages(META_MAPPING(fio->sbi), >>> + fio->new_blkaddr, fio->new_blkaddr); >>> + >>> stat_inc_inplace_blocks(fio->sbi); >>> >>> if (fio->bio && !(SM_I(sbi)->ipu_policy & (1 << >>> F2FS_IPU_NOCACHE))) >>> >> >> >