From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 645352F28E5 for ; Tue, 3 Feb 2026 09:09:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770109802; cv=none; b=H9OnVRq8y2QpvS8czG1HK1tz0IYeotkzv/4NVFmOF5V6PiXPAWtays+S16e/uMaWjMNTc0ojAhgvZYIk3q2fqed2dGce3iSfdfDyylW/M2Z0g0ckPwUmQVqTCyfgpNYTcA+sHHHe9nD6IyU3EmuxBYj08dtO+mEHngntpDpHITk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770109802; c=relaxed/simple; bh=L7Kh/bqhafCATcc9hmnZnvvIskm6OmlNj10QxSsKNbc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=niOVtcKv+ml8mjaK4SYgiGcA74/S/sGYKaUJGsu+4Jo0NeoRFW+lI6DwgJ8ZI7VplUAmxm2ZvfwR0hxkJR7hLEeKX4F12Q1NcNTv1W3CT9pgc0tZSnITw0U7XM/CvxvA3eKDNGnxrOnwu5W0OkT28+mJ3HUFNmC1pv/sdIOpoI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=efUwOsx9; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="efUwOsx9" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 8A9481A2BB2; Tue, 3 Feb 2026 09:09:57 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 5779960728; Tue, 3 Feb 2026 09:09:57 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id F060F119A88FD; Tue, 3 Feb 2026 10:09:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770109796; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=QOT/HywNFpZOIuExwAQ6ejkkEBKtyxh49WINkpm07Cw=; b=efUwOsx9RK054mZF2HF3Q0OTGS2uw8nH/eF6hdYdjXDFDtVoRMap2MDsZZ0iStv34tDqcy DUJSUI+42ezuUpvXkVYy5iRLk3xK03mu0bMaIYGeX0+SRPkfvZhGsPdFEEJMrcI/JFMZRw yqun50MkEQjC127rBsOJ9+zqNTZfFpRhnhInyTGVfTlDT0Ns6WPvG+okLEvYGMCkeVZq9B 52P9Ub2ahyLleS7Gu2/GJcRjFc/sFXoKuF6nKwAiHUV86EpxK8HZcfxvkr2eK4wGvrzjrk 3PGzyQzyZi9cMRmJDu+1tbxTcbCelN3+ICs3h9ET/N3dHkaUCj4p3JIl0G4+EA== Message-ID: <75c590f9-aa08-4b8d-8dbf-422273012c74@bootlin.com> Date: Tue, 3 Feb 2026 10:09:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/4] dt-bindings: net: ethernet-phy: add property enet-phy-lane-order To: Damien Dejean , andrew@lunn.ch, krzk+dt@kernel.org, robh@kernel.org, kuba@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, davem@davemloft.net, pabeni@redhat.com, hkallweit1@gmail.com References: <20260202200411.373161-1-dam.dejean@gmail.com> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20260202200411.373161-1-dam.dejean@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 02/02/2026 21:04, Damien Dejean wrote: > Add property enet-phy-lane-order to the device tree bindings to define > the lane order of the PHY. To simplify PCB design some manufacturers > allow to wire the pairs in a reverse order, and change the order in > software. > > The property can be set to 0 to force the normal lane order (ABCD), or 1 > to force the reverse lane order (DCBA). > > Signed-off-by: Damien Dejean > --- > Documentation/devicetree/bindings/net/ethernet-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > index 58634fee9fc4..8347d4e134d2 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > @@ -126,6 +126,12 @@ properties: > e.g. wrong bootstrap configuration caused by issues in PCB > layout design. > > + enet-phy-lane-order: As this is specific to BaseT, maybe rename that "enet-phy-pair-order" ? > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1] > + description: > + For normal (0) or reverse (1) order of the pairs (ABCD -> DCBA). We now have a binding in DT for ethernet-connectors, and I'd says this is typically the kind of info I'd put in there : https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/Documentation/devicetree/bindings/net/ethernet-connector.yaml The way you'd use that is by adding a ".attach_mdi_port()" callback in your phy driver, and in there you'd parse these properties and do the proper settings. We're missing a few things, such as storing a ref to the of_node corresponding to the connector into phy_port. This is brand new though, maybe Maintainers would like for phy_port to stabilize before building more on top of it ? Maxime