From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 567252AD00 for ; Wed, 12 Aug 2026 18:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786561158; cv=none; b=XTlN8bj7gTgC/bLSlZwwqe3aaVhMb9t+K/kh+iPPXJq+bdVpbz2Xqgs37IU+0POcExFRvbkCjASsv/mrMV4Q5x6stJCb7VWfMnL7eV4iXRShLKSeUfjyewl1FLzQ58EgWBRJF0UgkXNzuDSzDLYwCR7yvJHFNOBt8Uczv/++uAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786561158; c=relaxed/simple; bh=yEnbG3q6AMh3WvDMSAJMZ7igfLMQ++HdgrmLKXO0qeo=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=dYJc8IDcUKopZdXYpyriv/UkZ+gu4zbi7Vs601KoRaYZ1NP2flCwz7wiiMCheNvoNGQ9xzWa53sJr6n4Td+B3n34cAtZvU72qU+JkPhwUjl01GzvJhe8yChU2NYR0x7JFBnUE7VrSOtDN10rucvSfdibw0Ik7ko8BWgqutSPWMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dvwK04JO; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dvwK04JO" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2cacf197759so26296925ad.2 for ; Wed, 12 Aug 2026 11:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786561157; x=1787165957; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xDUmI7JQdaX2Oj0mItGi6PEt+TH4ELXvui3kKxAmk5E=; b=dvwK04JOxbKPDFnZLXB4ikHPSUUjC0ceiyrq8KEriAdTWNGULTC9HcpkNYb5Hb56u0 tGgH1Z5HQFqf/C92aAmGqfODBFQlTJnZDRq8HBMaCDF4KKRiJ6BgnHlDkan247ugQ276 b57xtXZFa6RdyRRgoJAV06LEAwNaHi3SKXxlR+olEcVo3XZprYRf26iCqeT8ciMmXN+B Iriw0wtJ5zvWGmRHsv1NGzcAM7Exms8zCN8QlaWE0x4/PXPPaolB1wVA1ga2+cMXyNgb FPVRL2JYcJkIdbRPgparu8qOwaLapJksqJuXd6FzhiOw5ckkxCDxcPKL/sEHVwn8rxb2 mVeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786561157; x=1787165957; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=xDUmI7JQdaX2Oj0mItGi6PEt+TH4ELXvui3kKxAmk5E=; b=Yoy9lH3KF4alD5gjNA1nWPZq6wB1s2b2Wr0ol88cEyM6z9lUrp5thNuYHU20zN1pMr NOnYXUv4Z/RJce0f294Gv8Vpmd0AtgMyKz9GSBmuhf7/ZM+/NWVqNQhkNsV4ndI+p2Br QSzrkYudRl0IOvLNWXqAjwDmY8M93pfS4H1wcvNMJhzAa/tzkFy8oNmGrSSMzkW61JyM ooDWjkOiblg0Dv6b8UtxuIu8xDYpS0NwTCenkax8Py+rKiW/VaZX0RxIK4IdCTp3hidT zr9LrmYQnfbtdxEASu77yw+3hFf3mpWpoKYkdhlbfJy/lAnAeJ47FhwzF+v0kjnDoDZF yRfg== X-Forwarded-Encrypted: i=1; AHgh+RoLmOGyZ26S1/xYbZsu7rYtbrT5iMHGFkDtFzavPUAfSVFzbwZkyuKkONW1R6YYZ/6MbQeSu2D9MNDExw4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2ROfXCC1ezAHFtjU9Ilr1BMhiPVZmZZ2CnTe6JzhPMvdtD3Hm DvW++mI2HMFcmolEoY+J1Wp23S1XjtC/g4ZLEeUWeKThf3dvDQjhwc6H X-Gm-Gg: AR+sD11/4EcSl3/GE4JpvvO+Y+OuXp2rluoggpFEWlm0h9zbdxra1W08iVXH3UcagwL ltrjg3lqe2BDXeV9botV9vHCDAvX4YvfJsBPMapJRKiWJ+rhqwQNzJg3ZxLvhzo22z5oWlS5UK+ 864DLrmPVGT3uMdaJtZHNvqk5mtwbBAf68MSXjbWQ9RzFnVzYBb1OnCJW+D+QkWkz6nSC0BYSw9 nV8EUgT9GU2lf8wsoMea8oyfAjzctHOrqRaRWIrZSiSEJ15c5C9he4/LCnfXnRiHLD8t7wS1Iuk LN4eYo+YFw289ZftNw64ZAM1r1wJtdz0Yc8DtWpNU6j5mmbOgvwsx2sogJYI3hkBstyg/bItiDL +DoeNlXsiXk5VCzS61UzdgnxA99Gfwp3NdXxd6fWCYpSqF97BSpeHgAZusVsQ0wdpEFw43odIUJ aSNLUyGN0sGt5+TZYKkMpYW1kL7L+l9THeJ/q+z39GP+hjRIjs+b3Lq60Fm2uWqz3oHxEkF2wNW ETn0wm+UQqAWFv/gCnbw75/Mj3ETNRk+zmKew== X-Received: by 2002:a05:6a20:cc97:b0:3b2:8685:1473 with SMTP id adf61e73a8af0-3cc54f4968dmr839460637.7.1786561156556; Wed, 12 Aug 2026 11:59:16 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31da7bf64b5sm9421251eec.10.2026.08.12.11.59.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2026 11:59:15 -0700 (PDT) Sender: Guenter Roeck Message-ID: <75c8ae75-2103-436b-8f64-e71d4f284b48@roeck-us.net> Date: Wed, 12 Aug 2026 11:59:14 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hwmon: (k10temp) Add per-CCD temperature monitoring for Zen5 Turin To: Gabriel Ford , Clemens Ladisch , "open list:K10TEMP HARDWARE MONITORING DRIVER" , open list References: <20260812163812.2760-1-gabriel@gford.dev> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260812163812.2760-1-gabriel@gford.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/12/26 09:37, Gabriel Ford wrote: > Add support for per-CCD temperature monitoring on Zen 5 Turin (EPYC 9005) > CPUs, as they fall in a different model range with a larger number of > maximum CCDs compared to their desktop counterparts. Tested and working > on an EPYC 9555P. > Sashiko has a point, showing that the temperature of the additional four dies can not be shown due to the code in k10temp_read_temp(). So how does your test result actually look like ? Guenter > Signed-off-by: Gabriel Ford > --- > drivers/hwmon/k10temp.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c > index de0760dc597d..b882fe09ac1b 100644 > --- a/drivers/hwmon/k10temp.c > +++ b/drivers/hwmon/k10temp.c > @@ -207,6 +207,10 @@ static const char *k10temp_temp_label[] = { > "Tccd10", > "Tccd11", > "Tccd12", > + "Tccd13", > + "Tccd14", > + "Tccd15", > + "Tccd16" > }; > > static int k10temp_read_labels(struct device *dev, > @@ -515,6 +519,10 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id) > } > } else if (boot_cpu_data.x86 == 0x1a) { > switch (boot_cpu_data.x86_model) { > + case 0x00 ... 0x2f: /* Zen5 Turin */ > + data->ccd_offset = 0x1F0; > + k10temp_get_ccd_support(data, 16); > + break; > case 0x40 ... 0x4f: /* Zen5 Ryzen Desktop */ > data->ccd_offset = 0x308; > k10temp_get_ccd_support(data, 8);