From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E992DCA9EC0 for ; Tue, 29 Oct 2019 02:36:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB19320862 for ; Tue, 29 Oct 2019 02:36:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730086AbfJ2Cge (ORCPT ); Mon, 28 Oct 2019 22:36:34 -0400 Received: from mga04.intel.com ([192.55.52.120]:3266 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727775AbfJ2Cge (ORCPT ); Mon, 28 Oct 2019 22:36:34 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 19:36:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,242,1569308400"; d="scan'208";a="224828056" Received: from allen-box.sh.intel.com (HELO [10.239.159.136]) ([10.239.159.136]) by fmsmga004.fm.intel.com with ESMTP; 28 Oct 2019 19:36:31 -0700 Cc: baolu.lu@linux.intel.com, "iommu@lists.linux-foundation.org" , LKML , Joerg Roedel , David Woodhouse , Alex Williamson , Jean-Philippe Brucker , "Liu, Yi L" , "Raj, Ashok" , Christoph Hellwig , Jonathan Cameron , Eric Auger Subject: Re: [PATCH v7 09/11] iommu/vt-d: Add bind guest PASID support To: "Tian, Kevin" , Jacob Pan References: <1571946904-86776-1-git-send-email-jacob.jun.pan@linux.intel.com> <1571946904-86776-10-git-send-email-jacob.jun.pan@linux.intel.com> <20191025103337.1e51c0c9@jacob-builder> From: Lu Baolu Message-ID: <75d15d99-d8f8-c09f-e9a7-64c17d037e0e@linux.intel.com> Date: Tue, 29 Oct 2019 10:33:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/28/19 2:03 PM, Tian, Kevin wrote: >>>> .dev_disable_feat = intel_iommu_dev_disable_feat, >>>> .is_attach_deferred = >>>> intel_iommu_is_attach_deferred, .pgsize_bitmap = >>>> INTEL_IOMMU_PGSIZES, +#ifdef CONFIG_INTEL_IOMMU_SVM >>>> + .sva_bind_gpasid = intel_svm_bind_gpasid, >>>> + .sva_unbind_gpasid = intel_svm_unbind_gpasid, >>>> +#endif >>> again, pure PASID management logic should be separated from SVM. >>> >> I am not following, these two functions are SVM functionality, not >> pure PASID management which is already separated in ioasid.c > I should say pure "scalable mode" logic. Above callbacks are not > related to host SVM per se. They are serving gpasid requests from > guest side, thus part of generic scalable mode capability. > Currently these two callbacks are for sva only and the patch has been queued by Joerg for the next rc1. It could be extended to be generic. But it deserves a separated patch. Best regards, baolu