From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BF142FFDE3 for ; Wed, 7 Jan 2026 09:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767777906; cv=none; b=OeA8AeVunq5vKabwRj+HMW5Ig0SM3FJRsJE53lo6tuPRLDRWvmgytJqTfb06u4vLAAKyhtFhcEJgGd0ddlEVuvkipmRDa9wcDTyNhfPG590PcqfNlQnuaYrF6m+ImMY6aXc2hMHw5Pa0kAmbP5etgdqCkRFyq3gfxMCX2Vjp4jQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767777906; c=relaxed/simple; bh=fjMVFlQNfF/Tvn6vpOODNhh+o9dtyfiwpzpLCeB2lrE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bjv9N0qBShes13RRBHmdDeJDrOOtbuwAtc3pumZBwToqjHcre2/qQVd38Jl/r9LkgnVHrhaKBAPz+dW5NuRLm0Bpt0wmqcizqoNRsuMAZoI2tdzyQnN+7n8bIoaVXv8WO/n4Rjy3+3GCtUITVX19LN5GrDQYjLowUNbUcnbqVxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lbsFPiIU; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lbsFPiIU" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b7cf4a975d2so318190666b.2 for ; Wed, 07 Jan 2026 01:25:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767777902; x=1768382702; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CwkMJv5FJ6wM0SfVxDZ1sKMFmxmOc2HwY8yL49JvVEk=; b=lbsFPiIUP8Dho7KCeHizotFwXEuwpoMny6wuOaOqLT6UNrmb+dfhjkoxjrNdTLYntu 2B4WCIvOASHlHBIkqI+o8nazE4HWp6WgSoHbD9Hd1hBX1N7QlTaGNGlvo7PLNTT9WqTy B5eBFTGo36GLQBgPkgj9ET/1CSEf2+JbsMjgzyToq5baS884FulGPodWxUH1tO8qj1CI V85HLkvrW/RD7i83wikM0s/IAOa3TglDIq7ncBgMuRuFgeuoxX/iXIvzaHxGMnyyZQlP oFthOpXQG7jY7SDzJ1rsYMJ+Jmtt/kS38tio98QeAkgBi/MkLGEEdbsuUymuDKkyoila 802Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767777902; x=1768382702; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CwkMJv5FJ6wM0SfVxDZ1sKMFmxmOc2HwY8yL49JvVEk=; b=YC/fEwRSynrTGj5gK/03b6uPMql2eN9iSm1J3lU/bISUptpXuq6dFxwoVOzbQdAVr+ b7BXWvn3g0NPnsi0wGu3OMplkhllih18jkOkZP9I4WiEbV/lazGVOYGX8W0Wx8ddNGNb Kj9oXxaIm0lB/CpahG99mADccstVtYFy8RbF8rJaBeJh8YeuneTFXniZ6chvgNfAuWfP ZgP4ycIslClrS2VQ5h6IM6063NCImoeuD8Iteb2mnSrsE2DyZovRHWnAucwBmeEIMgnM b31p3LIoo9xnJpg0KAYaHXrTc6Zj0jItil977D1Dcwsv+zNWtLqE8QHv2TyfGdNuM0cF MS6w== X-Forwarded-Encrypted: i=1; AJvYcCUYk1QptAG3bo7rbSh33WnUrM3D6HRIUDZoYEY09J7hdxZdO+3beNR7p7bG1B1BqOgpybFDICr8Zn55cYI=@vger.kernel.org X-Gm-Message-State: AOJu0YzqeIGoGhc9NwSndJAxbi3Yx+7gMM691NPnk3wEKqxmMfjSGAPl lxv1sBGghJ7EK4P6y9vRqvtrgJtTJyWF3bOqoVrabC0O/nutua+OsWRe5+rFFA== X-Gm-Gg: AY/fxX6gqs/jSMEYvvVZdJI3KKfFNWx722bWM5LLlEQdVZ0fnWycXM9dJJkb+dd8qeb gE23mCjxC2HYHxRcS8oevGPMkvDhAEfbsIzHH2jCTzjv5V1nzAfIaZwj52i+ik9BtaopMX64OMB ZifQZ/kKIJ8XSryJkifKPhGPA2fmRZx0Ge4FfIKgAEMyh8sOKA7Jhi4dR0NPVNMDBh++uWzDkFG Z6eTUjgu3U8+Of5w2iVUk1kfHrD7DdzqJ7XC7DVRvAX0DGS4z3Sew9v+/9Sa93Mmzt3qWm4K4xw WZwIjpHy19pWEvD1zEFp7gwZ4rdhpSZLdP6HxcdRY8BjBT9Ce8L4DiCcK9GvPQVy9kxeSNVP675 eUkgtT0hGzsSa6QmDMkke8cBiP/hbvnznofK7kkPLrsTwCkQuu9TDgi7tyjCpAYwEj1mDJMDNMS PQ/woQXYXLHx3GjMWYR4jHE1+AQfLMduKFVBRDvAVEnDUCmXaij0UpVJ6FcbiEgEan/+u1AqSTI NRToAPG3KM= X-Google-Smtp-Source: AGHT+IF5gTus43KHKJqt0E1pJCWbD2HwdQLbrkpZB5Dk88YTCWkkUkxD5wZuqMwRfHjHfPeR5J7n1A== X-Received: by 2002:a17:907:9812:b0:b73:792c:6326 with SMTP id a640c23a62f3a-b8444c59fc3mr185201266b.11.1767777902136; Wed, 07 Jan 2026 01:25:02 -0800 (PST) Received: from ?IPV6:2001:9e8:f10a:a01:d0b3:d625:5f5a:710a? ([2001:9e8:f10a:a01:d0b3:d625:5f5a:710a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a4cfe60sm455098866b.45.2026.01.07.01.25.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 01:25:01 -0800 (PST) Message-ID: <75d3d4ed-2288-4189-a027-05c5e9021a37@gmail.com> Date: Wed, 7 Jan 2026 10:25:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gpio: line-mux: remove bits already handled by GPIO core Content-Language: en-US To: Bartosz Golaszewski , Linus Walleij , Bartosz Golaszewski , Thomas Richard Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter References: <20260107085833.17338-1-bartosz.golaszewski@oss.qualcomm.com> From: Jonas Jelonek In-Reply-To: <20260107085833.17338-1-bartosz.golaszewski@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Bartosz, On 07.01.26 09:58, Bartosz Golaszewski wrote: > GPIO core already handles checking the offset against the number of > GPIOs as well as missing any of the GPIO chip callbacks. Remove the > unnecessary bits. > > Also, the offset check was off-by-one as reported by Dan. > > Fixes: 2b03d9a40cd1 ("gpio: add gpio-line-mux driver") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/all/aV4b6GAGz1zyf8Xy@stanley.mountain/ > Signed-off-by: Bartosz Golaszewski > --- > drivers/gpio/gpio-line-mux.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/gpio/gpio-line-mux.c b/drivers/gpio/gpio-line-mux.c > index a4f384306218..62548fbd3ca0 100644 > --- a/drivers/gpio/gpio-line-mux.c > +++ b/drivers/gpio/gpio-line-mux.c > @@ -29,9 +29,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsigned int offset) > struct gpio_lmux *glm = gpiochip_get_data(gc); > int ret; > > - if (offset > gc->ngpio) > - return -EINVAL; > - > ret = mux_control_select_delay(glm->mux, glm->gpio_mux_states[offset], > MUX_SELECT_DELAY_US); > if (ret < 0) > @@ -42,12 +39,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsigned int offset) > return ret; > } > > -static int gpio_lmux_gpio_set(struct gpio_chip *gc, unsigned int offset, > - int value) > -{ > - return -EOPNOTSUPP; > -} > - > static int gpio_lmux_gpio_get_direction(struct gpio_chip *gc, > unsigned int offset) > { > @@ -80,7 +71,6 @@ static int gpio_lmux_probe(struct platform_device *pdev) > glm->gc.parent = dev; > > glm->gc.get = gpio_lmux_gpio_get; > - glm->gc.set = gpio_lmux_gpio_set; > glm->gc.get_direction = gpio_lmux_gpio_get_direction; > > glm->mux = devm_mux_control_get(dev, NULL); Thanks a lot for taking care of that! Tested-by: Jonas Jelonek Reviewed-by: Jonas Jelonek Best, Jonas