From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F316B1F75A6 for ; Fri, 5 Dec 2025 16:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764953261; cv=none; b=Uw3kV8jS4RrzVEVHmrCalcdXDBCki1IJuqrtxjTRGqGJH70hEfXNUMva1h3kbSolgw/6+p/8Jv7096L4Rtz5CUq7SdIiho+NiOtLUBf35Nyu25n3sltbjG7LvTtI/hYFzrKbAc99j1POShyjS6MRlcphYUY3oyrX7WzATowJK94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764953261; c=relaxed/simple; bh=al+Zeq/KhoUTK3Nukkf1s4vVMOh8XPIsPB0Rx8paY2A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E3k7jdVDrKgRLiZupS8m6t+c2QPmCcCVVIpxnU6wUvdF61FrekUiwpZWj51jQQQBM1TQeb6+tF7h2Ozk2f007RM09Zft418Gap9o2kQZYonviPYrFXS3ClL2rq9P396rSr3vr1WTZXZm49ONDZ9bqGkAmj928lt81QgLwuauWks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GTCe6oyU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SDtkSQ3k; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GTCe6oyU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SDtkSQ3k" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B5FBWJG522422 for ; Fri, 5 Dec 2025 16:47:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6gQ4phfn6ife2ezaMBOzgck5fHXd8kJlqOvlD6vM3lA=; b=GTCe6oyUVthJBYZX XKkmsuKvAE6WOzCnY9xNnFDw8x4tIW2x3PUF38cCNa91j8GntPhsV80ld0yAKlZn kLbxj+oNmoTFwqJ3v8VUtGlmMK1iFWTxeJ6xhtpoBlW0k0+vmWVQrHh/zXtz/iu5 LnQBNUVkpAwHgTZ2VQGg+vuiQTXoyK6azmWh3mFPkVgN843fyIIWTXDc4Vi7H9L6 HNswLQ09iGzoOOYpGZyna5qYRIzOjrT5mhoLQ4uK9ia3JA6AncDahcNcXt9XOaf+ f5XvGIBr1bvSWs9HwOlqAjwDSD9H/d0hRgakXqzMzqEI1d7bHRVOtWAK02aSGp+X CZQZTg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4auec1uk26-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Dec 2025 16:47:32 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b2e2342803so503273285a.3 for ; Fri, 05 Dec 2025 08:47:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764953251; x=1765558051; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6gQ4phfn6ife2ezaMBOzgck5fHXd8kJlqOvlD6vM3lA=; b=SDtkSQ3kH2XRsqmZTIrs7Em7q5Ka4IjigqPGbQBz7TM9M3vxxGUKf3ja03QsxalJoM whcT8A8DIBB/PCWwN2FJsZnYvn7n2mM/6Yc+mkcWaXKfcoPhfHVUAfy8TaemjDpZyKdc rbi2fnRW85oJRA358oBrERarlI8u1b5sRRekrYNe9UKfCahbU9P7Q1dO99gXxt3+YnBq W8AOemIu3Rxw4OB592qSxrDGXpKagKDyM+WCc5i7/8tqrPchSAq3K211pOhyPDSAjVpk XB7h9K9QIyJDJl3sBDhV7Ed3O1sO7aTBBDO+oZcaxWhN9+g4YRcvBhAGg57pwGorWhnQ eflg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764953251; x=1765558051; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6gQ4phfn6ife2ezaMBOzgck5fHXd8kJlqOvlD6vM3lA=; b=cHGxODtYJt4WGnzamj7bpx/u47AMH0UvESh5yFSb3ZfEGqHBx/iu21biMoQ8j7H7a9 7jfrZ/uYmFIdMQfQvJnSaqaqj5RB8DGhBjYJVSaPs6j8WqDdH06ascetQc/bi7q4HToo eLYRpfzKQoAWjNdEVeZ8HWjQIb4F7lUH/3jTnxvj8jjE3uKdz/138vZxit0b/hj9KJS4 HGNVc+1VZfIx0rZj1gBKbiHZ8GM+17ppWBkJWwrJonM4dtSe0G2gQfC8DOprSVAgyxbS bzUHzs0aYqcVL58LL0Cef+HP6Pq1xldNU5gtv/0C1/zcAW6Oux9ny9rrtdzbmZhvJ6ok XS7w== X-Forwarded-Encrypted: i=1; AJvYcCWHOxggcro1ii/wQeNaCQ2KURyWnAOrp1s1YG8BQPasUJFPrXU3lU3SM55tKC11dRxjI2dSqM/LZ1IzOpc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9jeL2WccU6e76bPxwmaiRBev936w093MYitzCrss2m4MCIa5u kUGbBvCuVputRHPgLQdoOkDT9nlmXdqQJUvL7JJ6ZCUqxiXxk045zPXiRo6ZTC1DKkFLW9lPRhC WMaew8KRPcJ9wXUDwFaOpBu2OGs4IU5tI4kBTulTFyvICwSqFYa5U4Bp1o0alWHwBuk4= X-Gm-Gg: ASbGncti+vDV/1kONRqlnXzTCY82AxlgiG+bgMnZuvIEvCi5sTn4PRB+3kWye610lNp M10Nirhm97JG/Ke24xlU23j4Rkgb565czH7SACp12E3z5khoUZI2agFCN821o/Y/zy3Sipr4yCE Y2dIGM6ri2VU+C+EqWL/artbgEiQ4BauJ0pVzXQgY5DmvvqGM0+8WeCCJpqAAi6ZOg9xWyrZQ53 63btkUxLY+1mdJ1MXWNpL8bvtZthmnE2gnyShQRS2aeYxoExY51ItknLTmXx5LsW8aBEPsxyZ1w LqEgNKpacmfqg+rHW9Xjf8H8KwbIp/qTrnps6RBBQkl+LjqL0Nq/2f0cupLJuJa36RvE71z8sKH EYonPPyqN21XLkYWij9aAZxtbxeGvwXVqMubMHkI8xvPvrhmRKGol1E4w X-Received: by 2002:a05:620a:4152:b0:891:a03f:7c76 with SMTP id af79cd13be357-8b6181eab7emr1114488685a.76.1764953250898; Fri, 05 Dec 2025 08:47:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHoGhlhqAsRd7FLdO2RuC2rvg878fg65NRperhyRrGPH5/dQ5/RvGkjMuZ5fanPWoPvWT1aYw== X-Received: by 2002:a05:620a:4152:b0:891:a03f:7c76 with SMTP id af79cd13be357-8b6181eab7emr1114484085a.76.1764953250364; Fri, 05 Dec 2025 08:47:30 -0800 (PST) Received: from [10.140.86.114] (87-95-1-57.bb.dnainternet.fi. [87.95.1.57]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37e70621ec7sm16145501fa.41.2025.12.05.08.47.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Dec 2025 08:47:29 -0800 (PST) Message-ID: <75d44bf2-c518-444d-9b15-fca067e25877@oss.qualcomm.com> Date: Fri, 5 Dec 2025 18:47:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] of: factor arguments passed to of_map_id() into a struct To: Vijayanand Jitta , robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, robh@kernel.org, konrad.dybcio@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com, bod@kernel.org, conor+dt@kernel.org, krzk+dt@kernel.org, charan.kalla@oss.qualcomm.com, prakash.gupta@oss.qualcomm.com, vikash.garodia@oss.qualcomm.com Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251204095530.8627-1-vijayanand.jitta@oss.qualcomm.com> <20251204095530.8627-3-vijayanand.jitta@oss.qualcomm.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: <20251204095530.8627-3-vijayanand.jitta@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=HeAZjyE8 c=1 sm=1 tr=0 ts=69330ca4 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=6rJAVqwrXYrlrbcIgKCPAw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=yyg80FiLJEQYT9IT_GYA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDEyMyBTYWx0ZWRfXwQmOrJ7Tgs2h WPVX6Vgyv3fSFLP9sDzwsTtTG76o7bTklLgOz+KN7uli5Rz8F51cvQp6LYanrn9/dejOB2u6DkL aLvxIkOA8Xm2N/tMEsF1jNPTEHLbbx7KgvjU2X7kG4RSQaQUFo+8Wd7nnRMYvcb1NjsCm7L0kLU OnpMS3o/8y55pZ8anE8PYLs4ybhop1Jm/VwyPIm4xvs9errCiiIl0vD8s744O2bz8LOUj9Y0sWs TnDI/bKxzL23nrBlYV9Uckbvc5q8oKBAWafIfD1+L7Ths5DO0m/PSZI1TXOj2IPsLUFSFGZUYZf ucY83CVszMw3fWnNjdUHuwavILBhBU/mRD9YQ3fdoVTgZEpu48oY4uK9b/dGFGNTsh9IdWFKEWf /TgdQ978edymYkj/+UFHVLQPLhpeCA== X-Proofpoint-ORIG-GUID: X6g4cMB7fYsf87xPY2HVqg0zJLBnDGxy X-Proofpoint-GUID: X6g4cMB7fYsf87xPY2HVqg0zJLBnDGxy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_06,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 suspectscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050123 On 04/12/2025 11:55, Vijayanand Jitta wrote: > From: Charan Teja Kalla > > Introduce a new struct type where the optional arguments passed to > of_map_id() are in struct. Subsequent patches add additional arguments > to the struct that the caller expects to be filled of_map_id(). Why do we need a separate struct? Can't we use of_phandle_args instead? > > Signed-off-by: Charan Teja Kalla > Signed-off-by: Vijayanand Jitta > --- > drivers/iommu/of_iommu.c | 6 +++++- > drivers/of/base.c | 31 ++++++++++++++------------- > drivers/pci/controller/dwc/pci-imx6.c | 6 +++++- > drivers/pci/controller/pcie-apple.c | 5 ++++- > drivers/xen/grant-dma-ops.c | 5 ++++- > include/linux/of.h | 23 ++++++++++++++------ > 6 files changed, 50 insertions(+), 26 deletions(-) > -- With best wishes Dmitry