From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E717A3164CB for ; Fri, 7 Nov 2025 09:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762506363; cv=none; b=TYdb/Rpdh1jIGjQpX6OSlxB+zgfYIukoEyvO5tyt2r40/TPfaE4zC5lRB8hYtWunGPugGPTiz8KHt4VdwT/NiEKI6TCm0p5q81KJAKQdYNRJAcAaiLCZ6oVNrpyfQHP/x4GOEXVx05Tm/KleJHKUi5KQdUJUa6L+kUIN0q2FARM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762506363; c=relaxed/simple; bh=lCNEOWLT+7/XeDg1YbyCpFzIANEFWFgCWrikEPbPsGM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AbufW71a0Yqg+AP48f750L/d3svtUN95a7qvguOhQZ3I+nj7YRuQky7ILSi+1jmIApAZDziMmRHeY16Z4MkDGHhWR09NBqYcW4q0wQ9GGZR3mWii9uEyReCDddjiJ6vVGuBdvX5rQhTFbLCmVvTfdcIqt12+pDn9rIVBTkujgV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cJaDXBbt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CBdb7nwY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cJaDXBbt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CBdb7nwY" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A76pcW0629578 for ; Fri, 7 Nov 2025 09:05:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cn/9gp5o7cY90sjFMFqcqEPElzL9CFdH/lnBGbpOTmk=; b=cJaDXBbthCESDqZh nWtyVe0UgJ2Qh8b58GU7o33f/sE9RcO0l9Ixle7vKS9ixhpf5owMOeadT02Vg8wv EoRQx19nV8OVQAwv9DPPynMQa1LdUEZlf3rbFi9VieFQF3JOMVC34NGhl6I0orAv e/L8LW9G3zHaP/DC7Bfze+olz4yV9oCjAFKHl84yb6BbfGwei9h91unfZOeTe0vR bA2j9S0kWpNv2JY/D/QvaufkJgdlAJItf3ryaK8P4Mkaxxh3OV4ZD1/q8Dqe3SUg NsXGrgPR1VH2vX9lZkgfWptwESVlFWOxxgtellkROTY3neJ8T0jYfkVDllrPgl4K twFddw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a9223201j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Nov 2025 09:05:58 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b55443b4110so520275a12.1 for ; Fri, 07 Nov 2025 01:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762506356; x=1763111156; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cn/9gp5o7cY90sjFMFqcqEPElzL9CFdH/lnBGbpOTmk=; b=CBdb7nwYh+yBYcvn9igfN68+s+0xzZ+Tstr8M7v4K0Nd8E/9VdT4hecSuvcqFpnsQg oRRwIpcq3Q7URUO5yKv6HS4+WVpaGBx0p2BFNG3cK1Z02Vz3YreiVysnjJoOyL5hGoXH +9ESAP26IjkqcFa6ZGD5Y2AnU9lkm/4KJLqmOp6bH0bLzrTkYVMvS2e1Xilp5VrZVpZ5 1OcB91BtwCKuW/Fq9KLBhOBuLHwF6/KUNwRV48Ahyeiqp15867ZQKkLyvbU8XYHLejSE tO6E2cVt1WJwUs536IMVuQfJwLMmbK788vwAW1lWuaKyL/oaIIbcSJrBhioa9AJ72KBt XglA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762506356; x=1763111156; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cn/9gp5o7cY90sjFMFqcqEPElzL9CFdH/lnBGbpOTmk=; b=oC1qcyxbvyLXBnwAOe0mPSmxgPoBtmjJWdpJR3JYwPcwrdTr/NTwVrYl+1PeYWci6x Vv0JjsWc3wEtY36+NmL0BjIHPinFppVtI1aLCURCesygpDB2q0P414OiIki2RWgJjjOc 4WM9sMhk7SM90g0VI6MdjWbh9F+1phpg+1sGzwLcorNmu4h/T2NMZJZYtldt9w8ty2Ed tYJjTSI8pfijaJx8RAHGT3rAFjoLJbUs2cGFNL3hjf9GfeNSh6gyBOh5KKHgxFlRYLBN GWJzhO9oPtPG0TuCnmqCRit6zid1QzlqR0c6jkv8Yv9YI5WjLDF83asQ0/tuEPaCm04V QY1A== X-Forwarded-Encrypted: i=1; AJvYcCXuDeMoV0YjSGEx5RymUQXbfyKZZvVd/UKp2wrm/KhccGbwrCmR/6N7kHACXkAFRZUT3G8tDht5ZbYwXrk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw85Rs9lIBmc/sFPz7YO+e3iNAXqqiQXA+dbUOnK9qBYw3PGSro IcvH9NoTnjF6FX1RWrKgXel5y4Gkj95VAJpIAP7QMeqcGr+c41HRuwJpqQ58ApnyaBfdB76WAyn m2QFHBoxajoBEqOFw7Fs3bG0i+OIoqIGI58e95H+MAzuBaeHAhT33YTywrDC4nkXa184= X-Gm-Gg: ASbGncuJOeGdkD1c4qkQnBwQx5LmjAA4dqH5vun+9jWyr7LEpdvelI+mr/avGmXmst/ 88Z6e+nhp56H3bMVroZBYlI/1ttcPT6dPvmnRgELXHBHPOWMhrRz7KNi7fceiypc58aPPyLRL86 ct0VPcQOF0zfeiUmhNJQ3NiUE6z5T9ettYhlLgGpbYUbuMsy/pcavXt1zNyTFm/WWT8lPjrER+x SpbSaOLUyVMznQGsSGR5hANcyFLRnsX5JUxvb5I8YgqeEOUB9cbX7b2+LPI2t3I1czpYfEXwoUX 5QyqJktYIuqgaRJDdD42yuO2bpuBAdMnYdVJHeDu3DbguJwsi689Vve5u1/huq+AjeiM2rPuZf1 1+h0vcMbWdRvOnnSKwRr9A4gzPdKn/3w= X-Received: by 2002:a05:6a21:328e:b0:334:a854:64a7 with SMTP id adf61e73a8af0-352b5f0904cmr1608554637.3.1762506356438; Fri, 07 Nov 2025 01:05:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFcUtnP5yaDtpiYGU+yKvPAjbntPIIVLxWawJk98uJOABN63v9LKaz2/ekuR0+CKD0lsWt6yg== X-Received: by 2002:a05:6a21:328e:b0:334:a854:64a7 with SMTP id adf61e73a8af0-352b5f0904cmr1608521637.3.1762506355877; Fri, 07 Nov 2025 01:05:55 -0800 (PST) Received: from [10.0.0.3] ([106.222.229.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b0cd05d17asm2241017b3a.72.2025.11.07.01.05.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Nov 2025 01:05:55 -0800 (PST) Message-ID: <75d84de1-4f7c-1397-d445-42a367985991@oss.qualcomm.com> Date: Fri, 7 Nov 2025 14:35:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 6/6] media: qcom: iris: Add intra refresh support for encoder Content-Language: en-US To: Wangao Wang , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , quic_qiweil@quicinc.com, quic_renjiang@quicinc.com References: <20251106-iris_encoder_enhancements-v4-0-5d6cff963f1b@oss.qualcomm.com> <20251106-iris_encoder_enhancements-v4-6-5d6cff963f1b@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20251106-iris_encoder_enhancements-v4-6-5d6cff963f1b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA3MDA3MiBTYWx0ZWRfX9vbEet3sgbvs 18ut23NO7n2ItIKiP48VGAJC3k5wewb1f/cKFt+C8BKmktaK6ACXLJM6XT58Bigd0DS/Y14hvwq 6nAoLWYLPZPRbo7sb2aE/AHSUj2D1TJ+qH29Qv6fbcMZgdbRIHtqZrc94ZlOCGXruRHfBooOyax FJkSxatgCz4bTbYhbM6vXiyED/FdC1AaAsMVdEC0okHfI9JFg5hU0Uq+dWg6OnRX022Rm9nWK0v /elMC4CdnnKv30u/ijSCZn/0tkVTBgnlwOH83HKZc7BMeC96DH+XKIrSd1cVy40ZHUP3n+Ym97u Jid5KnzwXdnFPZ9mlM3VwfRzWsG3H5oIi3Y9TXzDv/j0L8CChSa9ovfn1Mcdlf9VGh39BfDLGAK /PPGc3USPSjURABFXYqhUhJ1G95EvA== X-Authority-Analysis: v=2.4 cv=Csmys34D c=1 sm=1 tr=0 ts=690db676 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=L4UNg9I9cQSOxNpRiiGXlA==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=jOerO3nEycnuB6UvFdUA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: o7mXSkIP8farJ9j9swX6cW_hzNedjLMj X-Proofpoint-ORIG-GUID: o7mXSkIP8farJ9j9swX6cW_hzNedjLMj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-07_02,2025-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511070072 On 11/6/2025 9:00 AM, Wangao Wang wrote: > Add support for V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD and > V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE controls. > > Tested-by: Neil Armstrong # on SM8650-HDK > Signed-off-by: Wangao Wang > --- > drivers/media/platform/qcom/iris/iris_ctrls.c | 33 ++++++++++++++++++++++ > drivers/media/platform/qcom/iris/iris_ctrls.h | 1 + > .../platform/qcom/iris/iris_hfi_gen2_defines.h | 2 ++ > .../platform/qcom/iris/iris_platform_common.h | 2 ++ > .../media/platform/qcom/iris/iris_platform_gen2.c | 19 +++++++++++++ > 5 files changed, 57 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c > index 8f74c12f2f41f23d75424819c707aff61ea61b33..14891569247318aaa7b2009b737f077d1cb45095 100644 > --- a/drivers/media/platform/qcom/iris/iris_ctrls.c > +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c > @@ -104,6 +104,10 @@ static enum platform_inst_fw_cap_type iris_get_cap_id(u32 id) > return HFLIP; > case V4L2_CID_VFLIP: > return VFLIP; > + case V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE: > + return IR_TYPE; > + case V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD: > + return IR_PERIOD; > default: > return INST_FW_CAP_MAX; > } > @@ -197,6 +201,10 @@ static u32 iris_get_v4l2_id(enum platform_inst_fw_cap_type cap_id) > return V4L2_CID_HFLIP; > case VFLIP: > return V4L2_CID_VFLIP; > + case IR_TYPE: > + return V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE; > + case IR_PERIOD: > + return V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD; > default: > return 0; > } > @@ -944,6 +952,31 @@ int iris_set_flip(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id) > &hfi_val, sizeof(u32)); > } > > +int iris_set_ir_period(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id) > +{ > + const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops; > + struct vb2_queue *q = v4l2_m2m_get_dst_vq(inst->m2m_ctx); > + u32 ir_period = inst->fw_caps[cap_id].value; > + u32 ir_type = 0; > + > + if (inst->fw_caps[IR_TYPE].value == > + V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_RANDOM) { > + if (vb2_is_streaming(q)) > + return 0; > + ir_type = HFI_PROP_IR_RANDOM_PERIOD; > + } else if (inst->fw_caps[IR_TYPE].value == > + V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_CYCLIC) { > + ir_type = HFI_PROP_IR_CYCLIC_PERIOD; > + } else > + return -EINVAL; missing braces. with that fixed, Reviewed-by: Dikshita Agarwal Thanks, Dikshita > + > + return hfi_ops->session_set_property(inst, ir_type, > + HFI_HOST_FLAGS_NONE, > + iris_get_port_info(inst, cap_id), > + HFI_PAYLOAD_U32, > + &ir_period, sizeof(u32)); > +} > + > int iris_set_properties(struct iris_inst *inst, u32 plane) > { > const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops; > diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.h b/drivers/media/platform/qcom/iris/iris_ctrls.h > index 355a592049f3fcc715a1b9df44b4d1398b052653..9518803577bc39f5c1339a49878dd0c3e8f510ad 100644 > --- a/drivers/media/platform/qcom/iris/iris_ctrls.h > +++ b/drivers/media/platform/qcom/iris/iris_ctrls.h > @@ -34,6 +34,7 @@ int iris_set_frame_qp(struct iris_inst *inst, enum platform_inst_fw_cap_type cap > int iris_set_qp_range(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); > int iris_set_rotation(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); > int iris_set_flip(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); > +int iris_set_ir_period(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); > int iris_set_properties(struct iris_inst *inst, u32 plane); > > #endif > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h > index 0f92468dca91cbb2ca9b451ebce255180066b3a4..9e8fdddf2aef439e7f133c9bb2fafa6d95062b02 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h > @@ -70,6 +70,7 @@ enum hfi_rate_control { > #define HFI_PROP_QP_PACKED 0x0300012e > #define HFI_PROP_MIN_QP_PACKED 0x0300012f > #define HFI_PROP_MAX_QP_PACKED 0x03000130 > +#define HFI_PROP_IR_RANDOM_PERIOD 0x03000131 > #define HFI_PROP_TOTAL_BITRATE 0x0300013b > #define HFI_PROP_MAX_GOP_FRAMES 0x03000146 > #define HFI_PROP_MAX_B_FRAMES 0x03000147 > @@ -108,6 +109,7 @@ enum hfi_flip { > #define HFI_PROP_BUFFER_MARK 0x0300016c > #define HFI_PROP_RAW_RESOLUTION 0x03000178 > #define HFI_PROP_TOTAL_PEAK_BITRATE 0x0300017C > +#define HFI_PROP_IR_CYCLIC_PERIOD 0x0300017E > #define HFI_PROP_COMV_BUFFER_COUNT 0x03000193 > #define HFI_PROP_END 0x03FFFFFF > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index 284d6bde6d6bcdf70016646d1c92e6ae7f067efc..30b98e769ad34c2b63dd63e7714bfeaa5b4f162c 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -143,6 +143,8 @@ enum platform_inst_fw_cap_type { > ROTATION, > HFLIP, > VFLIP, > + IR_TYPE, > + IR_PERIOD, > INST_FW_CAP_MAX, > }; > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > index e74bdd00a4bb2f457ec9352e0acaebc820dae235..ce54aac766e2bf76fa2de64c884724ca63f05dcb 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > @@ -620,6 +620,25 @@ static struct platform_inst_fw_cap inst_fw_cap_sm8550_enc[] = { > CAP_FLAG_DYNAMIC_ALLOWED, > .set = iris_set_flip, > }, > + { > + .cap_id = IR_TYPE, > + .min = V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_RANDOM, > + .max = V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_CYCLIC, > + .step_or_mask = BIT(V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_RANDOM) | > + BIT(V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_CYCLIC), > + .value = V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_RANDOM, > + .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU, > + }, > + { > + .cap_id = IR_PERIOD, > + .min = 0, > + .max = INT_MAX, > + .step_or_mask = 1, > + .value = 0, > + .flags = CAP_FLAG_OUTPUT_PORT | > + CAP_FLAG_DYNAMIC_ALLOWED, > + .set = iris_set_ir_period, > + }, > }; > > static struct platform_inst_caps platform_inst_cap_sm8550 = { >