From: Markus Elfring <Markus.Elfring@web.de>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH] media: sun8i: Fix an error handling path in deinterlace_runtime_resume()
Date: Tue, 5 May 2020 10:15:05 +0200 [thread overview]
Message-ID: <75dd05b8-7895-e1cf-2c76-2327aa11f033@web.de> (raw)
> It is spurious to call 'clk_disable_unprepare()' when
> 'clk_prepare_enable()' has not been called yet.
Can it be that the usage of the word “suspicious” would be more appropriate
for such a change description?
> Re-order the error handling path to avoid it.
Would it be also helpful to explicitly mention in the commit message
that you would like to move a call of the function “clk_rate_exclusive_put”
to the end of this function implementation for the correction
of the desired exception handling?
Regards,
Markus
next reply other threads:[~2020-05-05 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 8:15 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-05 7:50 [PATCH] media: sun8i: Fix an error handling path in 'deinterlace_runtime_resume()' Christophe JAILLET
2020-05-05 7:52 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75dd05b8-7895-e1cf-2c76-2327aa11f033@web.de \
--to=markus.elfring@web.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@siol.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®