From: James Clark <james.clark@linaro.org>
To: Leo Yan <leo.yan@arm.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@arm.com>,
Yeoreum Yun <yeoreum.yun@arm.com>,
coresight@lists.linaro.org, linux-kernel@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH 1/9] coresight: cpu-debug: Fix PM usage counter leak in debug_enable_func()
Date: Wed, 28 Oct 2026 09:16:02 +0000 [thread overview]
Message-ID: <75e0cdca-4bcf-443f-924d-c6397d616ad5@linaro.org> (raw)
In-Reply-To: <20261027180805.GA9176@e132581.arm.com>
On 27/10/2026 18:08, Leo Yan wrote:
> On Tue, Oct 27, 2026 at 02:55:47PM +0000, James Clark wrote:
>> pm_runtime_get_sync() increments the usage counter even when it fails,
>> but the failing CPU isn't added to the rollback mask, so its reference
>> is never dropped. Use pm_runtime_resume_and_get() which drops the
>> reference itself on failure.
>>
>> Fixes: 2227b7c74634 ("coresight: add support for CPU debug module")
>> Reported-by: Sashiko <sashiko-bot@kernel.org>
>> Closes: https://sashiko.dev/#/bug/linux-2ff60e6d-33ac-4a69-9c62-63eb482f1913
>> Signed-off-by: James Clark <james.clark@linaro.org>
>
> This duplicates with:
> https://lore.kernel.org/linux-arm-kernel/20260911-b4-coresight-runtime-pm-failures-v1-1-acdf49756e11@qti.qualcomm.com/#r
>
> I'd prefer to pick up that patch, as it has fixed all drivers in the
> CoreSight directory.
>
> Thanks,
> Leo
Yep we should drop this one
next prev parent reply other threads:[~2026-10-28 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 14:55 [PATCH 0/9] coresight: Fix assorted bugs reported by Sashiko James Clark
2026-10-27 14:55 ` [PATCH 1/9] coresight: cpu-debug: Fix PM usage counter leak in debug_enable_func() James Clark
2026-10-27 18:08 ` Leo Yan
2026-10-28 9:16 ` James Clark [this message]
2026-10-27 14:55 ` [PATCH 2/9] coresight: etm4x: Remove perf symlink if config registration fails James Clark
2026-10-27 14:55 ` [PATCH 3/9] coresight: etm4x: Fix truncation of nr_ext_inp James Clark
2026-10-27 14:55 ` [PATCH 4/9] coresight: etm-perf: Fix sink device reference leak in etm_setup_aux() James Clark
2026-10-27 14:55 ` [PATCH 5/9] coresight: syscfg: Take csdev lock when removing owned features James Clark
2026-10-27 14:55 ` [PATCH 6/9] coresight: syscfg: Fix deadlock in cscfg_create_device() error path James Clark
2026-10-27 14:55 ` [PATCH 7/9] coresight: Fix resource leaks on coresight_build_path() errors James Clark
2026-10-27 14:55 ` [PATCH 8/9] coresight: etm3x: Don't ignore etm_parse_event_config() errors James Clark
2026-10-27 14:55 ` [PATCH 9/9] coresight: etm3x: Prohibit modifying seq_curr_state while session is enabled James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75e0cdca-4bcf-443f-924d-c6397d616ad5@linaro.org \
--to=james.clark@linaro.org \
--cc=coresight@lists.linaro.org \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@arm.com \
--cc=sashiko-bot@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®