From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933795AbcIOLs1 (ORCPT ); Thu, 15 Sep 2016 07:48:27 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:65242 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756385AbcIOLsW (ORCPT ); Thu, 15 Sep 2016 07:48:22 -0400 X-AuditID: cbfec7f1-f79f46d0000008eb-37-57da8a827e4e Subject: Re: [PATCH] leds: Only remove trigger if one is actually configured. To: Daniel Romell , rpurdie@rpsys.net Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Romell From: Jacek Anaszewski Message-id: <75e5d60e-39e4-574f-5417-7532f1f19f1f@samsung.com> Date: Thu, 15 Sep 2016 13:48:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1473844987-21112-1-git-send-email-daro@hms.se> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42LZduzned2mrlvhBpfWiVo8X9bLZHGk+TuL xeVdc9gstr5Zx2ixe9dTVgdWj52z7rJ79Dw+wO6xZ/4PVo/Pm+QCWKK4bFJSczLLUov07RK4 Mu4e/cFasImj4sa7g4wNjA3sXYycHBICJhIPPm5ihLDFJC7cW8/WxcjFISSwlFFi1737zBDO Z0aJ5fc/MsF09PceZIRILGOU6H41mwnCecYo8fT4BLC5wgL+Enc3LgTrEBGwldj9+gUziM0s EC3Rcng+WJxNwFDi54vXYDavgJ3E//f32EBsFgFViUt7FrN2MXJwiApESOy+mwpRIijxY/I9 FpAwp4CNRP9SY4iJjhIPFu1khbDlJTaveQt2tIRAP7vE6YnbwMZICMhKbDrADHG/i8Td5tks ELawxKvjW6AhISNxeXI3C0TvZEaJi8duskI4qxklNnZ2QnVYSzT8/8UCsY1PYtK26cwQC3gl OtqEIEo8JBo7J0GFHSWOzxCFBE8/o8TCCdMZJzDKz0LyziwkP8xC8sMCRuZVjCKppcW56anF RnrFibnFpXnpesn5uZsYgQnj9L/jH3cwvj9hdYhRgINRiYe3we9muBBrYllxZe4hRgkOZiUR 3r2tt8KFeFMSK6tSi/Lji0pzUosPMUpzsCiJ8+5ZcCVcSCA9sSQ1OzW1ILUIJsvEwSnVwHhS JmFRx/2whGl1N5oKj35iPWv6Xe96j38qi2XhrxW2e9c8FnjB8Xj2Nr5Wba4bT8+9yZnylCNw l+6M3ZL70nbtWVn6d67OSal7Dr+7XrhX1ki+fJM0444up+K+ON1z3hfV7902tf9embHQJ8U3 1Eq90GbGl8xbP/foeX64cX2fyUXlpcZbZz1SYinOSDTUYi4qTgQAuHGQ+xQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t/xK7pBXbfCDTrnMFo8X9bLZHGk+TuL xeVdc9gstr5Zx2ixe9dTVgdWj52z7rJ79Dw+wO6xZ/4PVo/Pm+QCWKLcbDJSE1NSixRS85Lz UzLz0m2VQkPcdC2UFPISc1NtlSJ0fUOClBTKEnNKgTwjAzTg4BzgHqykb5fglnH36A/Wgk0c FTfeHWRsYGxg72Lk5JAQMJHo7z3ICGGLSVy4t56ti5GLQ0hgCaPEtAWfmSGcZ4wSvWs3soBU CQv4Smz9PQGsW0TAVmL36xdQRRMZJRZ++gCWYBaIlvi29iwziM0mYCjx88VrJhCbV8BO4v/7 e2wgNouAqsSlPYtZQWxRgQiJW6s+MkLUCEr8mHwPaBkHB6eAjUT/UmOIkbYSC96vY4Gw5SU2 r3nLPIFRYBaSjllIymYhKVvAyLyKUSS1tDg3PbfYSK84Mbe4NC9dLzk/dxMjMH62Hfu5ZQdj 17vgQ4wCHIxKPLwNfjfDhVgTy4orcw8xSnAwK4nw7m29FS7Em5JYWZValB9fVJqTWnyI0RTo h4nMUqLJ+cDYziuJNzQxNLc0NDK2sDA3MlIS55364Uq4kEB6YklqdmpqQWoRTB8TB6dUAyNT 8YOIzx+PsCpsWfHqp/cb7x8fHs9eYVpxw9ljsQCz3rNTm2TPexYVFK+xv2DteSdW4N++LVml qZMTXvyeeuur2kUWR7srzakt67culJvxPN1G947qqU07D+de2rzU69aSeesXTz7FmWpd/b1i sWB7QEq6QOfHHzrXIjY//rKI75j51Z9Pu91eKLEUZyQaajEXFScCADVZ8Tq1AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160915114817eucas1p2c8091dfb1b081542cba669d0e3b56676 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160914092340eucas1p27f875a415de6684be5b09872ab1b9ab6 X-RootMTR: 20160914092340eucas1p27f875a415de6684be5b09872ab1b9ab6 References: <1473844987-21112-1-git-send-email-daro@hms.se> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On 09/14/2016 11:23 AM, Daniel Romell wrote: > In led_trigger_remove(), check if there is a trigger > configured before calling led_trigger_set(). This will > prevent some unnecessary work, and more importantly stop > sending uevent change events when no change has in fact > occurred. > > Signed-off-by: Daniel Romell > --- > drivers/leds/led-triggers.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c > index 59d6a3e..28c7a66 100644 > --- a/drivers/leds/led-triggers.c > +++ b/drivers/leds/led-triggers.c > @@ -147,7 +147,8 @@ EXPORT_SYMBOL_GPL(led_trigger_set); > void led_trigger_remove(struct led_classdev *led_cdev) > { > down_write(&led_cdev->trigger_lock); > - led_trigger_set(led_cdev, NULL); > + if (led_cdev->trigger) > + led_trigger_set(led_cdev, NULL); > up_write(&led_cdev->trigger_lock); > } > EXPORT_SYMBOL_GPL(led_trigger_remove); > Thanks for the patch. Applied. -- Best regards, Jacek Anaszewski