From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E74AF42314F for ; Fri, 31 Jul 2026 10:53:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495211; cv=none; b=c35UzGnnBiBNvfTTTDMnsAM/FzBWyWGTnmzcrAPzme/+EP198g8JjPm7lIrN9zAh+qtZnd+UqXwT86hdDBrcXtH2Uqj5Fnu6dL5RQGYgw4bYdBb65kB4zDVDbR9dNXZE2ANplAcnG6g8c/1eoCiNc0GTbYuc4GJG61nWv1o+Md8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495211; c=relaxed/simple; bh=Y1EfwtiHUODx8PMUP+n5wH2+wc9O5+Vm9OiuvE6+yEU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZCGMXKgHqymBmz0Av7yY3J9yylV1m/eRJhERCJ9h4BvroL85/rIDNuzYV8OLnWFYgkGfqXJjXiMNnHHSCQL+1zosgvJiv9s6eFoRKrhtwOfATgSQj8eYrlZwdqsgMTQ7JAEOIwGs5mknE+6YVr2Qi9Q5ng+BNrvOxSXa3mO1Mhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hScdfrmT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EAWN6Zvi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hScdfrmT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EAWN6Zvi" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VAaTU4044347 for ; Fri, 31 Jul 2026 10:53:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sW7EvOLBbmSFxEjiNbpRIF/D92msbj+jLsBeHsdaL34=; b=hScdfrmT6C0TWdmD pTW7JJV8J3boD/a4FvDYV8qmg/YmHTi4KeFw4I9XrXxtzak7bLiGTNSWVt5GXuiU oHajI6Oy1UwrCuK/pLHXleih9FzrUgaI5WjT8dPSifDj510k2DTZGI40vc9jeHPc wdxQ1SrIkvL9D1gXkjNWflbVWjaseSyTnDE/qYZSubKQgmfSHJmBai3jbRCJX95P rp6H7SwKmIdV2I3c2nW6HUpGXmBs2/WSgThaBIZHQ005nP+LcdKdF2XPJws4oyRs x0CZh68tZ6I/Zzy6uJdZEsg0/YZakxraLyTkXdyNGZDRObLcQMh3uEV+9bOyMTm0 nLLrbg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frt3t01wn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 10:53:20 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51e9d892f0dso2517411cf.2 for ; Fri, 31 Jul 2026 03:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785495200; x=1786100000; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sW7EvOLBbmSFxEjiNbpRIF/D92msbj+jLsBeHsdaL34=; b=EAWN6Zvio6bOUNaaJvzOQbtXVwkgDPmpvJi1IqU+892SeD8pjjxRGfygi88muuzRNH ueKfGacbXfvMR47tqMKO653oHcGcsy+gMAYX6Cnwo9Y+0I65FWulPAoJbCa+EEyJQDFk 9hRK32xQZYmZoGid1SlJWDN5643fMyBbdpY6/ca7kd3IqPCoRxRMezj8Wj3+i61W8vyZ xfEMn9oxWFL6elBsnWKeJ1nA68sfZwfNO8uk3UoEvuZ5BW9t4SOpFMVH0plpy2xoswPI XBaIxNEUJB9X82HuU98XEL4qlZkpQ/d2BJQPgXh2am9UvwR8QWcy6GRnfOYdJ4gyVYYe 7HKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785495200; x=1786100000; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sW7EvOLBbmSFxEjiNbpRIF/D92msbj+jLsBeHsdaL34=; b=jN2VI163ewCCwGW8RnlMvDiSboX7XNkgaGKFBMRPs6jhe6ytkkBjPYBb/JsWpYNPVt glKwpG+Qi2p6EM4mR3coit4U86ZzT4xHVARdvz2fxeBGGiaGztZxJJnSw0LpIUKQWcZ5 iNj/rzEyifOSNY68FXC7wg7zVbwd5a7gPJql6r9wbmS7KO0iQyJMdPjryaeV864vyu3y XWzUbCJ8WvkhDGOEvWpc5Df8sQwQogBU/kc70AeSICrlAxQ0FQPn10v1Ew059j/mlGT+ TLLoae0gKZX+AwYUm0wLh+FfE/38v7vZgDrcbl3KGEl+7p18Vg955DtyU7faK0ZcwZpx 016g== X-Forwarded-Encrypted: i=1; AHgh+Rp+ALGy4rm4zSmheUb6uvE+umy5sPFDPiXGdsWCCMuYylHdWjWtjN107DuikvJiJ6zn+f0n3pcTzA8n12w=@vger.kernel.org X-Gm-Message-State: AOJu0YwC0i+tLOd5HWWeX2xHLqNKptu0+4RFRz7t+KKLN0o6Qy1otQQ5 mOJpx1C1H/BueD38suL5wVtKA+IQwH/EDabCkpBCtcFbwj2WP+NEfGro7nHuUmAEqH/7m97YXg3 0/oQoXR2rMbr9Cvr1NqWHZJWlHHpyihwdngo2G9MiDZmtMbIafoEBk3xKSrUKxSL6fWo= X-Gm-Gg: AR+sD11lcUpk4tQBb8aXN1mVaL/RdLwViIgylgRw2U7bGqIGEnRCZxCQMLYADjas61m Nox9hTydqIkulNlrqeBCMNInqIPbrnudANa+wJtA6kZX48iZqj2aQ+4RheIVarumLMyk6qDlNju GObrzubpkCxOqK4KOuVG1V2kb0gHY6OXmVc/8Pkm22EJX5e196EMt/uVTn6YxG9+n/HB3dx57lg 0kGY9c9Zt7RaqUBKNj3PNkb1bHMvVkZ+7fcCy8GlqVWe9rSYK8KHayfrH84+sz4EGy2NX2Ap5uF VBEKxG5tScWO/JlIWWqtg2wk5YfAUIwOUN+DlrCYQjxCnm3z16f9J6Jg1HJC56kmMEyDPu+bCHB dnad3diu2dBbkBUK/+p7jxkjg X-Received: by 2002:a05:620a:27ce:b0:931:10e:befe with SMTP id af79cd13be357-934963bf7fbmr167092785a.0.1785495199669; Fri, 31 Jul 2026 03:53:19 -0700 (PDT) X-Received: by 2002:a05:620a:27ce:b0:931:10e:befe with SMTP id af79cd13be357-934963bf7fbmr167090385a.0.1785495199175; Fri, 31 Jul 2026 03:53:19 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd44542ddsm118014166b.29.2026.07.31.03.53.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 03:53:18 -0700 (PDT) Message-ID: <75ea8be5-9426-4fed-a29e-654aac4f2617@oss.qualcomm.com> Date: Fri, 31 Jul 2026 12:53:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] usb: xhci: Honor PORTSC.TM if valid To: Mathias Nyman , Thinh Nguyen , Konrad Dybcio Cc: Greg Kroah-Hartman , Mathias Nyman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "usb4-upstream@oss.qualcomm.com" , Raghavendra Thoorpu , Mika Westerberg References: <20260715-topic-dwc3_tunneling_state-v2-0-026487a08119@oss.qualcomm.com> <20260715-topic-dwc3_tunneling_state-v2-2-026487a08119@oss.qualcomm.com> <2baa405c-5f9c-487a-8969-82d697e8cb1e@oss.qualcomm.com> <30a8cabf-44db-4023-9b1e-58d7b261bb4e@linux.intel.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <30a8cabf-44db-4023-9b1e-58d7b261bb4e@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=dNKWXuZb c=1 sm=1 tr=0 ts=6a6c7ea0 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=EiazGOhZt8YqlqeVitwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: k39PZnw6BxEmbNfI-w13oceBRqFYkPHP X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDA4MiBTYWx0ZWRfX+pdQx7YFTgm3 bOOnphvNNhBNz8cyXQQ9garUkRsKF3Uj/LdUButG+ej3slyUDH3BRS594SxGvBvQUL7yct9/xdq Z5Q6qvT4ekaxqPiZ196Ocze8cybhtgg= X-Proofpoint-ORIG-GUID: k39PZnw6BxEmbNfI-w13oceBRqFYkPHP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDA4MiBTYWx0ZWRfXwW30+F/GSKL7 imCvE0GNmv3AzCxRWicOeuHzHOzeDX8U+qOZu9bNb35rjVJ/+BekQxDJmKYQWoq9x6YxtQeZPFa YLpnSTstk53zrBux+6IbSRms2xrnqnLxULcK78liv1IMzTOreyiE6kWRAPKT0lEvI+8Y6cwEWqt 7vuCnq8McmvBDkrYsZ+A5Gai0738AAJRfHzY4NVkGHYWZf8Ftf8Wp/BZ5+YyzIxJslUkcHYkymE Mpp4umeqGLfdOHEfyxghwcfwdVB9XwVcHYucCEUXnETzLwFJEgGcyX4PkR1ztqKZNDthF3Jhyan SuHTaajB2VXVtLAptovqDk7H4Wyvom/Bdl3r45NZFseQoJIHaH2soGM0GqeK+TtWoT7wrq1JUvQ 3TyoeQMVZTA4pYVhUXLXytxpJu/FXKgwtrTDs+56NxP8726YWfFpnAj8KHSJgX1zv3TOHJhCbfX 1pjwp5eiAvwlkUSqOIg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_03,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 bulkscore=0 spamscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310082 On 7/31/26 12:34 PM, Mathias Nyman wrote: > On 7/28/26 11:44, Konrad Dybcio wrote: >> On 7/23/26 12:57 AM, Thinh Nguyen wrote: >>> On Wed, Jul 15, 2026, Konrad Dybcio wrote: >>>> From: Konrad Dybcio >>>> >>>> Currently, the only way for the USB core to determine whether the link >>>> is native or tunneled is via an Intel vendor-specific Extended >>>> Capability. >> >> [...] >> >>>> -    /* Don't try and probe this capability for non-Intel hosts */ >>>> +    /* Prefer the XHCI v1.2 ext_cap if advertised */ >>>> +    offset = xhci_find_next_ext_cap(base, 0, XHCI_EXT_CAPS_USB3_TUNNELING); >>>> +    if (offset) { >>>> +        if (!(readl(base + offset) & XHCI_USB3_TUNNELING_SUPPORTED)) >>>> +            return USB_LINK_NATIVE; >>> >>> Second, don't return early here. Check if XHCI_EXT_CAPS_USB3_TUNNELING >>> present and supported: >> >> So if the extcap is supported and exposed, but it says "this port >> is not tunneling-capable", can we not trust that data? > > The extcap 18 bit only states if tunnel mode bit reporting in PORTSC is supported, not if > port is tunnel capable. > > Supporting tunneling and exposing extended capability ID 18, but not reporting tunneling in PORTSC > register would be odd, but due to the phrasing it could be possible. You're right. Konrad