From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAE43C77B7A for ; Tue, 30 May 2023 22:18:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233699AbjE3WSe (ORCPT ); Tue, 30 May 2023 18:18:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233671AbjE3WSa (ORCPT ); Tue, 30 May 2023 18:18:30 -0400 X-Greylist: delayed 3194 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 30 May 2023 15:18:16 PDT Received: from mx11lb.world4you.com (mx11lb.world4you.com [81.19.149.121]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FADB125 for ; Tue, 30 May 2023 15:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=engleder-embedded.com; s=dkim11; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tmK094y96wxnVZkH2WsdAa3vLGfUTZukvcfeq7bEgWM=; b=g2658kAvRw+cmjUJNfxuCNCd4i d9gNNNLErmW8wcGrdqA8ala/MJNOtzhBThzY5NnncEfzZpdlLQTmFuLxJFjskHkF3Xpr1PWicSNvm gPuQNG3iSdGkO/fBG5epBXViCUyzsQmE2JCDMbQSjx74JgEsCNQmYDhkvdKAnI1LDczU=; Received: from [88.117.62.186] (helo=[10.0.0.160]) by mx11lb.world4you.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q46Ia-0002Tp-2o; Tue, 30 May 2023 22:50:32 +0200 Message-ID: <7602e37b-1b83-8697-d9e6-c9cc1e5214e3@engleder-embedded.com> Date: Tue, 30 May 2023 22:50:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH net-next 2/5] net/sched: taprio: replace tc_taprio_qopt_offload :: enable with a "cmd" enum To: Vladimir Oltean , netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Vinicius Costa Gomes , Kurt Kanzenbach , Amritha Nambiar , Ferenc Fejes , Xiaoliang Yang , Roger Quadros , Pranavi Somisetty , Harini Katakam , Giuseppe Cavallaro , Alexandre Torgue , Michael Sit Wei Hong , Mohammad Athari Bin Ismail , Oleksij Rempel , Jacob Keller , linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Jesse Brandeburg , Tony Nguyen , Horatiu Vultur , Jose Abreu , Maxime Coquelin , intel-wired-lan@lists.osuosl.org, Muhammad Husaini Zulkifli References: <20230530091948.1408477-1-vladimir.oltean@nxp.com> <20230530091948.1408477-3-vladimir.oltean@nxp.com> Content-Language: en-US From: Gerhard Engleder In-Reply-To: <20230530091948.1408477-3-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AV-Do-Run: Yes Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.05.23 11:19, Vladimir Oltean wrote: > Inspired from struct flow_cls_offload :: cmd, in order for taprio to be > able to report statistics (which is future work), it seems that we need > to drill one step further with the ndo_setup_tc(TC_SETUP_QDISC_TAPRIO) > multiplexing, and pass the command as part of the common portion of the > muxed structure. > > Since we already have an "enable" variable in tc_taprio_qopt_offload, > refactor all drivers to check for "cmd" instead of "enable", and reject > every other command except "replace" and "destroy" - to be future proof. > > Signed-off-by: Vladimir Oltean > --- > drivers/net/dsa/hirschmann/hellcreek.c | 14 +++++++++----- > drivers/net/dsa/ocelot/felix_vsc9959.c | 4 +++- > drivers/net/dsa/sja1105/sja1105_tas.c | 7 +++++-- > drivers/net/ethernet/engleder/tsnep_selftests.c | 12 ++++++------ > drivers/net/ethernet/engleder/tsnep_tc.c | 4 +++- > drivers/net/ethernet/freescale/enetc/enetc_qos.c | 6 +++++- > drivers/net/ethernet/intel/igc/igc_main.c | 13 +++++++++++-- > .../net/ethernet/microchip/lan966x/lan966x_tc.c | 10 ++++++++-- > drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 7 +++++-- > drivers/net/ethernet/ti/am65-cpsw-qos.c | 11 ++++++++--- > include/net/pkt_sched.h | 7 ++++++- > net/sched/sch_taprio.c | 4 ++-- > 12 files changed, 71 insertions(+), 28 deletions(-) Reviewed-by: Gerhard Engleder