From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C99524023E for ; Mon, 13 Jan 2025 15:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736783024; cv=none; b=YUwk8Ou5bNP3c5winob/7lm2rg46Bg31Wwlwdu0SF1jueeLGY4G5FJpS+q5RIijnZl7GwLhmFokwu4nNep1yck+FltERXCZrS7XmO0eW2a/b0E4liVZsvHIe062WIisF2Hh249XnTFM7MMvL9YN82ZCCmjH3xs5b79WvJ/i9TPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736783024; c=relaxed/simple; bh=gGT5O+5jGSnq3FXOduFRfbgLcgYYNBiLos8tPqRNUJQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KJQeYQoz7ADY1FB+Ahr8XHf+Fflj8HaJMvPvDWz4JSld5KTDA53lzQh49zbAdC8OBJgwYyYsllODhnLSCj1oNFSf9H+ytx9QKgXdsH+PubtqMMJbDlRiab0RbTTjiesweTr2cMVyMeL0H9nvFhs5f4+VAyjNEoVN7fyWCz1X0Uk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wVELQwGe; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wVELQwGe" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43621d27adeso30993655e9.2 for ; Mon, 13 Jan 2025 07:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736783021; x=1737387821; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=onYqQa61OGFyF4QvM2h8YBVOy4czv714EXLgoMhI3Xc=; b=wVELQwGebFxZKhY1Ps4qyGRzvptQSxZGOAPjMlCumAvlWVKGKrJF662Fh7SEOJZI/o phnc7reGSJXa55neqWIdZR7aUwFuqaFUIGyuYzctUFbU9J3MVARz0kynlw0IEYKDB5vL xqpgRMg99Ok58S8gX8avgd6CbGezVGpDQWTk5Orb/ZFH6j2e1TVI4N6PSXAI47kUXllv mFq1VfWZZDEn7Het00Ktjv1QZfBVqs+rCDJONn2WOTvZ2PkGpIoGAibTX6/5s9B3XDjJ 3XnoGsduKgPTf5mg67+TXsO4jXeBsEB6OvGmqJqkOQedLIu9ff4znQzqe2eBZHobbPGg AE1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736783021; x=1737387821; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=onYqQa61OGFyF4QvM2h8YBVOy4czv714EXLgoMhI3Xc=; b=JiRblR81yJg+prWVJsxch8oF8HkA0HVtpy2jQEDLk2gjdgjqJYucp98QaB1qsd+uve BXU5xVCBB5f9gaXFL/vjMe+s9cIMraqhcOyPkwXbUpQadOO5fZ4UQwOioOb5icdEw8MW hG1ZbSdhhnrjHiioNxRAkNR5lpGnqSeDmwLOYSk9/LZjrFfeHdXXY6sa3OycmcwfwUTT 2ShiHksJ+ucQkwhaB0dGdlgCpEv3wJsWNkmSUJZCHrS0ex222EVncoa8Mq/qAD0YFD86 SBF2PeG5Qa1G6wOuBLDvb8UThkizzZGP3OoqWfl9NkxBhWU0fp9sVjbYlPFA7WdEWLdT Is1w== X-Forwarded-Encrypted: i=1; AJvYcCWxlzd4/R1LeMY32oR3WEkJydZR6NhifclJBXpFRqRfoCx+6iwQB4zYX1JG7toThIAJ6fVrAUVfUAJp70s=@vger.kernel.org X-Gm-Message-State: AOJu0Yyz3Mi+IQUSKr7KiJ/BURkxpaAY/sf3uRA8TQ//H4aBWvD/HFOO XMxgG3g+OG+weij5joln9/m0xX533jEb+SUeZq35ykqNBl5G3nfYjtDXEjPywgw= X-Gm-Gg: ASbGncts8YDJh58UFoCzMfOxl7NTazxq4b74QwaIqlldiZElebR9CabVEk5grsAlTHt oAwCgH9ZprJipC4IvAxiHpD2lF/yd6nhA4b4uVVO3FvsZ9yHJ05NoP0eklNx28hIqASFnc6dXnv BSm2wc9wQH7oQUeyMh2BtemDy24vcVuuQyBY56Gjg7K5QXCUesBnTKt08SPiO5ea08xTibaJCI/ siLiDSFbCqddhpIdl0NHwKfh8BWS4IRCREGEI6zfwg6Gf8b3ZrOFwmmT2uBa5vvQXlI X-Google-Smtp-Source: AGHT+IGQr4kpiFB9wczlaOYRTmEvbwC5k8AQlqeQKyaHs7iqTu2Ox0YvNOuXblM8h6c/Pixyirgj0Q== X-Received: by 2002:a05:600c:1c28:b0:434:a734:d268 with SMTP id 5b1f17b1804b1-436e2699dfbmr216122595e9.14.1736783021472; Mon, 13 Jan 2025 07:43:41 -0800 (PST) Received: from [192.168.68.163] ([212.105.145.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2e89f29sm181691685e9.28.2025.01.13.07.43.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 07:43:41 -0800 (PST) Message-ID: <760969b6-18b7-42ac-9524-2f1f845b3703@linaro.org> Date: Mon, 13 Jan 2025 15:43:39 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 04/10] arm64/sysreg: Add a comment that the sysreg file should be sorted To: Marc Zyngier , Mark Brown Cc: kvmarm@lists.linux.dev, oliver.upton@linux.dev, suzuki.poulose@arm.com, coresight@lists.linaro.org, James Clark , Joey Gouly , Zenghui Yu , Catalin Marinas , Will Deacon , Mike Leach , Alexander Shishkin , Mark Rutland , Anshuman Khandual , "Rob Herring (Arm)" , Shiqi Liu , James Morse , Fuad Tabba , Raghavendra Rao Ananta , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250107113252.260631-1-james.clark@linaro.org> <20250107113252.260631-5-james.clark@linaro.org> <87frloqjso.wl-maz@kernel.org> Content-Language: en-US From: James Clark In-Reply-To: <87frloqjso.wl-maz@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/01/2025 12:49 pm, Marc Zyngier wrote: > On Tue, 07 Jan 2025 11:32:41 +0000, > James Clark wrote: >> >> From: James Clark >> >> There are a few entries particularly at the end of the file that aren't >> in order. To avoid confusion, add a comment that might help new entries >> to be added in the right place. >> >> Reviewed-by: Mark Brown >> Signed-off-by: James Clark >> Signed-off-by: James Clark >> --- >> arch/arm64/tools/sysreg | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg >> index b081b54d6d22..4ba167089e2a 100644 >> --- a/arch/arm64/tools/sysreg >> +++ b/arch/arm64/tools/sysreg >> @@ -48,6 +48,8 @@ >> # feature that introduces them (eg, FEAT_LS64_ACCDATA introduces enumeration >> # item ACCDATA) though it may be more taseful to do something else. >> >> +# Please try to keep entries in this file sorted by sysreg encoding. >> + >> Sysreg OSDTRRX_EL1 2 0 0 0 2 >> Res0 63:32 >> Field 31:0 DTRRX > > "Do as I say, don't do as I do". > > I don't think this makes any sense if we don't actually sort the file > the first place. > > M. > I think it's ok if it avoids review comments that new entries should be sorted. Or maybe we do the opposite and the comment should say this file is allowed to be unsorted...