From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 173B5403AF7 for ; Wed, 10 Jun 2026 12:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781096089; cv=none; b=lP/qgrMtQgs3avC3CP85PQ2Vy3HU7jFCujqPYtprkd4G8qVFNRtEwdONnG05mLEqinM3suIVK2wWeaedFw5Qe6etnTeTE/a844yKTv4j70+aTZqy/xwU8Qv+gz+qv6PlzZGhJhXwYms3wR2dUHB/uXGJ/hHpi03ESveb3CEj9VQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781096089; c=relaxed/simple; bh=XXi5LR6g8ALn2Q/eNHTM4xxYk/5IMIVrVFpt+P6u6JI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fMOrRU3fhlcll1ltnxy9DuVkE1Gna6KOFXYZfQfWMBPpZELsIaiJN3aPkyjYc3sy222w4/9TyNCbqvEcepc6V2LVZg7JNNYS5mO2rQyOIcYzA+9Yew3EfCuA7UjLMOp+5vMpPX/ZQAO6DCxHm6A7MZk7SJLISyFoSaMcyMAUvbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XydNCm+g; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fmC1BHlN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XydNCm+g"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fmC1BHlN" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65ACCI5M1472699 for ; Wed, 10 Jun 2026 12:54:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rfn5CQTKJf6IkNhsBjO5J7E8yuSH1p8S8jIJE2Un3lg=; b=XydNCm+go+q1304j SrF6PFBm5jgZBlDLdKpSXphrqx5zF/EMzcNW8i4GP2yxO1xTcgdCD60wxI5TJKY8 B/Ur5OCkVqK3vIHBJ+YfDvv5I+rbUKWzV7mFd0QKMCbYFrt8mbKpBiMdbvFgRoRf 0EXqMmdmT9lYoxRnSTCLlrI+Df5dpfBeaLvsEmOBR7SfQg9iV7MCqk97UcfIVQ75 XlYWL+IIX7Omwck8E6GHD0W5YNQtcH2OK5DH3LMt4hae1PV3yf5jljzsbcdM9XMr 37nVlHtqwSMaEKCQ3OON1raFPh+7hNp0JTu4Y6rs9Tb6I83t+iI+/t15VG3v5/28 qKhbxw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eq0kd9w49-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 12:54:46 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8cce360a385so15089696d6.3 for ; Wed, 10 Jun 2026 05:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781096086; x=1781700886; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rfn5CQTKJf6IkNhsBjO5J7E8yuSH1p8S8jIJE2Un3lg=; b=fmC1BHlN8M8GZoFCRfv+sCpVNwiRP6N+atK+kx5ySJA8Uz7rbUR/hVCkR1hYh/ZMkl FHlJ/UPT5ivwjqkb7Vrnpq6PBqnrfQJFjie9Mp2Ab1oTou14U42SkXiigYya5yygWQTo DmjVyTdiI6OIdADFbzi8LCd0Kx5dJXCReF3aTq8fpakUnai8xWwCnF/jkLgbjgYW+8pe AUn0oXR2oxbs+j/2YGBU/FRCWtkGNl1whnzhKB4ByqzL253L62FQdhjiy1qqVobeWlyd sjHYmkvC5Qk34NbrwY3jTLDPphgaHR3VBurm/qJaMKL0CG9BCwBLTUTxLECNRM5HKRv6 mOwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781096086; x=1781700886; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rfn5CQTKJf6IkNhsBjO5J7E8yuSH1p8S8jIJE2Un3lg=; b=YCZcjf+MtE5PovRQDo95+wi/zqb2MT2mOt0KslfgIXTjQlZHnhRX+gMEwHJ2f5B7R1 BKMR8KblHGqHQr2GSvbugwCOvWY2kiwnvX6ywVDrCSVJL+9vGLRxcj4d/3YlM3yQaE/u FLLzCH0KzOsYhO9+Ua+KpiAE8aYm20m0yKEOfZxKcfxO5lR+j20J61l5cxtv6bIkg1Me /p6TsKik2nAzkSsEVrqZ8U0DTnv5VrOiKGJzgHED0b388iwGJnKW6fGGHwHmpG8Kr8Ei GL+w15wju7VbyiYinXfascqFGTGKnOR47V69oZFKAad0ksD/HWpfotF4xT7xlRHeM9Wm PT7A== X-Forwarded-Encrypted: i=1; AFNElJ8Yb+GnZvtqPJ/v9GH7WHcITbXrZO9tlKEHInqqNppXEFC82qApo8oS1Y+hK/epJ4QpTO7/+0GDkIlqLMM=@vger.kernel.org X-Gm-Message-State: AOJu0YyGffoc6h5Nezl7FcGJoGF0iIf+H6MiiydjFymSMOQKqBDiYoTC 5MgAdex1DSRaMp3wo+KhhFhZM1hNHQqh+9IjMmVYGaSM2u/UkgLdrgW9HnJ4ZMCjmQWe03+yp7I HiuovR+VUVlaQKhz55GOQC7058vDjG0FRBRwx34AD0L+k/tBJNPNgkdA8Q5NM/HUPu1E= X-Gm-Gg: Acq92OH7siwbV6FggiYkfgMqjXOlYHg3EXiiyG8iNGm3bbz8qCoXyAzBHj+fS0jkUN7 co/V7NCou3G1VxMeKgBy5F3kBgM9ndLIzJmWauiC3EpOxJdi2QzmiRGEikToqm6drszmCUqy9ca lWwL/zgYrl2Eb08H4kAEZH9MnHe3xIbSU+BhrE2+4OMYEgyJlRk0RA8r7RIgIl74rlIHQEGWe1S xQI2fcnfHStW7jZqbnQD+jUX/taOzMNSgt7V6724LwzuJiAV5gRAy0kdFZTb26036I5aHuct7NK 8CAZ90ifcT55j0ktfW8Ee87CXRcs6dJFJCABa7I4tw4912Ln3SBc7aXjHjClHBNhEFstQle1wPQ 9Iasb7xsVXMxRlC96Tb/fWilyo9mQmzV5iGUmJAFWHozO8JvGVaWzpXbI X-Received: by 2002:a05:620a:4594:b0:902:daaf:22cd with SMTP id af79cd13be357-915a9a3c617mr2398717585a.0.1781096086368; Wed, 10 Jun 2026 05:54:46 -0700 (PDT) X-Received: by 2002:a05:620a:4594:b0:902:daaf:22cd with SMTP id af79cd13be357-915a9a3c617mr2398715785a.0.1781096085876; Wed, 10 Jun 2026 05:54:45 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf0559f1464sm1201149866b.55.2026.06.10.05.54.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 05:54:45 -0700 (PDT) Message-ID: <760a8b79-2ea6-4a88-85b7-79c91930dd19@oss.qualcomm.com> Date: Wed, 10 Jun 2026 14:54:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] media: qcom: iris: guard IRQ handler with runtime PM check To: Hungyu Lin Cc: linux-media@vger.kernel.org, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, abhinav.kumar@linux.dev, bod@kernel.org, mchehab@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260608001128.80090-1-dennylin0707@gmail.com> <6ce9188f-aaeb-4ce5-bfc1-28b4f45a9224@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=TeamcxQh c=1 sm=1 tr=0 ts=6a295e97 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=Jr_2U7P3-8ILDYtR5L4A:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: UFDqxlzLROfoUFY7vX8WCrh6KoUhmH2f X-Proofpoint-ORIG-GUID: UFDqxlzLROfoUFY7vX8WCrh6KoUhmH2f X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDEyMyBTYWx0ZWRfXytqAKnoXOvvr vYWAbiDgEEaOqzYbG1M4RQ2TQSgIC+mlh/xl22DWiUX3csp3PBbYQ/Jhoj2p5dJaWbfWEYIDwxY 1ZXBQbOsprpG8WIf0Whff5NNcCvYF7C55QHyfpRNU/4NDwe/21pgvkob6RZFMTYsTBOixKLI5iI wvplPinUYXu8vYcQMinXUYUR0ndW7pLeiXu6NyozVK818eo98mEvZjY8DJ0gUV+BDhjw0M2Aqbx Kz1KMPTBWv2ZwS4tb23/LheybgNUxzEjtJc2JBQInh+3d4Fc2Ebaf2oJTu9kESE3jhOz/X0gUZs 8GACt2gZ9T0dH7gRJb1Xbg7D98Gc6qlVxm3Z0N/jybh9ShW4xIAVBo/I6wJanf9jwD7btoYFrsy 5a4Lx4oRaykYrETfg0+1XjDUPkythXCRO4b7LSqDQjKWUao8x6tW3OZOpkQ6g1fAE794Qlmm/ez LsHAFmxWqhQSVW+Xelw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100123 On 6/8/26 10:28 AM, Hungyu Lin wrote: >> Have you actually hit this issue, or is it purely theoretical? We >> shouldn't be receiving interrupts at the tail end of suspend callbacks >> (and there's a disable_irq_nosync() right after the HW is disabled) > > I have not observed this on hardware. > > My concern comes from disable_irq_nosync(). > > Its documentation states that it does not ensure > existing instances of the IRQ handler have completed > before returning. Then let's just replace disable_irq_nosync with disable_irq, I think this will solve this issue Konrad