From: Randy Dunlap <rdunlap@infradead.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
John Stultz <john.stultz@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] clocksource: acpi_pm: fix return value of __setup handler
Date: Sat, 12 Mar 2022 11:23:42 -0800 [thread overview]
Message-ID: <760e1916-09cf-11ec-122f-d30e339dca0d@infradead.org> (raw)
In-Reply-To: <20220312070941.GP3315@kadam>
On 3/11/22 23:09, Dan Carpenter wrote:
> On Tue, Mar 08, 2022 at 08:03:01PM -0800, Randy Dunlap wrote:
>> __setup() handlers should return 1 to obsolete_checksetup() in
>> init/main.c to indicate that the boot option has been handled.
>> A return of 0 causes the boot option/value to be listed as an Unknown
>> kernel parameter and added to init's (limited) environment strings.
>>
>> The __setup() handler interface isn't meant to handle negative return
>> values -- they are non-zero, so they mean "handled" (like a return
>> value of 1 does), but that's just a quirk. So return 1 from
>> parse_pmtmr(). Also print a warning message if kstrtouint() returns
>> an error.
>>
>> Fixes: 60e3bf14d4e2 ("clocksource: clean up parse_pmtmr()")
>
> I was wondering why I was CC'd on this.
>
> This fixes tag is wrong... My patch just cleaned up the function.
> The original code returned negative error codes already.
OK, thanks for the info.
--
~Randy
prev parent reply other threads:[~2022-03-12 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 4:03 Randy Dunlap
2022-03-09 8:56 ` Dan Carpenter
2022-03-12 7:09 ` Dan Carpenter
2022-03-12 19:23 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=760e1916-09cf-11ec-122f-d30e339dca0d@infradead.org \
--to=rdunlap@infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel.lezcano@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®