From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751207AbdBWLDm (ORCPT ); Thu, 23 Feb 2017 06:03:42 -0500 Received: from foss.arm.com ([217.140.101.70]:53868 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbdBWLDk (ORCPT ); Thu, 23 Feb 2017 06:03:40 -0500 Subject: Re: [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G To: Chunyan Zhang References: <1487660104-15693-1-git-send-email-chunyan.zhang@spreadtrum.com> <1487660104-15693-2-git-send-email-chunyan.zhang@spreadtrum.com> <20170221162744.GA29581@linaro.org> <20170222034632.GA18116@spreadtrum.com> Cc: Mathieu Poirier , Sudeep Holla , Rob Herring , Mark Rutland , Greg KH , Catalin Marinas , Will Deacon , Arnd Bergmann , "devicetree@vger.kernel.org" , Orson Zhai , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" From: Sudeep Holla Organization: ARM Message-ID: <76146c97-d4ff-7058-0ca7-6b2baa3bf5fe@arm.com> Date: Thu, 23 Feb 2017 10:56:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chunyan, On 23/02/17 06:20, Chunyan Zhang wrote: [...] >>> I noticed Juno use the 2), would you suggest that way? >> >> It is better to describe the HW component themselves rather than where >> they are in the topology - the address of the component will make sure >> the names are unique. So just the component type (etm, funnel, >> replicator, ....) and the address they are located at. >> > > OK. And to avoid making other person confused in the future, is it > better to revise juno-base.dtsi according to this convention? > Yes, it was noticed by Olof and should be now fixed for v4.11(already queued). You can check linux-next if you want to have a look before it gets merged. -- Regards, Sudeep