From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: Sang-Heon Jeon <ekffu200098@gmail.com>,
Harry Yoo <harry@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>, Hao Li <hao.li@linux.dev>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Roman Gushchin <roman.gushchin@linux.dev>
Subject: Re: [PATCH v2] mm/slab: remove outdated comment in create_kmalloc_caches()
Date: Thu, 12 Nov 2026 16:00:58 +0100 [thread overview]
Message-ID: <76157846-e30e-46b0-b767-0902e3f8c82a@kernel.org> (raw)
In-Reply-To: <20261112144653.840367-1-ekffu200098@gmail.com>
On 11/12/26 15:46, Sang-Heon Jeon wrote:
> Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
> removed SLAB, no kmalloc cache is created before create_kmalloc_caches().
>
> So remove the outdated and redundant comment.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Reviewed-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
> ---
> Changes from v1 [1]
> - Remove the whole useless comment
>
> [1] https://lore.kernel.org/all/20261104144753.2266231-1-ekffu200098@gmail.com/
>
> ---
> mm/slab_common.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index 01c64ef661e7..10603b9cbb53 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1028,11 +1028,6 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type)
> kmalloc_caches[type][idx] = kmalloc_caches[type][aligned_idx];
> }
>
> -/*
> - * Create the kmalloc array. Some of the regular kmalloc arrays
> - * may already have been created because they were needed to
> - * enable allocations for slab creation.
> - */
> void __init create_kmalloc_caches(void)
> {
> int i;
>
> base-commit: ce6518e61e3b4bf4f97f7ac6204049b9eba7eb75
next prev parent reply other threads:[~2026-11-12 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 14:46 Sang-Heon Jeon
2026-11-12 15:00 ` Vlastimil Babka (SUSE) [this message]
2026-11-12 15:06 ` Harry Yoo (Meta)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76157846-e30e-46b0-b767-0902e3f8c82a@kernel.org \
--to=vbabka@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=ekffu200098@gmail.com \
--cc=hao.li@linux.dev \
--cc=harry@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®