From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbcEISkR (ORCPT ); Mon, 9 May 2016 14:40:17 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:64807 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbcEISkO (ORCPT ); Mon, 9 May 2016 14:40:14 -0400 To: CC: LKML , kernel-team From: Josef Bacik Subject: Regression introduced by cf6d445f68974d0b15a14cf6021be38a91f2b5d8 Message-ID: <761b4a2a-0332-7954-f030-c6639f949612@fb.com> Date: Mon, 9 May 2016 14:39:34 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:200::6:8dfe] X-ClientProxiedBy: CY1PR18CA0032.namprd18.prod.outlook.com (10.163.31.42) To BN3PR15MB0834.namprd15.prod.outlook.com (10.165.80.26) X-MS-Office365-Filtering-Correlation-Id: d234b21b-25af-42a1-3de9-08d3783949ca X-Microsoft-Exchange-Diagnostics: 1;BN3PR15MB0834;2:h6iQy4fcIn4YZDOZjBc4IUWu+WWH+A17Zsg/ciryaSBR4BFOXlA5qJPbvq4khBUL2HiyUY6GqZ1ZYsAeU6wIckP4A5ae+J9l+cPzP70p25ts+9aLao8dp9OO7ntnP4yGFarzLK0vfrJeAhF6L1BSLfxN6W/1ZyYLA4a2an0z9/MJOTMVNgfHuUnRRqJCdHot;3:DuduUFD1hHw0F7QYtmMg3i24cExMxEV2SfwqmNJvIS66QKDMhd5sALXJ+zkkTETrkO5Xvk2k4hd5x4YTvY9uUgTwwrJUd59EIEsxlG9nI/+BtVwxw198kSuiLN93c1S0;25:NTi+K/8zm+xyG8HDaIDoN231AuzDlxryj60AHaA5dYS7TnJ1VdGHxld1wL9K3SLKYcG66dNE06TTPrPdund19rRj4+QflCz9VSis2zYCdh0SHcz6FHxAklkWYMxi+5QC2/iAptK/1RWBsDaj7kYdUjpuqv3FBq1JhkZU0jlwyallvXYpEea1TiEWn3KE79QuQDyLWaf6uRiMXIvesK2jmZirBvmiIPPid0zSLaTWIiNiKffMoHJnP5/DMbS7gmtzBDNlV7iWMm7I9KgsS878mjmgpfJHtTg+BtgCgobUdga5fKd3K/DvlPUTT9SFSXuG3bxggx3osi5y44qmnlssdB/W1+aoKItmvrmzWxorqt4c8iZPy30lKMgyEWPb6ci0LHwVpkT104Fu4TcMCjrKL8PM5LAoHuK3T+uDq8gouiYXZOehQfjJ/9VCHTGluueV;20:lt81ylcSyT3b0tTvhAjKKlnlv1al29vqVUgnrRBaPuNkRwEEdYQnCXMFCQQIxoEpGrMfmjLLevGkB0eGP8HVp6EPjiVLYht62AuW+nT4TnDjRy/tTor8VhCrJPMnJmV0CvsHtdkQtgKf/SLZ/wfgcVWiAznFVfnmRUQLT2xLfdI= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR15MB0834; X-LD-Processed: 8ae927fe-1255-47a7-a2af-5f3a069daaa2,ExtAddr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN3PR15MB0834;BCL:0;PCL:0;RULEID:;SRVR:BN3PR15MB0834; X-Microsoft-Exchange-Diagnostics: 1;BN3PR15MB0834;4:mU5kaEcDGLAXgmcfbkjRm6Cixbc54GeNuco+fXxptoOQdXaHQKD/nBj5u5qT/rNtKtPPR7GsUBBmPZfQ9mm8zAIk//C5LDr1gO6yaByiDJ3p0IX5c8DoFu+LdJLYszRRmq4Pj5p4YVNWeYk9Sh0wxuDkb49uGWsNLqD2UbzjTjdvZQn1p+4j72aBqL9pg5joWh05yAGne9iEZ5YKwa7QM1sbkqi6QNpzAiptRzc2OmcO8EfUHQtGhMv2fMCBtRBA321NkuSInrQt34yjTCym33hrUpOBHiOHQSRkSQhWK2ckcjMZLyKFlnj+OzADytY4VFaAhMJVyXN0LeF+F3ZwODr4bu2b4qu60Y9BpQqQwCCFu8P55zpGxli5liG+uypm X-Forefront-PRVS: 0937FB07C5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6069001)(77096005)(47776003)(81166005)(23676002)(2906002)(4326007)(36756003)(42186005)(31686004)(65956001)(65806001)(110136002)(5004730100002)(6116002)(92566002)(586003)(2351001)(31696002)(54356999)(86362001)(229853001)(50986999)(4001350100001)(189998001)(50466002)(33646002)(230700001)(5008740100001)(64126003)(83506001)(65826006)(15760500001)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR15MB0834;H:localhost.localdomain;FPR:;SPF:None;MLV:nov;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjE1TUIwODM0OzIzOjN0NnFCVnpKbWpqby9hdUQrSkUwc0VPanFs?= =?utf-8?B?RmtrVENaTHdoRldTa1M4Mk1QTDdFU1cwd3N2TUY2MDZieFROSVg3Vko4Mjdo?= =?utf-8?B?NVNSV0QvS2lIVnNUOXFGOWFURGo2RmRxNGliZ0x2Zk1iN2NUZk1JUk0zQ1dy?= =?utf-8?B?NUtqdUFjTytjOFlnU29sZWN2SHRzWUR4WnJnL2p0U2NndENSZ2pKcmkvcmZO?= =?utf-8?B?TnhvZ1Z2Qm1nYWQrYlk0L1BtMk84b3BBeHA1b1k2UVVUdStHTzc5Zm1pVUJH?= =?utf-8?B?MTE2KzFzNjJIQWhmU001ZzFYNlh2WnFVSk0wY0tjSXkwNGhHQ0N3cVZxRFdM?= =?utf-8?B?YTBsMkY0Q0R6dmdJQ0tTYzBQcHRZSHphZW9PeEY0bWNUaThDL1NBcGJCTE9p?= =?utf-8?B?RlJPWTI1bmRSY00ybjd3djBPZGRHblRkOERuU0RlSkFoaFg5dWhzV1J0MEZx?= =?utf-8?B?NTZkeHIrWSticlBaWDJiODhLbG93WE0zSnNzYWpTcHRhVEtWRVFGSXBxYTV2?= =?utf-8?B?Z0RpODJQM1FEaDEvb0lDckd3bERsTjVpY21BSkZpTVp6Q0w5ZWE0YzVEMGhv?= =?utf-8?B?c3Y0Z1JkSUt2SndvUFlRT1JFSlloazgweHFtcVJyMmJFR1gwZUttZThLc0Nj?= =?utf-8?B?NFZKRmk3THcxSExndVdPcE9rQkhhNWllaVpqSVBURmk2bFVBT3gwRERLTGlN?= =?utf-8?B?RWtxa3hvQUtpWk9wRTI2NjdnQW1qMEY0U3lSODNnbUZlb3V2dWFnNEhmSno5?= =?utf-8?B?TTNDRUJodVFCNCtnZXhlR0hjMXhWdFh1bnNYd0dsaEdvVGkwcGxwcEVySlJK?= =?utf-8?B?SlJXaHc1NU1UbGJpZWRZYVZNdFF5ZS8xRmxLVU1ZZnJCRDViUTAyeTAwQ0dR?= =?utf-8?B?ek5lWDJyaEpUcVZOVVMyeFU0YnFuKzRZcW9hWUFkeHJRSWZmT0FYOGcvV2Ft?= =?utf-8?B?NnRlOERmZERVL3BraEp2ZHBXVnkwQnVmbUVla2xRUWJPdGU0N0VQdWhiMlZo?= =?utf-8?B?S2NIeFFlVndWNi82SzN5L2FsN1RlZGFJZTdub0hSZCtZbDQvdXM5Vi83RW01?= =?utf-8?B?YzN4d2owRTJ1T0VZR09HamE2RldQYVdwZ05ucUlGVU9VbExPRFM3WEk3Z0Fr?= =?utf-8?B?bnlzWTBCZzdHR3BuVXZESzlteEFSMXQvQUtsQjVFVFVCdUhvU3NoeDJKRTF2?= =?utf-8?B?MFZpQ0JQWUVUV2d6S2hDcGtjMmlCQTJXMUpHRVkvc3NSNStPaHdxL21CVEdO?= =?utf-8?B?NjRtVi9jdFFMTHROcHQ0Z25XOXV5WXBFeFljb05sTjBiZExtaHh4UEtiWldp?= =?utf-8?B?MzJqUjNtVkJVM0E9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR15MB0834;5:rrZ3kxZIj+aMFFOTtwFPErkAVaLIOh5TbuBv3bAdWs88+jGr0qX9PQkTcGmlhAnshvYsRtqo4i+Ne9zkG4dJrrAFeZHzB2NtftLQVbO0xhDVScvoCqzOe5t0xmqW4NaOSM4oxUqwTmHXSVU5uaY8Cg==;24:8QOXZF3I7aj1fNlnIhpiRijV323Y9Wa+S1+xk7u/RG+90Bz/22cjq2iMb8r6cP15a/43t7MNojaUY0XZBDZGNiArHDRwLvP+jrG2+FQod+8=;7:IEtexn8J0FXY6jfUZcGj1aRDWt5Dj4Bqj6UoYwIuNvUl+y7L135lyyaG0nIxcN91k2T1sKQ0p7N4yqAvbbBwRsu0uGfZ1A4Rc6gZOWP9+nognToto+3wXiqDzlpQx2UaG+TnNklxiqG/mYI1QZ7Si2q+VfQgZEP+D7l4SCdPrBIQi2Ri/IFdWjGhRuw+lQQy;20:LzlBNI6OBJmaUGXoa09iWp4NWgfk3WgvLt5xorxzeYbRF0Nyt4F6o4XUCDkWxx/X7V+usDXpg1/tf1fOsE8HCxBdpMLD9ZDLhLPD7moTxQQr1AoSE2Aa3KxeyQ9h/xMpBtM9VyHiiWFNHHptETI+pwicURfXHrnVzSB4io9ifNo= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2016 18:39:43.0519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR15MB0834 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-05-09_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, I've hit a regression that was introduced by the commit in $SUBJECT. I'm building a minimal kernel config that doesn't have CONFIG_SMP set, which results in the topology for the box to look different than with CONFIG_SMP set. Specifically boot_cpu_data.x86_max_cores comes out to 16 without CONFIG_SMP set, but 12 with CONFIG_SMP set. So when we are doing the init for the uncore_msr_uncores types we panic when trying to do uncore_box_init on the 13th box for hswep_uncore_cbox when doing the wrmsrl in snbep_uncore_msr_init_box(). I'm hoping this makes sense to you, because this is all greek to me. For now I've just enabled CONFIG_SMP (it only adds like .1 mb to my image), but I figure we should probably fix this. It takes me no time to reproduce so I can test whatever patch you come up with, or run whatever debugging you want me to run. Thanks, Josef