From: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Kumar Patro <bibek.patro@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v5 1/3] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings
Date: Wed, 18 Nov 2026 12:30:24 +0530 [thread overview]
Message-ID: <761bd59f-4ac2-4e62-896c-57d15fedc6f9@oss.qualcomm.com> (raw)
In-Reply-To: <20261116-boisterous-ancient-macaw-8cc00e@quoll>
On 11/16/2026 4:28 PM, Krzysztof Kozlowski wrote:
> On Fri, Nov 13, 2026 at 08:02:20PM +0530, Komal Bajaj wrote:
>> qcom,pas-common.yaml limits iommus to a single entry for every PAS
>> remoteproc, which is too restrictive for SoCs whose firmware uses
>> multiple IOMMU streams.
>>
>> Drop iommus from common binding and let each SoC-specific binding declare
>> it with its own limits. These bindings set unevaluatedProperties: false,
>> so a compatible that does not declare iommus rejects it. Declare it for
> I do not understand this sentence. Compatible cannot declare iommus, but
> anyway the bindings do not reject it.
Right. Wording was incorrect, compatible does not declare property but
schema does. I will reword this in next revision.
What I meant was that these bindings set unevaluatedProperties: false.
Therefore, once iommus is removed from qcom,pas-common.yaml, any schema
that does not define iommus itself will reject a node containing it with -
"Unevaluated properties are not allowed ('iommus' was unexpected)"
>
>> every compatible whose nodes use it.
>>
>> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
>> ---
>> .../devicetree/bindings/remoteproc/qcom,pas-common.yaml | 3 ---
>> .../devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml | 4 ++++
>> .../devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml | 12 ++++++++++++
>> .../devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml | 13 +++++++++++++
>> .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 15 +++++++++++++++
>> 5 files changed, 44 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
>> index f75cab6b4ed9..4662fe4cff62 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
>> @@ -32,9 +32,6 @@ properties:
>> minItems: 5
>> maxItems: 6
>>
>> - iommus:
>> - maxItems: 1
>> -
>> power-domains:
>> minItems: 1
>> maxItems: 3
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>> index dda2d144b720..3c35da52204d 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>> @@ -38,6 +38,10 @@ properties:
>> reg:
>> maxItems: 1
>>
>> + iommus:
>> + maxItems: 1
>> + description: Firmware Stream
>> +
>> clocks:
>> items:
>> - description: XO clock
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
>> index b20780e5e26b..8aebc785f212 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
>> @@ -169,6 +169,18 @@ allOf:
>> - const: cx
>> - const: mx
>>
>> + - if:
>> + properties:
>> + compatible:
>> + enum:
>> + - qcom,sc7280-adsp-pas
>> + - qcom,sc7280-cdsp-pas
>> + then:
>> + properties:
>> + iommus:
>> + maxItems: 1
> Same comments as before - missing property definition. Properties should
> not be defined in conditional blocks. If you remove property from common
> schema, then you remove it from every device referencing it. Nothing in
> commit msg explains such intention and reason why.
I will update this and keep it as a no-functional-change.
> Either iommus is valid or is not. If it is not, then need mentioning in
> commit msg for example and then you drop it from common schema and add
> it to the bindings where it is valid.
I will cover this in a separate commit.
Thanks
Komal
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-11-18 7:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 14:32 [PATCH v5 0/3] arm64: dts: qcom: shikra: Add EL2 overlay for EVK variants Komal Bajaj
2026-11-13 14:32 ` [PATCH v5 1/3] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings Komal Bajaj
2026-11-16 10:58 ` Krzysztof Kozlowski
2026-11-17 15:52 ` Mukesh Ojha
2026-11-18 6:53 ` Komal Bajaj
2026-11-18 7:00 ` Komal Bajaj [this message]
2026-11-13 14:32 ` [PATCH v5 2/3] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints Komal Bajaj
2026-11-16 10:59 ` Krzysztof Kozlowski
2026-11-13 14:32 ` [PATCH v5 3/3] arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings Komal Bajaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761bd59f-4ac2-4e62-896c-57d15fedc6f9@oss.qualcomm.com \
--to=komal.bajaj@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=bibek.patro@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®