From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC4232980B0 for ; Fri, 23 May 2025 19:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748029157; cv=none; b=mBOw8ayNBQSPJlQdfeDkl1+Hvawp0hMjWVVeTi5CP8RNZTfsBf+5ug3jChyHRFWjevQBxTUwH17N0xxaFNIHC/fzew4FZMBiHyOeneXL5ZkGSZTTABCIwaC/6ZqnzIDTsRhNZ7CEpL93FQ9PSd0ZqHhHi6F0/+RAUtevyrdFDi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748029157; c=relaxed/simple; bh=UwjCwu+hoD5QvbENA5EagwHCA8S9dgr+/m5BQ31GkaQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RGC7KFSWEps+3/dEp3mxRrf+ldoHUhHcW9yDIsT9TEME0mh0fwiFKk9vFsh7vRz4xzyhG16XY6LF7VGUcvyNql20x6EWXq6hXSLPKstbxTj59pTvEJgV0bo7IzxUJEx64PuoE7OediAI/uy4D8GcHv9CacL1SAbVNVJHE0ljwJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZtyZr2yr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZtyZr2yr" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54NAmI3p020973 for ; Fri, 23 May 2025 19:39:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z9XB99CT/fAlMSiqksbkH8KqSrgQ0U0y6auihnvVBOU=; b=ZtyZr2yr5RVArOcm 8nBdyIX9wsKyw2R0Injxps3ytEooWWxhiMs9+O96j1MSkwXYFYzmkxuitdDjbfYq vYu3FCMcwUipDcbyT8CSYuPHJIHyJLg13YeNNMxQQamR24N1DYo9yeXMgdVJ3Qbb d2UejA9PSFktGRqVc5lf/3xNQxa9x/LwRd6xp8Rl21G6U4SXXNHyYJ0g38eI0VZN 6W8nSnQI14TnIubBbB0Zs2eSNyyc/WhvGyAXRduAG8iJoy8t9cEp5Cx+CfE3QYe6 DXT562RkCHduDgdsVBFPFZgkaZbpAUIwGj+Qk9JPXHftYKENlLd65Y1f8DU109SU uvKusw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46rwf0b79w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 23 May 2025 19:39:14 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4767b8e990fso139671cf.0 for ; Fri, 23 May 2025 12:39:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748029153; x=1748633953; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z9XB99CT/fAlMSiqksbkH8KqSrgQ0U0y6auihnvVBOU=; b=UfrFFLNOZUwN3SyvFeP4UTtjaSaOCHa7QIdLLrtPHZwX6FiUMlIJRunfTKtqExBFd8 u4lKoMTlNRsz58mxLtmDn7w5yKWW+O6VQeImgkXjxQbOcydoFyQU2M6kLsbd9nQtV1CA jx2usUnb1ZZ37zfJd9JhOHHMp1l+scC3GiMBx94V5X1eZN/cA4F0HUmp3XJzSzV82YaP EiT149uJbZ13XmmSvF5A/97VYg/S/dETdpEr9gf8AJTa+Fr8oKSKHPO5sPBy9pjozRe1 7d7aguVgcoJeds7LJSHZdfO7647/BJ/pzj0Ds7yaDU67Z1opVXx7gwAUAGkFO4QIpnbY uTiA== X-Forwarded-Encrypted: i=1; AJvYcCXoM5UOppyMhyK9efZJ1ve1sQV2dgrfaogAntTexKb52uVRt7CVu132BPLgw7Fi+X4yiE1fUsAz+LOvEzQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyzcn/wjt23PxCCNh7J9mm4x9kItJaATKNU1gsLe+PiC552ey+C Tg4jFdPHzXNCetp7AQaYTLoVIS1HShfzAldRI5tzbLLcjixFzbgsx/xVDm8xdRlU59MSc0FED7U jNZN5gi/mW0fUxgIc/SVduy38qe38ldCYu0eMDv3GqF/d9A8Ve1aktNfde0a3xIr79A8= X-Gm-Gg: ASbGncvCFVRdn2dVDgGpJVLIGtCsBa/ZpxVR7XwRYz5QKQeNPG2jIaSWQwUBO/exRNz Wg9QpCd10PUeLdL2U56RoV3CrBiW0S5qTQe/WC/GUEaUfswkWmpQSlTjkR+AcixFeUakEdr8gN4 tbCWjI/lksbH24KDz2pfZq/VazHDW/A9BB9n8GEYmwrXhx2VS2uLcQ9ruwL70Ds8XfHrZeWv//t w+nvgTcuVcaTHgVxiaxggoC6zKWEEgmWRfUQvzZbXq8JlOKPeKbPEZDwoKccLI32EO1eYBoP8f3 3FIvzuNj5YdPy08v5WsVNYjekolCC2chTNWUuLlJ3E9RHlQxqBnXrUhxlrDXFQiUHw== X-Received: by 2002:a05:622a:408:b0:472:58b:463f with SMTP id d75a77b69052e-49f4625a717mr2814061cf.3.1748029153119; Fri, 23 May 2025 12:39:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnPTlDiHsFRsc/53DfqBHHewY94m5nSrjK/NZWsZOAvwCTZUQy5z9CnHlIfIbegggC4dKHNQ== X-Received: by 2002:a05:622a:408:b0:472:58b:463f with SMTP id d75a77b69052e-49f4625a717mr2813871cf.3.1748029152757; Fri, 23 May 2025 12:39:12 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d438c3csm1266798466b.88.2025.05.23.12.39.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 May 2025 12:39:12 -0700 (PDT) Message-ID: <76267be1-1ace-437f-9394-ee56d4e8ffb2@oss.qualcomm.com> Date: Fri, 23 May 2025 21:39:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: qcm2290: Add IPA nodes To: Wojciech Slenska , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alex Elder , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20241220073540.37631-1-wojciech.slenska@gmail.com> <20241220073540.37631-3-wojciech.slenska@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241220073540.37631-3-wojciech.slenska@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: _HPmNmk8h2mczXHLERYOobx1_gVvHaTw X-Proofpoint-ORIG-GUID: _HPmNmk8h2mczXHLERYOobx1_gVvHaTw X-Authority-Analysis: v=2.4 cv=ZP3XmW7b c=1 sm=1 tr=0 ts=6830cee2 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=pGLkceISAAAA:8 a=wQ2JREbYfKbkpeN3qpUA:9 a=fFxRHlyTGdwQsMLX:21 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIzMDE4MCBTYWx0ZWRfX3ktuw5DqLcOe P1VhCPe9V/vkw7j59p1uMQ1z0KoTye7C4SLsp1X4zvtxJHplBgAPkOkpY8ftL4RSswQSRxhVfyO GAsK5dSG37Gll4PIeKZzbKXwrLAe0x6q20DnZJljv5hnskVwIGSyKNVAvatS+hJJaffEY/j3d8C z2kZirjs+wH0bpbEZxdtcEGeJsACBWx/IEgZzw/lzQkZQi6ylDFfNANP5g5cvc2kX/Ii27I5r6R lDCE/fPHqiOif9G0rAciJ4nCigej//ufd/rEoQq0fR1yr9uA+hwI3ilsWu2OqE7iOEI0IwAv81A ebO5yRRRZIF04HaP9twMwyCUCe3V+Xuc1QNqJAGvAQpSy6e7xP13T4oiw22JvgJtNrugBThhCKP TYZ5LxS7lU30GV8UDT/AaBZ5JY4UhshebRRPOWE8TovzHEa9vh4DU64B0aJhlzw9nh926O4b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-23_06,2025-05-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505230180 On 12/20/24 8:35 AM, Wojciech Slenska wrote: > Added IPA nodes and definitions. > > Signed-off-by: Wojciech Slenska > --- > arch/arm64/boot/dts/qcom/qcm2290.dtsi | 52 +++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > index 79bc42ffb6a1..0d39fd73888a 100644 > --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > @@ -428,6 +428,17 @@ wlan_smp2p_in: wlan-wpss-to-ap { > interrupt-controller; > #interrupt-cells = <2>; > }; > + > + ipa_smp2p_out: ipa-ap-to-modem { > + qcom,entry-name = "ipa"; > + #qcom,smem-state-cells = <1>; > + }; > + > + ipa_smp2p_in: ipa-modem-to-ap { > + qcom,entry-name = "ipa"; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > }; > > soc: soc@0 { > @@ -1431,6 +1442,47 @@ usb_dwc3_ss: endpoint { > }; > }; > > + ipa: ipa@5840000 { > + compatible = "qcom,qcm2290-ipa", "qcom,sc7180-ipa"; > + > + iommus = <&apps_smmu 0x140 0x0>; > + reg = <0x0 0x5840000 0x0 0x7000>, > + <0x0 0x5847000 0x0 0x2000>, > + <0x0 0x5804000 0x0 0x2c000>; Please pad the address parts to 8 hex digits with leading zeroes > + reg-names = "ipa-reg", > + "ipa-shared", > + "gsi"; > + > + interrupts-extended = <&intc GIC_SPI 257 IRQ_TYPE_EDGE_RISING>, > + <&intc GIC_SPI 259 IRQ_TYPE_LEVEL_HIGH>, > + <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > + <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "ipa", > + "gsi", > + "ipa-clock-query", > + "ipa-setup-ready"; > + > + clocks = <&rpmcc RPM_SMD_IPA_CLK>; > + clock-names = "core"; > + > + interconnects = <&system_noc MASTER_IPA RPM_ALWAYS_TAG > + &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>, > + <&system_noc MASTER_IPA RPM_ALWAYS_TAG > + &system_noc SLAVE_IMEM RPM_ALWAYS_TAG>, > + <&bimc MASTER_APPSS_PROC RPM_ALWAYS_TAG > + &config_noc SLAVE_IPA_CFG RPM_ALWAYS_TAG>; this last path should be RPM_ACTIVE_TAG - that makes paths involving the CPU automatically collapse (as per the power management uC's decision) whenever it's possible Konrad