From: Martin KaFai Lau <martin.lau@linux.dev>
To: Alexander Lobakin <aleksander.lobakin@intel.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Song Liu" <song@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 bpf] bpf, test_run: fix &xdp_frame misplacement for LIVE_FRAMES
Date: Wed, 15 Feb 2023 10:04:51 -0800 [thread overview]
Message-ID: <7629c295-fc74-41fe-fd2e-28fe3a6e0846@linux.dev> (raw)
In-Reply-To: <20230215152141.3753548-1-aleksander.lobakin@intel.com>
On 2/15/23 7:21 AM, Alexander Lobakin wrote:
> /* The maximum permissible size is: PAGE_SIZE - sizeof(struct xdp_page_head) -
> - * sizeof(struct skb_shared_info) - XDP_PACKET_HEADROOM = 3368 bytes
> + * sizeof(struct skb_shared_info) - XDP_PACKET_HEADROOM = 3408 bytes
> */
> -#define MAX_PKT_SIZE 3368
> +#define MAX_PKT_SIZE 3408
s390 has a different cache line size:
https://lore.kernel.org/all/20230128000650.1516334-11-iii@linux.ibm.com/
The above s390 fix is in bpf-next. It is better to target this patch for
bpf-next also such that the CI can test it in s390.
next prev parent reply other threads:[~2023-02-15 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 15:21 Alexander Lobakin
2023-02-15 18:04 ` Martin KaFai Lau [this message]
2023-02-15 18:11 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7629c295-fc74-41fe-fd2e-28fe3a6e0846@linux.dev \
--to=martin.lau@linux.dev \
--cc=aleksander.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hawk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=song@kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®