From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755893AbdLORWs (ORCPT <rfc822;w@1wt.eu>);
        Fri, 15 Dec 2017 12:22:48 -0500
Received: from lelnx193.ext.ti.com ([198.47.27.77]:35358 "EHLO
        lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755428AbdLORWp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 15 Dec 2017 12:22:45 -0500
Subject: Re: [PATCH v4 4/6] dt: bindings: lp8860: Add trigger binding to the
 lp8860
To: Pavel Machek <pavel@ucw.cz>
CC: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <rpurdie@rpsys.net>,
        <jacek.anaszewski@gmail.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-leds@vger.kernel.org>
References: <20171212220143.31210-1-dmurphy@ti.com>
 <20171212220143.31210-5-dmurphy@ti.com> <20171215090903.GC8221@amd>
From: Dan Murphy <dmurphy@ti.com>
Message-ID: <76329432-f96e-93ab-ed9b-ade22c8735c9@ti.com>
Date: Fri, 15 Dec 2017 11:22:24 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171215090903.GC8221@amd>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Pavel

On 12/15/2017 03:09 AM, Pavel Machek wrote:
> Hi!
> 
>> @@ -35,6 +37,7 @@ led-controller@2d {
>>  	led@0 {
>>  		reg = <0>;
>>  		label = "white:display_cluster";
>> +		linux,default-trigger = "backlight";
>>  	};
>>  }
> 
> What is "display_cluster"? Is it display backlight?
> 

This device can be configured to drive all 4 LED strings in display mode
so that all 4 strings have the same brightness controlled either through PWM or
through the brightness register 

or

As cluster string where the brightness of individual strings or clustered strings
can be controlled via independent brightness control registers.  I am currently working
on adding this support to the driver.

Dan

> Could we use ":backlight" and perhaps start documentation file listing
> "common" LED descriptions so they are shared across machines?
> 
> For the record, I'd prefer this to be
> "/sys/class/leds/display:white:backlight" in the end... so that we
> have nice naming for userspace, consistent between different machines.
> 
> 									Pavel
> 


-- 
------------------
Dan Murphy