From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4288019E7F7 for ; Thu, 6 Feb 2025 18:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738866321; cv=none; b=WFCtEhrqbJc6BJbVR6cRv/ANAjriNQuomFa75qGey7pP6Fy20h3qo4yrPMMujgRVAM+v6mDt3pcYf+mIqaWHiNgGZlfzlgMHZH88Ro5EI4dXkygYsqp4sM/nNx4h2kkdC4nW3aIpcx7JM5RJRQc1uBWUitMNCWXZ/1hRjh00T7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738866321; c=relaxed/simple; bh=2v6Pb0UuJAp2Ce7J2wyIxsh4DuptF5KuiHw+d0TBU+g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RQer6j4VCciVnlhKJqABNOpingS3IHnBhx8SRGqXCevJhMRhUJkZjqCxn38/OmWBiNBteRd5yZmK6rmym2xi8U2CKnei+gjjzcom0B9SOe1dwfKsAegD6QRV/3XsrKNf0txwW8vK+YRQMSaY7Rs2F5ssSkg49MVyrWejbI9FqPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=inXkckgR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="inXkckgR" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 516HrUEs017927 for ; Thu, 6 Feb 2025 18:25:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1EcH+wIk7SFlGrV9UWgKzwu6ZI6nYNoJsT/9rUuTdgs=; b=inXkckgRmSRB53rF tC9nyODSpmG2UQf+wXe182R70SDgJSMk/qYrSLNZh7qAVdFQ8JjARWyMO4k1H/at jtAWXXymYXeikCiEDkOPcjmYgLXgEAu4OgqlAF9zP7cRXvynElCSbLkSfmnAU5cZ DXKIfciB6Q3vW2tk5oz3oV0NN6m4MKK2/nWylSjgXlD0jHrWeWzWVqDds7q5Udn0 nSwuk3O/GSqsv8xtX+G7ZvTe2ci0qn1AG8MG9nLHkextSGOVhLHV/NqElA1Nfrta j4elcG1sB+dEg/B0NAR0Q7c5nheJUPzaCGnL6NwORe4cxDgIC6F3s8K04aUvGSon BYruZQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44n1vng2u1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 06 Feb 2025 18:25:18 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2f9c34c0048so3488682a91.3 for ; Thu, 06 Feb 2025 10:25:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738866317; x=1739471117; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1EcH+wIk7SFlGrV9UWgKzwu6ZI6nYNoJsT/9rUuTdgs=; b=jBHyxghkeC4qdJe2dzSYPilSo+GFe2ocOWqBylG7yhvyN4YEgrwR44nqn42jvRvlbY ruM53rZXuZCW1/vZM3PuuRaq4p6G6L9EJVMUm/nXJ8BmuU5XUnslXBORhMB9QeqbU9/4 SjJwPyaKX0Kn5crQWywTOqs13RrvxkfTZDPqCr/QvABOkE4R96I4dmHJ3dwyNVhufxzK fLp7Z92fT0cdyEMgJsCnrDjxvGPul9nZNTqliCUTYSrHO8yGYh0ebFeFpW2LkB1zhMjg gbZo+7o9xZ3TEyJdseNu2n6DpHHLmCJQgTPA5af6tkWaVtzS3UUTU7MJUvQ9rIVayi9y IACA== X-Forwarded-Encrypted: i=1; AJvYcCUS3GxopEvJvlCQ0lbNtVoZai39pv44SjIXubPvJqluJLdu9Wb8cgFdBXVRMWGOCNSwSzvlIeNL8dDpJVw=@vger.kernel.org X-Gm-Message-State: AOJu0YxttKXtFOxBFTQDrhxsuL6WkCTXuZJY1HZY3tfnQYfo1ezcS5TZ +FiszY9fwZALCKl3ZioQlh2tDH+QA6UdyJ4F2Ja4otY19UE9P/qdrasbJ0O4RTKSq+3pAoUbqbD 3ggdjl/cncvb29F2RkWb7Zum8+KjC0O7Lq6ynZ6Hi7rzy9jyBSdciyYjdDtI+kuU= X-Gm-Gg: ASbGncur2c2r3dmXOqS60evTltKsbif50qG3QMJES4uo7YwtnVAsth2PaWnO6NXiEWo eAcPdFYsE56D9GhTINz0eP/RAVEdwMlVwIdbAaCPpqkf725joDMTk/cJoYh7X6RUvoAooENl1Em GsmW3i3x6eE46pnDt9wNetq+8p1745+RaVDo+zp5xGNQW3Ho3AOWHSYI30uDr+eSqQeDa8MHZRn 7rhidxq33PU2KOyf7cSMrXjDQcaePprL2oyXNt9f8hUrnBgCfrBy4gy+6ZSEsRYgqcVVhHVmHT9 gRsiADkC8XM/g869/n3Wz0bDsNGpgE/tjJZ+i5gK2P6/fxCHBZbqb3BY9c5Ut5pY2s7cd2gvMQ= = X-Received: by 2002:a17:90b:4d81:b0:2fa:1f1b:3db7 with SMTP id 98e67ed59e1d1-2fa24272512mr75661a91.18.1738866317547; Thu, 06 Feb 2025 10:25:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHciBvji60FFYNw+wOe9jHq7tipWI0mE+EGPEF5DfFHGH1ACVXasewYAUw5HrXPa8KOxve6QQ== X-Received: by 2002:a17:90b:4d81:b0:2fa:1f1b:3db7 with SMTP id 98e67ed59e1d1-2fa24272512mr75461a91.18.1738866315693; Thu, 06 Feb 2025 10:25:15 -0800 (PST) Received: from [192.168.1.111] (c-73-202-227-126.hsd1.ca.comcast.net. [73.202.227.126]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fa099f4d6asm1727996a91.6.2025.02.06.10.25.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2025 10:25:15 -0800 (PST) Message-ID: <7633c19b-2aab-4f2a-8c11-27425f7299ae@oss.qualcomm.com> Date: Thu, 6 Feb 2025 10:25:13 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 25/33] wifi: ath12k: Fix locking in error paths To: Bart Van Assche , Peter Zijlstra Cc: Will Deacon , Christoph Hellwig , Greg Kroah-Hartman , Marco Elver , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , linux-kernel@vger.kernel.org, Karthikeyan Periyasamy , linux-wireless , "ath12k@lists.infradead.org" References: <20250206175114.1974171-1-bvanassche@acm.org> <20250206175114.1974171-26-bvanassche@acm.org> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20250206175114.1974171-26-bvanassche@acm.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: CQPP2U0lnfdrrIxwTRLEUP6BRZX5xgtW X-Proofpoint-GUID: CQPP2U0lnfdrrIxwTRLEUP6BRZX5xgtW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-06_05,2025-02-05_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 spamscore=0 mlxlogscore=841 malwarescore=0 bulkscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502060148 On 2/6/2025 9:51 AM, Bart Van Assche wrote: > If ag->mutex has been locked, unlock it before returning. If it has not > been locked, do not unlock it before returning. These bugs have been > detected by the Clang thread-safety analyzer. > > Cc: Karthikeyan Periyasamy > Cc: Jeff Johnson > Fixes: ee146e11b4d9 ("wifi: ath12k: refactor core start based on hardware group") > Signed-off-by: Bart Van Assche > --- > drivers/net/wireless/ath/ath12k/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath12k/core.c b/drivers/net/wireless/ath/ath12k/core.c > index 0606116d6b9c..212cd935e60a 100644 > --- a/drivers/net/wireless/ath/ath12k/core.c > +++ b/drivers/net/wireless/ath/ath12k/core.c > @@ -1122,16 +1122,18 @@ int ath12k_core_qmi_firmware_ready(struct ath12k_base *ab) > ath12k_core_stop(ab); > mutex_unlock(&ab->core_lock); > } > + mutex_unlock(&ag->mutex); > goto exit; > > err_dp_free: > ath12k_dp_free(ab); > mutex_unlock(&ab->core_lock); > + mutex_unlock(&ag->mutex); > + > err_firmware_stop: > ath12k_qmi_firmware_stop(ab); > > exit: > - mutex_unlock(&ag->mutex); > return ret; > } > This looks like a legitimate issue. Can you submit this as a single patch and cc the ath12k and linux-wireless lists (as I've done in this reply)