mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Andrew Paprocki" <andrew@ishiboo.com>
To: linux-kernel@vger.kernel.org
Cc: "Wim Van Sebroeck" <wim@iguana.be>,
	"Oliver Schuster" <olivers137@aol.com>
Subject: [PATCH] [WATCHDOG] it8712f_wdt Zero MSB timeout byte when disabling watchdog
Date: Wed, 2 Apr 2008 02:43:19 -0400	[thread overview]
Message-ID: <76366b180804012343m629320e9p2c76ec0c900a6450@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

I noticed this while testing the latest code. I'm not sure if it is required,
but the normal (or LSB) timeout value is set to zero, so the MSB should
be as well to stay consistent.

If the chip revision is >= 8, set MSB of the 16-bit timeout value to zero
when disabling the watchdog in it8712f_wdt_disable().

Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>

[-- Attachment #2: 2.6.25-rc8-it8712f_wdt-zero-timeout.txt --]
[-- Type: text/plain, Size: 820 bytes --]

Date: Wed, 2 Apr 2008 02:23:33 -0400
Subject: [PATCH] [WATCHDOG] it8712f_wdt Zero MSB timeout byte when disabling watchdog

If the chip revision is >= 8, set MSB of the 16-bit timeout value to zero
when disabling the watchdog in it8712f_wdt_disable().

Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
---
 drivers/watchdog/it8712f_wdt.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/watchdog/it8712f_wdt.c b/drivers/watchdog/it8712f_wdt.c
index ca90c51..445b7e8 100644
--- a/drivers/watchdog/it8712f_wdt.c
+++ b/drivers/watchdog/it8712f_wdt.c
@@ -200,6 +200,8 @@ it8712f_wdt_disable(void)
 
 	superio_outb(0, WDT_CONFIG);
 	superio_outb(0, WDT_CONTROL);
+	if (revision >= 0x08)
+		superio_outb(0, WDT_TIMEOUT + 1);
 	superio_outb(0, WDT_TIMEOUT);
 
 	superio_exit();
-- 
1.4.4.4


                 reply	other threads:[~2008-04-02  6:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76366b180804012343m629320e9p2c76ec0c900a6450@mail.gmail.com \
    --to=andrew@ishiboo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olivers137@aol.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®